mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eddie James <eajames@linux.ibm.com>
To: Johan Hovold <johan@kernel.org>, Joel Stanley <joel@jms.id.au>
Cc: linux-usb@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v2] USB: serial: pl2303: Add IBM device IDs
Date: Thu, 3 Mar 2022 15:48:37 -0600	[thread overview]
Message-ID: <b1ec9ab3-d621-fa66-0fae-f966242f3f7f@linux.ibm.com> (raw)
In-Reply-To: <YiCU3KI9Dh2psRnK@hovoldconsulting.com>


On 3/3/22 04:13, Johan Hovold wrote:
> On Thu, Mar 03, 2022 at 09:46:05AM +0000, Joel Stanley wrote:
>> On Thu, 3 Mar 2022 at 09:44, Johan Hovold <johan@kernel.org> wrote:
>>> On Thu, Mar 03, 2022 at 09:24:51AM +0000, Joel Stanley wrote:
>>>> On Thu, 3 Mar 2022 at 09:15, Johan Hovold <johan@kernel.org> wrote:
>>>>> On Thu, Mar 03, 2022 at 08:52:29AM +0000, Joel Stanley wrote:
>>>>>> On Thu, 3 Mar 2022 at 08:25, Johan Hovold <johan@kernel.org> wrote:
>>>>>>> On Tue, Mar 01, 2022 at 04:44:46PM -0600, Eddie James wrote:
>>>>>>>> IBM manufactures a PL2303 device for UPS communications. Add the vendor
>>>>>>>> and product IDs so that the PL2303 driver binds to the device.
>>>>>>>>
>>>>>>>> Signed-off-by: Joel Stanley <joel@jms.id.au>
>>>>>>>> Signed-off-by: Eddie James <eajames@linux.ibm.com>
>>>>>>>> ---
>>>>>>>> Changes since v1:
>>>>>>>>   - Fix commit message Signed-off-by ordering.
>>>>>>> Almost there. You're still missing a Co-developed-by tag, a From line,
>>>>>>> or both.
>>>>>> It's neither. This patch was applied to a tree by myself, and I asked
>>>>>> Eddie to send it to mainline for merging.
>>>>> Then you are missing a From line. As the patch looks like know, Eddie is
>>>>> considered the author and not you.
>>>> You are incorrect. Eddie is the author.
>>> Then what is your SoB doing there in the first place? If Eddie is the
>>> sole author as well as the submitter, and you didn't touch the patch in
>>> between, then your SoB does not belong in the chain.
>>>
>>> If you applied Eddie's patch to your shared tree and Eddie generated a
>>> patch from there, then the chain should be:
>>>
>>>          SoB: E
>>>          SoB: J
>>>          SoB: E
>>>
>>> but this is starting to look a bit ridiculous.
>> I agree. I would appreciate it if you applied the patch, with or
>> without my sob in whatever order you deem fit.
> Ok, I'll assume what you intended was E-J-E but that perhaps
> git-format-patch swallowed the last SoB. Thanks for clarifying.
>
> I was going to apply to the patch, but I see now that you didn't provide
> any details about the product apart from it being a UPS and that's not
> reflected in the define name.
>
> Do you have a pointer to device (family) in question?


Hi,


It's a pretty generic pl2303 device and doesn't have to be used for UPS, 
but that is our use-case. Here is a page with some detail about the 
device: 
https://www.ibm.com/docs/en/power9/9009-22A?topic=power-uninterruptible-supply


Thanks,

Eddie


>
> Johan

  reply	other threads:[~2022-03-03 21:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-01 22:44 Eddie James
2022-03-03  8:25 ` Johan Hovold
2022-03-03  8:52   ` Joel Stanley
2022-03-03  9:15     ` Johan Hovold
2022-03-03  9:24       ` Joel Stanley
2022-03-03  9:44         ` Johan Hovold
2022-03-03  9:46           ` Joel Stanley
2022-03-03 10:13             ` Johan Hovold
2022-03-03 21:48               ` Eddie James [this message]
2022-03-04  8:48                 ` Johan Hovold
2022-03-11  9:37                 ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b1ec9ab3-d621-fa66-0fae-f966242f3f7f@linux.ibm.com \
    --to=eajames@linux.ibm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=joel@jms.id.au \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®