From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762197AbdAKO0L (ORCPT ); Wed, 11 Jan 2017 09:26:11 -0500 Received: from mx1.molgen.mpg.de ([141.14.17.9]:39261 "EHLO mx1.molgen.mpg.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762045AbdAKO0J (ORCPT ); Wed, 11 Jan 2017 09:26:09 -0500 Subject: Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer To: Tomas Winkler References: <1484090841-16483-1-git-send-email-tomas.winkler@intel.com> <20170110224956.GA2897@x61s.reliablesolutions.de> <5B8DA87D05A7694D9FA63FD143655C1B5437A09D@hasmsx108.ger.corp.intel.com> <5B8DA87D05A7694D9FA63FD143655C1B5437A315@hasmsx108.ger.corp.intel.com> Cc: Jan Niehusmann , Greg Kroah-Hartman , Alexander Usyskin , linux-kernel@vger.kernel.org, Yu C Chen , Tomi P Sarvela , Thorsten Leemhuis , Daniel Blueman , Len Brown From: Paul Menzel Message-ID: Date: Wed, 11 Jan 2017 15:26:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B5437A315@hasmsx108.ger.corp.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Tomas, On 01/11/17 15:12, Winkler, Tomas wrote: >>> On 01/11/17 10:24, Winkler, Tomas wrote: >>>>> >>>>> On Wed, Jan 11, 2017 at 01:27:21AM +0200, Tomas Winkler wrote: >>>>>> On older platforms the command should be just ignored by the >>>>>> firmware but some older platforms misbehave so it's safer to send >>>>>> the command only if required. >>>>> >>>>> Thanks! This fixes suspend-to-ram for me (on a Thinkpad x201s). >>>> >>>> What about Dell XPS13? >>> >>> With Linus' master branch from today, and Greg's char-misc-linus >>> merged >>> (Merge: 807b93e995d1 546cf3ef9c92), the regression is still there. >> >> Hmm, this should work on KBL.... >> >>> I am now building a Linux kernel image with the two commits touching >>> `bus- fixup.c` reverted. >> >> Thanks for the effort. >> >>> Do you want me to open a separate bug report for that, or continue >>> debugging in the existing report [1], which is currently marked as resolved? >> >> Let's get some more data, shouldn't take long time. >>> >>> Do you have Kaby Lake devices sitting around for testing? >> >> We will of course try to reproduce the issue locally. > > Paul, currently we cannot reproduce this issue on Kaby Lake platforms on our side, It looks like it’s a different issue. Reverting the two commits touching `bus-fixup.c`, did not help. > we would be great for more debug data from your side. > You can get more info by enabling mode debug logs > > echo -n 'module mei +lfp' > /sys/kernel/debug/dynamic_debug/control > echo -n 'module mei_me +lfp' > /sys/kernel/debug/dynamic_debug/control I am currently bisecting to find the culprit. 13 steps will take some time though. Tomas, I believe Intel’s “ACPI department” got access to a Dell XPS13. Kind regards, Paul