Re: [PATCH 1/3] ARM: dts: aspeed: Adding Jabil Rubypass BMC

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 31/05/2022 03:10, David Wang wrote:
> The initial introduction of the jabil server with AST2600 BMC SoC.
> 
> ---
> 
> v5
> - Compatible value chamged to "jabil,rbp-bmc".
> 
> v4
> - Add document the new compatible.
> - Delete redundant blank lines.
> - Add a new line at end of file.
> 
> v3
> - Adjustment entries are ordered by name.
> - Remove the bootargs property and modify the stdout-path property.
> - Group multiple LED devices into a group.
> - Modify the "gpio3_71" node name format.
> - Delete unneeded blank line at the end.
> 
> v2
> - Disable empty i2c bus.
> - Remove gfx node because aspeed-g6.dtsi isn't supported.
> - Modify the led format and add some properties.
> - Fix wrong indentation.
> - Add stdout property in chosen node.
> - Rename temp to temperature-sensor in i2c bus 0.

Thanks for the changes.

> +&lpc_snoop {
> +	snoop-ports = <0x80>;
> +	status = "okay";
> +};
> +

You still have here additional blank line about which I already
commented. Then you removed both blank lines - this one and the usual
trailing one.

I mean... really... Just remove the unneeded one, leaving the proper
patch like every other file in Linux kernel.

Best regards,
Krzysztof