From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E640DCDB474 for ; Mon, 16 Oct 2023 08:01:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231511AbjJPIB0 (ORCPT ); Mon, 16 Oct 2023 04:01:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229478AbjJPIBY (ORCPT ); Mon, 16 Oct 2023 04:01:24 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E314BA1; Mon, 16 Oct 2023 01:01:21 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id CB32D66072AF; Mon, 16 Oct 2023 09:01:19 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1697443280; bh=1qoI2NcTPM67udTkaBwYJkrXK+5Ym0B+bxwOJZO701U=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Vv+mGcDMzBLHWwbe4xCV03VQR6rzeihSWz5RrABE6IOYAxc1bk/uQQrxK4hZT4nUz Hn9T2oOmbNoOGhR3vdx34V0K3HDznRoWYK5cridCg61u69n8jnnOCS77xKwdj0RsTy jtzWSD7Wu8MSbJvxCWWPeaKmFTDJfubF07EUgNViZJOpmffzupOGgT3bNyZSO8vQHd z4BqEYr7Nkjb3/SMwkB2PIu3HnR+UCdYgzdS8IwtYv3pfhKtesFBKfZGbCt3UyUA/W LsaMVWUAiDn7v0C5xPCaOKNfVroN3mzuJd8bdnMO5E+ZBEsU8LEblGeHaBIFF5rbUc SRWXKKqWGBqDg== Message-ID: Date: Mon, 16 Oct 2023 10:01:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v7 15/16] dt-bindings: display: mediatek: split: add compatible for MT8195 Content-Language: en-US To: Krzysztof Kozlowski , Moudy Ho , Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mauro Carvalho Chehab , Matthias Brugger , Hans Verkuil Cc: dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20231012084037.19376-1-moudy.ho@mediatek.com> <20231012084037.19376-16-moudy.ho@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 13/10/23 08:52, Krzysztof Kozlowski ha scritto: > On 12/10/2023 10:40, Moudy Ho wrote: >> Add compatible string and GCE property for MT8195 SPLIT, of >> which is operated by MDP3. >> >> Signed-off-by: Moudy Ho > > >> +allOf: >> + - if: >> + properties: >> + compatible: >> + contains: >> + const: mediatek,mt8195-mdp3-split >> + >> + then: >> + required: >> + - mediatek,gce-client-reg > > else: > mediatek,gce-client-reg: false > > Technically, all of the display components do support GCE, using it is a matter of preference, so disallowing gce-client-reg on anything that is not mt8195-mdp3-split is *technically* wrong, as much as not having that from the beginning was also technically wrong... :-) P.S.: The driver for the display split component doesn't use GCE yet, only mdp3 for now, but again, it's the driver - while the HW is actually capable of using that Cheers, Angelo >> + >> additionalProperties: false >> >> examples: > > Best regards, > Krzysztof >