From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86E3F2192E9 for ; Thu, 17 Apr 2025 07:26:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744874790; cv=none; b=G0eKagDSv8Xi/TqHwt/FIBjXhK2f6lEcCjYfcIVIQlHC88MZrxMO342bAYKElKL0uBbvvvOPZ/sQHWYlm0+9mXIuB+izH3GiT86ER+OmbJ8CdzNt0VpJG01unZuVXu0VJWmKr1rqUw2CxY9zyo1RQ9bmIYZQirm+fLQt71sqGNg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744874790; c=relaxed/simple; bh=Pt4wMjTOPxLyncUhsljlu78aefYEy0zJC2OQzWrprQE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CphVZ3JgZrBikD1bpEelk0h+0t3TYxU3TqfXaL7o2x1YM289ZmemInckgA1VPEV9iXWtDPHrcBSZkK0oOQDpUyOBpxjt8hqw/ChQVArBYPxwfvL66NDwi8nce+IfecDAsRgOI+ot5owIcJpIuWDYo4jSDfsWj2zWlyjs4K2shSI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=H+IJMyzA; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="H+IJMyzA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744874787; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Udp20JCu0lxnLB5nbtOFfZ2GpP06hSOWr1XwI2XNqTs=; b=H+IJMyzAGSpkLDY1iwPhkgG7FkggGIOcWMM/Wnh00s8ugaA3IrtwEGAnUdHztPeYhwQmbF 1N+76SJhCUcq37O2lAJRCFIbLbcMO2jUnlgtgFy4rXnHa0ukxIkPfaNhKsd2Al/HvqDBKP Dvzq2XODTE/rblPsC9UXVou65yf/Jkc= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-341-iDX1iBrEMz-DcA4MOtwM-Q-1; Thu, 17 Apr 2025 03:26:25 -0400 X-MC-Unique: iDX1iBrEMz-DcA4MOtwM-Q-1 X-Mimecast-MFC-AGG-ID: iDX1iBrEMz-DcA4MOtwM-Q_1744874784 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-391492acb59so243748f8f.3 for ; Thu, 17 Apr 2025 00:26:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744874784; x=1745479584; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Udp20JCu0lxnLB5nbtOFfZ2GpP06hSOWr1XwI2XNqTs=; b=o3xBQKQBXICkZfpeeqCEmRuXhIqEqYzYTmvb+C+6Hh/YEyX+Z0ODlXRs9sRsFaIsWH 23Rtg+jmKnX4ZgxiJFqbfT7QkXWySgAXDesK6i2wIrZQzECXtkl10k/UysLbDgoT+58B Jeo1xf/z5mX8XcablVivjE0owRZw/PdJxhZdf0gr2ZRUZg4NIeEQeeOArgj0uFyqFkyF ODUMHcLYyrC48Aw03muECPVFy9Ax7KyDhKQxR7DMzYkp3FwcNosuorF7h7QDl0G1Htza I8K69fDVeJ+QVwmTncY2bWlbFLJY1qr5TJmJ9+AppGkHkzNxqnLMb8GKh0XU8jxoM56O pF6g== X-Forwarded-Encrypted: i=1; AJvYcCUUcOIkwRsEVZ0oCrWJYPvNXV2mTE+eATbNZpcUWrGhaZK4pHXoHMYZmTfVc5dJ8znpKhs4Hv003f6bM+U=@vger.kernel.org X-Gm-Message-State: AOJu0Yzi0eoeibTbKrTfi2Hfsmro+O266XVsqJReZu357Pn7ccDpfIKr QJGmKM2Koc/D3+kl+zXDA28zwSZqJqKJzhsxOsfpDG6/HCGVXAeUgtf+z93Pr5pGX6MlGex4aYn l8sNOA1hGK7edH9hDoZ54TbqKwe7MiZMAtYy8KFvACvc8R57peGsAvrm+C9nSSQ== X-Gm-Gg: ASbGncukYOidPuoUUJrIVCJisOVCpPYO43invDYXein5X73gwaZaRTvgZ8RNg6CukyX L4vRPrNlHH1xtz/zlckmfwRXbQvG1i40XVP8T6THqN1esUcmtilOGTfu10hfeQ3iV07EHgA+nqH aGBoy8IRFzI8PATd13WCkLbp7vWof59gnQCLQvSRnkZ6q3ePlhhQmktVXY3FyLMobkiSVAj/n86 AXfT7aEHc7+266sIPHlWAe1+Z1voM+ccWEhZ0GawDD3tOLVjlZ0+69qU/qqo4xTfjnwMHYVk6f9 p+MQggGZHl5KsO/9HoFErhbomCXXjKlaOSGxx9FNyQ== X-Received: by 2002:a05:6000:144f:b0:391:241d:a13e with SMTP id ffacd0b85a97d-39ee5b9f5b6mr4191466f8f.48.1744874784108; Thu, 17 Apr 2025 00:26:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEX40ws3+eqraZDVy9FNzNzHM8/7zc1TFMhaZr7xBFr7xp/tveKs9AoQ1WnxQPtgH7HvwyHGw== X-Received: by 2002:a05:6000:144f:b0:391:241d:a13e with SMTP id ffacd0b85a97d-39ee5b9f5b6mr4191442f8f.48.1744874783782; Thu, 17 Apr 2025 00:26:23 -0700 (PDT) Received: from [192.168.88.253] (146-241-55-253.dyn.eolo.it. [146.241.55.253]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39eae96c03dsm18792656f8f.24.2025.04.17.00.26.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Apr 2025 00:26:23 -0700 (PDT) Message-ID: Date: Thu, 17 Apr 2025 09:26:22 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 4/4] selftests: drv-net: Test that NAPI ID is non-zero To: Joe Damato , netdev@vger.kernel.org Cc: kuba@kernel.org, Andrew Lunn , "David S. Miller" , Eric Dumazet , Shuah Khan , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , open list , "open list:KERNEL SELFTEST FRAMEWORK" , "open list:XDP (eXpress Data Path):Keyword:(?:b|_)xdp(?:b|_)" References: <20250417013301.39228-1-jdamato@fastly.com> <20250417013301.39228-5-jdamato@fastly.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20250417013301.39228-5-jdamato@fastly.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/17/25 3:32 AM, Joe Damato wrote: > diff --git a/tools/testing/selftests/drivers/net/napi_id.py b/tools/testing/selftests/drivers/net/napi_id.py > new file mode 100755 > index 000000000000..aee6f90be49b > --- /dev/null > +++ b/tools/testing/selftests/drivers/net/napi_id.py > @@ -0,0 +1,24 @@ > +#!/usr/bin/env python3 > +# SPDX-License-Identifier: GPL-2.0 > + > +from lib.py import ksft_run, ksft_exit > +from lib.py import ksft_eq, NetDrvEpEnv > +from lib.py import bkg, cmd, rand_port, NetNSEnter > + > +def test_napi_id(cfg) -> None: > + port = rand_port() > + listen_cmd = f'{cfg.test_dir / "napi_id_helper"} {cfg.addr_v['4']} {port}' Not really a full review, but this is apparently causing self-tests failures: # selftests: drivers/net: napi_id.py # File "/home/virtme/testing-17/tools/testing/selftests/drivers/net/./napi_id.py", line 10 # listen_cmd = f'{cfg.test_dir / "napi_id_helper"} {cfg.addr_v['4']} {port}' # ^ # SyntaxError: f-string: unmatched '[' not ok 1 selftests: drivers/net: napi_id.py # exit=1 the second "'" char is closing the python format string, truncating the cfg.addr_v['4'] expression. Please run the self test locally before the next submission, thanks! /P