From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E72E1346AC5 for ; Mon, 23 Feb 2026 05:51:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771825891; cv=none; b=QTt4MG/svyLJg4RO+vCN5bikhm/SEljLdcqtX9ZL9DQPWzAHnA7rE7tPH6T/ualEFfq17Cyjj2R9QbDp4y89gOODY1eCPq83pStvzvzoNKoo+SECllCBO4YMcmyba0Ais/eYJiUDiv8S+RxzILDQAZ2Ee8xqHcAWAksF1ZAIqw8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771825891; c=relaxed/simple; bh=5B2uH12fWkNLBwvhB4AC1A5SWMXFlRrD3cTFy4kbAC0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WeHMkrNYNL+/eqFGtGhbTfIea86SH1uRyUkVIVPMIbCIIIXPE6DU9pRSZgivp5yKoh4u14s5SbhqK79quVKQUMgsRNgF2hnIq0wTTWuNtE/pNLbDOwBz2TzhMaA8lwPvcfpnppFCDBPVbeL3ZXupviImQGr7jGUfUV/tom2wQA0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZgYinORc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AHQ39gVc; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZgYinORc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AHQ39gVc" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61MJvl9v2146284 for ; Mon, 23 Feb 2026 05:51:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YlXIqsOQwvU5Z8sYlXy96uUv0HGYahf5Uvea7D0cr+U=; b=ZgYinORcXQgSYDSG ezYaEM2QG0zIJB5sy0PpAchI9t6QfeFj5kcidIkM6mJp0RYUxto77ipt3cWDAsyU OVNk+W08QS0ij/wpoeCmSZ3XDkk/xwWgR9e4C4IVopnp5lZTzMZUdYkyxTCXecN9 Er0Mv9Lcs688dAbWC/cJnrPNh8iZqrFjMeBaRVCLzDJTjql0smmpuGG8Ek09KRw2 8CPJ4AEDQ3tldGn38Fsj/+8gjG/4ZfU32msry48u7bW+3yppDvoNtS4/0ndjn4Ai Boz8k3kp1LrUDFYdEJxgbxbYOTZa2aV7PjrJa3grRtTfcaQg6Ssude3j8HkZGTJQ QwbYsQ== Received: from mail-oi1-f200.google.com (mail-oi1-f200.google.com [209.85.167.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cf5wyuf5g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Feb 2026 05:51:28 +0000 (GMT) Received: by mail-oi1-f200.google.com with SMTP id 5614622812f47-45f2793a34dso39922967b6e.0 for ; Sun, 22 Feb 2026 21:51:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771825888; x=1772430688; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YlXIqsOQwvU5Z8sYlXy96uUv0HGYahf5Uvea7D0cr+U=; b=AHQ39gVcznvI3eImFCQpFLNbg6X2yP2Z/ouFFsunvwkzkJOkw91phizivC6zv7+Xvh 8bkwTjnDUA8cvYU1NERg0vnom0unOObL8HXhjE/GfxYrwuvOy8oqeUhGxP50qQgqKYxi N4uUfsiuMLo7+03eLrV0iBB9To6iKIUA4BEtsM0BuWq9t+1yVDq2utG5BNqduzDseq5X 7d3vn4ORDrIVBWwe0y8xO86KkHd0wA7/r9REr2uAVMXV59sfRTFccSGvV3/sEzzILwD0 kSHQg2GddcnVOQct1uEVoKW66kDHrKEnpQV6qQBf99lM/iBRSmv+Y3p4CTs0aodvZ+lT nXTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771825888; x=1772430688; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YlXIqsOQwvU5Z8sYlXy96uUv0HGYahf5Uvea7D0cr+U=; b=tToqqcbIFvmRpm0Dm1Eh5eYbdOQ6eFG+IJrlYKrnDkPQsqEYPqc5ADe8eqEIrCA2kA 2gGcKDg7bb3xAWz/dVxjSNyYiPHgD/eM6NLL2VoHOjq8aHSpdL8ZDW4Rklk0mtd8mEib 0MJV08rMjDjJ69nhfjnBaA7itPZTvDViNi6rhoTToJsNgJrQN6LJSq2MGEYCKb/TgVzH Gd+TISx2JOo1ag7ZUAXP0ROGwLxiKVPbYzsu8DZHM+J0LLeC/T4g9nlWW5U1CNOpkTsY W3mKbStK8ZlJfsm8PJvnSEQ3YOm5ohgN/OVO1UL/tHNKGjmZnLTWZNloZR5Ug4YIcUip R4Bg== X-Forwarded-Encrypted: i=1; AJvYcCU1zODa0m4az4AaL9BAjXa3sRzVcf/5r83k8VgHXcFA1IbiSqiOH//qx40q4A4gEkceJjTNHFHNIep5cCQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxsNB7qsZBasFIlU+n/Ps8Qjjfj6iIb/X20uxbZ1xyD5yECfq9t dEBzK6DjuRBikQIcYBGln3ZqAOje1VFZR/hdlntYSTEyPHzTMMz0xRUaRpcn1dCzntiyPCkrho+ q/QsgP69HmJwNXqb/TxEJ6QjrPSQJwydbZqWxNk99xdIVvXiaMO5NR7GSsdxH7CrakcM= X-Gm-Gg: AZuq6aJ+X4zp0b7wnSZK1k8EfGYy2jmGE5UdZF53iuZnvoHSx8bdLEXyjG+Ei5AE6rK mtJGVIC8EGdmUbDK6RDYsb5qsn7A3z9wN74bsUIPh9roulNjQS/FqDK024SLvfctlayFbv/kc4o CBZVMEU9HL7yJ5OoV7a1w59xoOhe9oxYVY1hHnL9rFZBvErcJv2oQ3RO6uhsYfw9ZYKyoswAbPP IWm6zFEKbp7J7hXYidKnJjZr3xsodXj1oF1xIfCoGc2Vx6aj1ZA0wKmKYs693cb3DSobW/278VJ I7dzxgpmTQzZohEEJ/EWjxdwhIu5sE16tCleTVhpvNikkw28oGJJVeYQZzsmLueaL5T9DTywxyZ 8Gq9VeDPJ7pnkNYSMGUVwRIZC8GqyEZIMXQADwmpRSHoJrAA4T0wVP2aCQZdpqJykrWRpAvWu X-Received: by 2002:a05:6808:c281:b0:459:9630:3742 with SMTP id 5614622812f47-464461b5eaamr4040522b6e.22.1771825888228; Sun, 22 Feb 2026 21:51:28 -0800 (PST) X-Received: by 2002:a05:6808:c281:b0:459:9630:3742 with SMTP id 5614622812f47-464461b5eaamr4040514b6e.22.1771825887902; Sun, 22 Feb 2026 21:51:27 -0800 (PST) Received: from [10.110.58.37] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 5614622812f47-46460661eeesm1987552b6e.13.2026.02.22.21.51.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Feb 2026 21:51:27 -0800 (PST) Message-ID: Date: Mon, 23 Feb 2026 13:51:22 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9] arm64: dts: qcom: qcs8300-ride: enable WLAN on qcs8300-ride To: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260122053624.4068718-1-wei.zhang@oss.qualcomm.com> <46d0bc58-2c85-4293-a8ee-480282b80161@oss.qualcomm.com> Content-Language: en-US From: "Wei Zhang (Stone)" In-Reply-To: <46d0bc58-2c85-4293-a8ee-480282b80161@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIzMDA0OSBTYWx0ZWRfXzLtXRNdz7vr6 zxWTUVWvUqFG3BmJKS5p4LWIT1mbPtlh+PkEojOEOpjPGc46dXQTG4OPb8ONVuEd0T8ksDQ856m BIE0U6ZsrNa8JafXEyFmcy+YAbPffAFcwu29P7UAZEAzL8TRT2w8gm/luRgO7ycuPlDidElqVLN kdR+08DayVFyFgmRhrnxSZp9LJT9MvAw2xS0Chhe7LgFLREZ0+Oq84O8QP7bu7zx+McvakJhNl1 iD0Rje5oey0XBKeylBbq+d9VyQl6+Hwhoah2y3h2lfTa86u1yfa2vnxJcOnhF4dCD+6MoFe22Ef jxsZ7331ic5iBenovC7akqeYuKcJySQTZzRkPQqXQQu9zKucniu1MjvI3CUYmAMWJN9jU12JVpd /GyTYlGhulvMe/1l4cvnrvXPtJ3ddut5E0eAGe5RW0JrxQZFSS0VtMHwuMCZ15fXGe8JCmVE7RY gx6s9Pf+Ly3ZUv+qv1Q== X-Authority-Analysis: v=2.4 cv=UO/Q3Sfy c=1 sm=1 tr=0 ts=699beae1 cx=c_pps a=AKZTfHrQPB8q3CcvmcIuDA==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=JAj8-Fn0YFEjOL2seJ8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=pF_qn-MSjDawc0seGVz6:22 X-Proofpoint-GUID: 0DN-vwaNearz9WEcALItXu2QRYDiandS X-Proofpoint-ORIG-GUID: 0DN-vwaNearz9WEcALItXu2QRYDiandS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-23_01,2026-02-20_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 phishscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602230049 On 2/5/2026 5:28 PM, Konrad Dybcio wrote: > On 1/22/26 6:36 AM, Wei Zhang wrote: >> Enable WLAN on qcs8300-ride by adding a node for the PMU module >> of the WCN6855 and assigning its LDO power outputs to the existing >> WiFi module. >> >> On the qcs8300-ride platform, the corresponding firmware and BDF >> are QCA6698AQ instead of WCN6855, which have been added in the >> 20250211 release. >> >> Signed-off-by: Wei Zhang >> --- > [...] > >> + wlan_en_state: wlan-en-state { >> + pins = "gpio54"; >> + function = "gpio"; >> + bias-pull-up; >> + }; > pull-up sounds odd for an active-high pin Good point. GPIO54 is the active‑high WLAN_EN for WCN6855. The pull‑up is intentional to keep the line stable during early boot and to reduce the risk of a low‑to‑high glitch before the PMU driver takes control. WLAN enable/disable is still explicitly handled by the wcn6855‑pmu driver via wlan-enable-gpios. I can switch this if a different default is preferred. > > Konrad