From: Andrew Donnellan <ajd@linux.ibm.com>
To: Yury Norov <yury.norov@gmail.com>,
"Jiri Slaby (SUSE)" <jirislaby@kernel.org>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Thomas Gleixner <tglx@linutronix.de>,
Frederic Barrat <fbarrat@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] powerpc: pci-ioda: use bitmap_alloc() in pnv_ioda_pick_m64_pe()
Date: Tue, 12 Aug 2025 11:07:08 +1000 [thread overview]
Message-ID: <b1fe7008d2f230dd89be6d2541b7cf07ed2514e3.camel@linux.ibm.com> (raw)
In-Reply-To: <20250811165130.37552-2-yury.norov@gmail.com>
On Mon, 2025-08-11 at 12:51 -0400, Yury Norov wrote:
> - /* Allocate bitmap */
> - size = ALIGN(phb->ioda.total_pe_num / 8, sizeof(unsigned long));
> - pe_alloc = kzalloc(size, GFP_KERNEL);
> + pe_alloc = bitmap_alloc(phb->ioda.total_pe_num, GFP_KERNEL);
I haven't checked whether or not this has practical impact given what we later
do with the bitmap - does this need to be bitmap_zalloc() to match the existing
use of kzalloc()?
--
Andrew Donnellan OzLabs, ADL Canberra
ajd@linux.ibm.com IBM Australia Limited
next prev parent reply other threads:[~2025-08-12 1:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 16:51 [PATCH v2 0/2] powerpc: pci-ioda: Rework pnv_ioda_pick_m64_pe() Yury Norov
2025-08-11 16:51 ` [PATCH v2 1/2] powerpc: pci-ioda: use bitmap_alloc() in pnv_ioda_pick_m64_pe() Yury Norov
2025-08-12 1:07 ` Andrew Donnellan [this message]
2025-08-14 0:43 ` Yury Norov
2025-08-11 16:51 ` [PATCH v2 2/2] powerpc: pci-ioda: Optimize pnv_ioda_pick_m64_pe() Yury Norov
2025-08-12 3:45 ` Andrew Donnellan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1fe7008d2f230dd89be6d2541b7cf07ed2514e3.camel@linux.ibm.com \
--to=ajd@linux.ibm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=fbarrat@linux.ibm.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=tglx@linutronix.de \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®