From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E7A4333725 for ; Mon, 2 Mar 2026 10:39:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772447969; cv=none; b=aG530gYgFi1kV9kSEFr78k/uJ8sjtp7Kk52+QbVXEUeVVaom3mUYqAspKkcgxf4DAii5ylpKKmNOROik+Lt9NmBPwkdFRrOJqSKUDFPqgdJv+o/4LZByJ6cIySTKTCjGUrLmFwSv5cGxGdqMYNfrbH1O83p4oL0tRjyUZL+UR3Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772447969; c=relaxed/simple; bh=IXVKly4vZrqTzYsukfCbusZZsbWwT/ncueUw5X7V6KQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JX5GANaPcC4W0evML75tRiMQc31Xfs0AXuOQ3ZZFVLAn9LepQgIolzyZlJH6mj3GWqIWiEqrkih//Ngd4TuShq8WMgbP4CNeF9ipKu94dT7/SNnY0Q2rNeosmUj00GlAF0LgSZWDg5TtXhpvf2lcURYyzswkqwdHrYj56MTnSkc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ingeniumdigital.com; spf=pass smtp.mailfrom=ingeniumdigital.com; dkim=pass (2048-bit key) header.d=ingeniumdigital.com header.i=@ingeniumdigital.com header.b=WRB82fBn; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ingeniumdigital.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ingeniumdigital.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ingeniumdigital.com header.i=@ingeniumdigital.com header.b="WRB82fBn" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2ae43042ea7so16405215ad.0 for ; Mon, 02 Mar 2026 02:39:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ingeniumdigital.com; s=google; t=1772447967; x=1773052767; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OhNp0kZiQhroSex4KBqfau9jIzn8Q9YBLyXvEf6AG2I=; b=WRB82fBn6Mt0KWT3LyX/aTua8f6u6bigfEF3NFsndNoAGHLjlF2DZBGABE5rEZkkCo E/0okwxAhKddlNScGiT9lzCnwWW1bFe4A8t/JcR3SZT+32NYcRLyH99b21NXiTIC1OuR qgWgjZ0Xmi428yuiBwE2l+6C8Klze8pruEtcVqVazzMbgfC9jzBszRBT2s8UMtDF1QML rzvGthu/RpGE4QHcIjl8sSItIczJD2CFCQnwUIeOpnyMH0hSRVae0LFGEgy+hEZbk+ZM e/xsjx1YhRX/GPJOT+S/OT0bcRY7ih/TigTBsllxGDXgJz7wWClFD0wll6w1+I+8VbP2 zAgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772447967; x=1773052767; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OhNp0kZiQhroSex4KBqfau9jIzn8Q9YBLyXvEf6AG2I=; b=nI0ZWjmO0I+2yqmmbnSqAF9iDK3fdTrn0FnloSS87YHOBozkAXRUvGoBUOO8Sdv3XH dVzIIf/WPOtiTCu/eqHMD8lCxy7S6LjI7kp6eMkFl9zN0Df6EagaT64DlBieTEYpnY2w 8iVt1+yFXxMLkH333gXDMMkCsm65Qrdb5aNaWJjYbzcNqHajABOQdWI+ON5ykzdchchX vAv9b9eEQcXjl90zIc4+rbwsVJnIIInvpO2YN5g2e1UM5/GeSf+M2iWPJFF7WXN57UMv pHjXedl15XRvUpsEQUDQzrxrWWZBmSeSbkHUiqGKPKPjyNaeD616xFOiQh8BS1C7Z8Uu QqZA== X-Forwarded-Encrypted: i=1; AJvYcCXqO9ADo7UX34yuXA19l+hxjYb74jnM1tJa+N04sjtZIAiBVO90SWg8bABLYVJttqwu37CBO4J8+KJdzYU=@vger.kernel.org X-Gm-Message-State: AOJu0YwaN6vzotXjWvInH9YP68Pqv4Ily+EuooN1mRQ4ftTFi+RG8H1Z 6UUNxEhUv1i7w0yzScjdyhiDqV3GOTCZrMX83XIJBBl7FS9czVvkXccm4e7bjVktgw== X-Gm-Gg: ATEYQzxg32BbUxEy1lG4jpj00fPrUqM6JygSeAQLNlkPrsIMf2ig+Bne0XMQ8H9nP7D N628EERI8Q/5ociTlyA29wsmkn5uf595XIIP5kGsUKPhFx5ZBCu8ImL5DuMiD2yJzhpe6wb45XK n/dgT/GS9Z9zHG9MtLLCuIB/3MP1Ml5HgIKOb+i8XCVCW9cHl113TeuKl5pCAvfRESVREBsyqv+ YGOpUU2bCB4stguyUI4l2IVswXYNdzcl5gXj6MVgMm7k+9Gv6yGiL23ZB0gh4im/F/TJRvOXW/L fKijY5FHhoqp5j0I+LviLfw3pARSSiW4JPDQ2U0croJmBwhU2LyISAzmeftajEPvhQzGhl4IF18 h2sMGgZNniCaY+S0zT99gy7RyamFy07Maf/ItPOJ+8mR8Tuzgex4DS9YnMn7GOj6G1zSpI3/+w0 dBu1g2L/0bnFUAvPuY2JML7o/0UmIXjjdQbkyOqV3gg80t5LW3v0YZF4jwC1bBnweSD4E7eYNEL gkbjNuHng== X-Received: by 2002:a17:902:d48d:b0:2aa:d802:a010 with SMTP id d9443c01a7336-2ae2e3e71fdmr110572055ad.10.1772447967486; Mon, 02 Mar 2026 02:39:27 -0800 (PST) Received: from ?IPV6:2001:8003:8824:9e00:6d16:7ef9:c827:387c? ([2001:8003:8824:9e00:6d16:7ef9:c827:387c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb6fe4f3sm130805925ad.91.2026.03.02.02.39.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Mar 2026 02:39:26 -0800 (PST) Message-ID: Date: Mon, 2 Mar 2026 18:39:22 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] kunit: tool: skip stty when stdin is not a tty To: Shuvam Pandey , brendan.higgins@linux.dev, davidgow@google.com Cc: raemoar63@gmail.com, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org References: <20260227123136.91086-1-shuvampandey1@gmail.com> Content-Language: fr From: David Gow X-Clacks-Overhead: GNU Terry Pratchett In-Reply-To: <20260227123136.91086-1-shuvampandey1@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 27/02/2026 à 8:31 PM, Shuvam Pandey a écrit : > run_kernel() cleanup and signal_handler() invoke stty unconditionally. > When stdin is not a tty (for example in CI or unit tests), this writes > noise to stderr. > > Call stty only when stdin is a tty. > > Add regression tests for these paths: > - run_kernel() with non-tty stdin > - signal_handler() with non-tty stdin > - signal_handler() with tty stdin > > Signed-off-by: Shuvam Pandey > --- Reviewed-by: David Gow Cheers, -- David