From: netdev@kapio-technology.com
To: Vladimir Oltean <olteanv@gmail.com>
Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 net-next 2/2] net: dsa: mv88e6xxx: mac-auth/MAB implementation
Date: Sun, 20 Nov 2022 10:33:57 +0100 [thread overview]
Message-ID: <b2067339924d0ed7dec25ab51b43a17c@kapio-technology.com> (raw)
In-Reply-To: <20221115222312.lix6xpvddjbsmoac@skbuf>
On 2022-11-15 23:23, Vladimir Oltean wrote:
>
> How much (and what) do you plan to add to switchdev.{c,h} in the
> future?
> It's a bit arbitrary to put only mv88e6xxx_handle_violation() in a file
> called switchdev.c.
>
> port_fdb_add(), port_mdb_add(), port_vlan_add(), port_vlan_filtering(),
> etc etc, are all switchdev things. Anyway.
>
Firstly, those functions you list are ops functions, while what is in
switchdev.{c,h} is not, secondly the functions in switchdev.{c,h} are
the
first to send switchdev messages like SWITCHDEV_FDB_ADD_TO_BRIDGE
events.
Furthermore I think that chip.c is bloated, but I also do plan to add
more
to switchdev.{c,h}, and there can be others adding in the future...
next prev parent reply other threads:[~2022-11-20 9:34 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-12 20:37 [PATCH v8 net-next 0/2] mv88e6xxx: Add MAB offload support Hans J. Schultz
2022-11-12 20:37 ` [PATCH v8 net-next 1/2] net: dsa: mv88e6xxx: allow reading FID when handling ATU violations Hans J. Schultz
2022-11-12 20:37 ` [PATCH v8 net-next 2/2] net: dsa: mv88e6xxx: mac-auth/MAB implementation Hans J. Schultz
2022-11-15 9:58 ` Ido Schimmel
2022-11-15 10:36 ` netdev
2022-11-15 15:12 ` Ido Schimmel
2022-11-15 15:24 ` netdev
2022-11-15 22:23 ` Vladimir Oltean
2022-11-20 9:33 ` netdev [this message]
2022-11-20 9:54 ` netdev
2022-11-20 10:21 ` netdev
2022-11-20 15:00 ` Vladimir Oltean
2022-12-02 11:06 ` netdev
2022-12-04 15:08 ` netdev
2022-12-04 13:26 ` netdev
2022-11-15 9:30 ` [PATCH v8 net-next 0/2] mv88e6xxx: Add MAB offload support Ido Schimmel
2022-11-15 10:26 ` netdev
2022-11-15 10:28 ` Vladimir Oltean
2022-11-15 10:52 ` netdev
2022-11-15 11:10 ` Vladimir Oltean
2022-11-15 11:31 ` netdev
2022-11-15 12:22 ` Vladimir Oltean
2022-11-15 12:40 ` netdev
2022-11-15 13:25 ` netdev
2022-11-15 14:56 ` Vladimir Oltean
2022-11-15 15:14 ` netdev
2022-11-15 16:15 ` Vladimir Oltean
2022-11-15 17:11 ` netdev
2022-11-15 17:15 ` Vladimir Oltean
2022-11-15 16:03 ` netdev
2022-11-15 16:18 ` Vladimir Oltean
2022-11-15 18:40 ` netdev
2022-11-16 10:24 ` Vladimir Oltean
2022-11-16 13:37 ` Andrew Lunn
2022-11-18 13:37 ` netdev
2022-11-18 13:51 ` Andrew Lunn
2022-11-15 13:21 ` Andrew Lunn
2022-11-15 14:18 ` netdev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2067339924d0ed7dec25ab51b43a17c@kapio-technology.com \
--to=netdev@kapio-technology.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®