From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751739AbdFELHd (ORCPT ); Mon, 5 Jun 2017 07:07:33 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:6866 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751630AbdFELHc (ORCPT ); Mon, 5 Jun 2017 07:07:32 -0400 Subject: Re: [PATCH 4/4] f2fs: use bio_set_op_attrs To: Christoph Hellwig References: <20170605102909.57625-1-yuchao0@huawei.com> <20170605102909.57625-4-yuchao0@huawei.com> <20170605103947.GA21376@infradead.org> CC: , , , From: Chao Yu Message-ID: Date: Mon, 5 Jun 2017 19:05:42 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20170605103947.GA21376@infradead.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020201.59353B12.0039,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: df063576837dac48f18116b78176bc73 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/6/5 18:39, Christoph Hellwig wrote: > On Mon, Jun 05, 2017 at 06:29:09PM +0800, Chao Yu wrote: >> Init bio->bi_opf with bio_set_op_attrs instead of opened code. >> >> Signed-off-by: Chao Yu >> --- >> fs/f2fs/data.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c >> index 2ed90f5db832..204150cf6561 100644 >> --- a/fs/f2fs/data.c >> +++ b/fs/f2fs/data.c >> @@ -1962,7 +1962,7 @@ static int f2fs_write_begin(struct file *file, struct address_space *mapping, >> err = PTR_ERR(bio); >> goto fail; >> } >> - bio->bi_opf = REQ_OP_READ; >> + bio_set_op_attrs(bio, REQ_OP_READ, 0); > > NAK. Please read the comment next to bio_set_op_attrs. Oh, bio_set_op_attrs is obsolete. :( Alright, let's ignore this patch. Thanks, > > . >