mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Thomas Weißschuh" <linux@weissschuh.net>
To: Zhouyi Zhou <zhouzhouyi@gmail.com>
Cc: w@1wt.eu, rcu@vger.kernel.org, linux-kernel@vger.kernel.org,
	 lance@osuosl.org
Subject: Re: [PATCH v2] tools/nolibc: make time_t robust if __kernel_old_time_t is missing in host headers
Date: Sat, 20 Sep 2025 11:07:43 +0200	[thread overview]
Message-ID: <b20a1126-9d59-4d8b-a85c-71ec532c2f8f@t-8ch.de> (raw)
In-Reply-To: <20250919014643.2776037-1-zhouzhouyi@gmail.com>

On 2025-09-19 01:46:43+0000, Zhouyi Zhou wrote:
> Commit d5094bcb5bfd ("tools/nolibc: define time_t in terms of
> __kernel_old_time_t") made nolibc use the kernel's time type so that
> `time_t` matches `timespec::tv_sec` on all ABIs (notably x32).
> 
> But since __kernel_old_time_t
> is fairly new, notably from 2020 in commit 94c467ddb273 ("y2038: add
> __kernel_old_timespec and __kernel_old_time_t"), nolibc builds that
> rely on host headers may fail.
> 
> Switch to __kernel_time_t, which is the same as
> __kernel_old_time_t and has existed for longer.    
> 
> Tested in PPC VM of Open Source Lab of Oregon State University
> (./tools/testing/selftests/rcutorture/bin/mkinitrd.sh)
> 
> Fixes: d5094bcb5bfd ("tools/nolibc: define time_t in terms of __kernel_old_time_t")
> Signed-off-by: Zhouyi Zhou <zhouzhouyi@gmail.com>                     

Thanks! Although it is fairly late in the developmment cycle I have
applied it to nolibc-next for 6.18.

(...)

      reply	other threads:[~2025-09-20  9:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-19  1:46 Zhouyi Zhou
2025-09-20  9:07 ` Thomas Weißschuh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b20a1126-9d59-4d8b-a85c-71ec532c2f8f@t-8ch.de \
    --to=linux@weissschuh.net \
    --cc=lance@osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rcu@vger.kernel.org \
    --cc=w@1wt.eu \
    --cc=zhouzhouyi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®