From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965490AbcIVRIx (ORCPT ); Thu, 22 Sep 2016 13:08:53 -0400 Received: from mail-lf0-f49.google.com ([209.85.215.49]:35885 "EHLO mail-lf0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965449AbcIVRIv (ORCPT ); Thu, 22 Sep 2016 13:08:51 -0400 Subject: Re: [PATCH net-next v2 0/3] add support for RGMII on GMAC0 through TRGMII hardware module To: David Miller , sean.wang@mediatek.com References: <1474511636-11644-1-git-send-email-sean.wang@mediatek.com> <20160922.082247.198689057396545219.davem@davemloft.net> Cc: john@phrozen.org, nbd@openwrt.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, andrew@lunn.ch, f.fainelli@gmail.com, keyhaede@gmail.com, objelf@gmail.com From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: Date: Thu, 22 Sep 2016 20:08:47 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160922.082247.198689057396545219.davem@davemloft.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 09/22/2016 03:22 PM, David Miller wrote: >> By default, GMAC0 is connected to built-in switch called >> MT7530 through the proprietary interface called Turbo RGMII >> (TRGMII). TRGMII also supports well for RGMII as generic external >> PHY uses but requires some slight changes to the setup of TRGMII >> and doesn't have well support on current driver. >> >> So this patchset >> 1) provides the slight changes of the setup for RGMII can work >> through TRGMII >> 2) adds additional setting "trgmii" as PHY_INTERFACE_MODE_TRGMII >> about phy-mode on device tree to make GMAC0 distinguish which >> mode it runs >> 3) changes dynamically source clock, TX/RX delay and interface >> mode on TRGMII for adapting various link >> >> Changes since v1: >> - fixed the style of comment which doesn't have a space at >> the beginning and end of comment lines >> - add support for phy-mode "trgmii" as PHY_INTERFACE_MODE_TRGMII >> into linux/phy.h >> - enhance the Documentation about device tree binding for trgmii >> which is applicable only for GMAC0 which uses fixed-link > > Series applied. Despite my comments? Sigh... MBR, Sergei