From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E110443E5D for ; Tue, 11 Aug 2026 12:21:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786450883; cv=none; b=W6ko1KbNyqTizehWBPr8xRigEeK0oRiiDLGXdUGIP+7Ir7YTOCH9AK9aa1DqV8P3EGncL7jDQQFv7K40t7XhjmKPgNsbDTMl+5xGD43U4FXRne7qfA+7Lhgy0Jxgp3BgaBnaqnMIl4UryRDqlx3AvOlQUjYjwPUbU6cXaw1V03U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786450883; c=relaxed/simple; bh=bZhfQ75/tBx76bRwf/yqfxbrZJKpDXW17ur7HV4Joh0=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=UG5aqAPmkgKMgN+wJINBwmVNKjaFWHWehf2HVQ8VKyKpxcloX911WvBnBsjCfI9nzeJC7U43drRGI21jSkSWOwzGviR393Y/v9upOfS/ErjZGBgTrDS57HkVcsLDMG77LDKz2VK1gmwd+dBqvCdFyLngTQgYYVoxIhtIsQcMJug= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=cF2JUTnk; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cF2JUTnk" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786450881; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eWX499O3iR5H1HkaG3ftvTfcj6oM13J2855Qi6h6PhE=; b=cF2JUTnkUFjXYdIved23ZtCQcYSeVBa3rYhZ8PHJxeecY5zW4Q+nnwMbgVne2rClx1Pm3Y LhEUAcThugLQP2xDM3vYk3X+xB3Z0hePru6Rc9tmFx3y/CNaKbF9+zBbId8LkmzEQzF7H1 IT0FZclvu8Wn6UYozfzM7ceZa+C9XFg= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-306-SKRFYKPRMfm9AfZj5zxrqw-1; Tue, 11 Aug 2026 08:20:04 -0400 X-MC-Unique: SKRFYKPRMfm9AfZj5zxrqw-1 X-Mimecast-MFC-AGG-ID: SKRFYKPRMfm9AfZj5zxrqw_1786450803 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C26751956052; Tue, 11 Aug 2026 12:20:02 +0000 (UTC) Received: from [10.43.2.199] (unknown [10.43.2.199]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 57C50180049F; Tue, 11 Aug 2026 12:19:59 +0000 (UTC) Message-ID: Date: Tue, 11 Aug 2026 14:19:58 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v6 1/3] dpll: zl3073x: scale poll interval proportionally to timeout From: Ivan Vecera To: netdev@vger.kernel.org Cc: Arkadiusz Kubalewski , Jakub Kicinski , Jiri Pirko , Min Li , Paolo Abeni , Petr Oros , Richard Cochran , Vadim Fedorenko , linux-kernel@vger.kernel.org, Jonathan Corbet , Shuah Khan , linux-doc@vger.kernel.org References: <20260809182340.1081610-1-ivecera@redhat.com> <20260809182340.1081610-2-ivecera@redhat.com> Content-Language: en-US In-Reply-To: <20260809182340.1081610-2-ivecera@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Sashiko findings with comments: > Since zl3073x_poll_zero_u8() is the single shared polling helper, does this > also change the poll granularity for all the pre-existing callers [...] > sleep_us becomes 500 us, 1000 us, 1000 us, 600 us and 1000 us respectively Yes, the change affects all callers. Testing showed that the existing callers typically completed in low hundreds of sleep cycles with the fixed 10 us interval. With the scaled interval, the cycle count dropped to single digits — a much better fit for the actual hardware response times. > Does the flash path also get slower? [...] > over the tens of thousands of words in a firmware or utility image > could add a noticeable amount of time to a devlink flash. No. Firmware flash operations were tested with no observable regression. The overall flash time remained the same because the reduced number of sleep cycles compensates for the longer individual sleep intervals. > Would clamping the derived interval [...] reach the stated goal [...] > without changing the existing 25-50 ms call sites? Given the test results above, clamping is not necessary. > Reading this, one would conclude the existing 25-50 ms call sites keep their > old behaviour [...] Could the changelog mention the effect on the existing > [...] polls? Fair point. Will update the changelog to mention that all callers are affected. > Is "approximately 50 iterations" accurate? Will reword to avoid the specific iteration count claim. Thanks, Ivan