mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Avri Altman <Avri.Altman@wdc.com>, Bean Huo <huobean@gmail.com>,
	"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Bean Huo <beanhuo@micron.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 4/4] scsi: ufs: Re-use compose_devman_upiu
Date: Fri, 8 Mar 2024 14:32:11 -0800	[thread overview]
Message-ID: <b21751d5-21e2-45c8-88a2-b148ac335637@acm.org> (raw)
In-Reply-To: <DM6PR04MB6575AC3761F84B308EB0633DFC202@DM6PR04MB6575.namprd04.prod.outlook.com>

On 3/7/24 11:26, Avri Altman wrote:
> On Tue, 2024-03-05 at 23:00 +0200, Avri Altman wrote:
>> Why not directly pass UTP_CMD_TYPE_SCSI or UTP_CMD_TYPE_DEV_MANAGE
>> instead of using below ?: logic?
>
> Thanks.  Will do that.

While making that change, please keep the version check inside
ufshcd_prepare_req_desc_hdr().

Thanks,

Bart.


      reply	other threads:[~2024-03-08 22:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-05 21:00 [PATCH v2 0/4] Re-use device management code fragments Avri Altman
2024-03-05 21:00 ` [PATCH v2 1/4] scsi: ufs: Re-use device management locking code Avri Altman
2024-03-06 21:21   ` Bean Huo
2024-03-05 21:00 ` [PATCH v2 2/4] scsi: ufs: Re-use exec_dev_cmd Avri Altman
2024-03-06 22:05   ` Bean Huo
2024-03-07 19:28     ` Avri Altman
2024-03-08 19:29       ` Bean Huo
2024-03-08 19:42         ` Avri Altman
2024-03-05 21:00 ` [PATCH v2 3/4] scsi: ufs: Re-use compose_dev_cmd Avri Altman
2024-03-07 12:50   ` Bean Huo
2024-03-07 18:12   ` Bart Van Assche
2024-03-05 21:00 ` [PATCH v2 4/4] scsi: ufs: Re-use compose_devman_upiu Avri Altman
2024-03-07 13:06   ` Bean Huo
2024-03-07 19:26     ` Avri Altman
2024-03-08 22:32       ` Bart Van Assche [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b21751d5-21e2-45c8-88a2-b148ac335637@acm.org \
    --to=bvanassche@acm.org \
    --cc=Avri.Altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=huobean@gmail.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®