From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECFC630DD2C for ; Mon, 9 Feb 2026 05:43:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770615795; cv=none; b=sFJfIa4KyEdWeFBD0OWSwfwIkSrIqVGp6SyOzQax/soK2RGsXWW+nhLkF+t7HpAii0IQKukrMkyf3frR3FHJHhtfYP7IYXhhblzvziHgKlEJ2DBOudamhIF1mkB9JkCpmv8Fs+WIIRKBvbFLZozfGHx/ZVQ80cVO3PiV6qjJF/Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770615795; c=relaxed/simple; bh=BgQyBP2POhvf7dfpLjckZBvIentNI3ZdpYWQIxuUchw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=c4gKOrl5N3NODKhXOBEEz+BfRuUYeQ4yfCLMuUKxn+4ZnIDpuaxmhGm2ijMdzQP+nnNIKxQKHt0yCMiPUUzUSTbEirTBhb+p+exgHRuMXSXJp/gUofaj73lOTcRYbNwzQDC+857xY9UTEAJQrfkG3JzkK/kfkRM5FWG3IwNWeYo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Yy6Yv2m0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cayzPD4N; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Yy6Yv2m0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cayzPD4N" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 618NAMDl1742892 for ; Mon, 9 Feb 2026 05:43:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= KaS2bDCERxGhUQ++FUxZO6KStC/Aihej3Lb7UvRApxA=; b=Yy6Yv2m03ywgi23l BlxcDT3W0OVd5hlS6HKORTcgJx/MmfPcjWefRPIBRYCG4GNpBk/o9UJEftf4HUYQ dPsXKB5CKyRxuF5VMEO2lxsp4ofDAybB+FinuH4zLsC0hNAduavCxzBqKKvojUNK w3MPmi49TPgVZBes70I22sEgLMRNDUZBRVFh65NxhX3WdlWua9ILOPpfMrcOfPtb i/w8/lvJ6Us9gbPeUnbpG5JfD8fq65FUnd3Nsdxj7KWmXC1zEr+tD2/qJGVr0ixS MP3PeszMGAeaqMfAdFOybKxkRWV5qiJ+KLpIOD6dhp6/oRBe/O70wgGfYcHtcjXd rfb2sQ== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c5xhrbrj1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 09 Feb 2026 05:43:14 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-354490889b6so7547114a91.3 for ; Sun, 08 Feb 2026 21:43:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770615793; x=1771220593; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KaS2bDCERxGhUQ++FUxZO6KStC/Aihej3Lb7UvRApxA=; b=cayzPD4NYIyGb9Q7+x1tzL+vE5Qzix8lv7vikXsYgFWftcCBo4vPjg8JORX6KkTTZn XQ09JYGpQp6hVM8zNa5WVUIEq6Fp8niCGVCHlDyJiRmHO0AOqT22wxbNfUgNc2qLWId1 CHxZllMDiv31FjddUvNpILYKKdaibIENrfD2YPXp9q/RSJHstDovXtmO59v/youxrmzb kB6wlr9CVLSsvkiNlqhS6Bsx8aCCMEu/rJM1HGjMUAPNK8XME4Ar+7Rc1cUpcM5X+Am7 jc90WiQgjWM+s9lxLojIA+1PXNIqeFS618LmfqwiWsWZQq+8fXOfa4Kl680VjMykz+ux NawA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770615793; x=1771220593; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KaS2bDCERxGhUQ++FUxZO6KStC/Aihej3Lb7UvRApxA=; b=hcUnwRAfLneBG9IpCc7eXCaAhCiSYqyFvvuCq6uOU+StJUTyIpfCqHKU24ZCOGQs02 011e5iF7rpDwQyuj4tLLPS6K1+RNzuESy3sKflmUaQA2BiybVK/zjZKwT5G+Dq7gPOqZ Qz/Je1Ay81xWx8KQZa17zLC0X6eonSVJyUAv0eQDPsqeKEQz5Duv+l/W/pW8rvDaLrvM m/v20nG9hfdy7SPJ6r8hP89CQPKWxmB97UFi2i1/Ew49RW82G/cSCBuaCZtoYTOJSaVM +3ott6RoT9Acojc6nWE0xuEIGJI22pHDwaDFqcHldVdMRyvz6o0Lx1ranpGa+OvE2pWL C0SQ== X-Forwarded-Encrypted: i=1; AJvYcCWARnyt/2oerTkWzIoIjiSQK/PAKfVpxVJMXG3Z4tVw1cGjGzTVqQis2L4QCBMx/vj+K2gYCfem9XmdPZI=@vger.kernel.org X-Gm-Message-State: AOJu0Yzj7GaGN97t9Io39F45XtT25H6jXzOmSPRCPo3SLYBQ2iF5tp1K GCpJcoWOdD1IWU7QACLB6izs7wgjeRoHXQVah+faEY9tFmq1fuH76fbDXc2Zx3ZJJdmi2z+8TG+ 3nKVZNj74RApLN2UdFFBGSsIOCvCAmV3ahYAjJsz6GNCgEaUIAgGfToDNd5RQgXK20B8= X-Gm-Gg: AZuq6aLcfl39BMnvvyiyvSu6RtEu7mFr/rGwyl5z+xznDApyoLq5bvfdR7IlDJCiULF xwW8YLFruaJzimeQWozpO0sHpKGzQhn+G3EUKiIMH9Y7DOdSfT2MUXGn5kXp8Qt0aVDqjZmH8zG dY/0ZKwH12Jm/UvKp/dl7oI7Lmw8GQcNMm6ANyjM7ssK8WdmX9MLEzuFQbEGfjFY+xq6AoWkx/9 lvxwCDPSdHGgwTm1TyutSHBJRbuIqfeo10CPPemK7afyrqCv1RQ9Qj+WjtPBR9khtXyzOMd/jNg i+ScPhtomgmxUqSsouByYTpqinMQX1NNnzhtk1waJV+m0nEqSdexwf2VuQr38LWXOjNW/cyL25L 1Cti2b0/9PqVlYTR/NqET9xt5aZIMrQ0cjUofVGY= X-Received: by 2002:a17:90b:2f10:b0:353:e91:9b38 with SMTP id 98e67ed59e1d1-354b3cf5762mr8768905a91.34.1770615793397; Sun, 08 Feb 2026 21:43:13 -0800 (PST) X-Received: by 2002:a17:90b:2f10:b0:353:e91:9b38 with SMTP id 98e67ed59e1d1-354b3cf5762mr8768882a91.34.1770615792855; Sun, 08 Feb 2026 21:43:12 -0800 (PST) Received: from [10.217.223.121] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c6dcb5e406asm11797632a12.22.2026.02.08.21.43.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 Feb 2026 21:43:12 -0800 (PST) Message-ID: Date: Mon, 9 Feb 2026 11:13:06 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/11] dt-bindings: crypto: qcom,ice: Require power-domain and iface clk To: Krzysztof Kozlowski , Konrad Dybcio , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , cros-qcom-dts-watchers@chromium.org Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260123-qcom_ice_power_and_clk_vote-v1-0-e9059776f85c@qti.qualcomm.com> <20260123-qcom_ice_power_and_clk_vote-v1-1-e9059776f85c@qti.qualcomm.com> <14a71b33-4c10-41b0-a6cb-585a38e05f56@kernel.org> <06160c6c-a945-467a-be82-7b33c5285d0f@oss.qualcomm.com> <7216c86d-2b87-496c-9548-ccdcb3c98b6b@oss.qualcomm.com> <1f99db18-d76c-4b87-9e30-423eee7037e1@oss.qualcomm.com> <2830a189-a5ce-45a0-92fe-7a01c3b012a7@oss.qualcomm.com> <6efcdf51-bdb1-4dfc-aa5e-8b7dc8c68cd3@kernel.org> Content-Language: en-US From: Harshal Dev In-Reply-To: <6efcdf51-bdb1-4dfc-aa5e-8b7dc8c68cd3@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: AHV8HkE445plKP1XCY9mcSHVaGyZ0cYF X-Authority-Analysis: v=2.4 cv=AJ+v8NAg c=1 sm=1 tr=0 ts=698973f2 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=jJ6LFyVhKJnmHHG_DRUA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA5MDA0NSBTYWx0ZWRfX8IRbIlJpbuos 37XtDtI/zzwFipVgf1WixQ6RVzhp1hzOuqyP/xZeR1y1pTui1xFojc+wgyrkR9ndK00Pf9Y59a+ Ol4mtJyKn4VtThA1CdvzjGs4WYkX0d3pWK9zYk6obkydclDqkf67nPk8guUBvQaxEcjllZQaeHo 5n4sz6qYOvOy0BUoHTBMcIARTWsr4vutaMYRcl/pnaBrDU2FIE9RaJdwxXPsqEA1wrK3DufoLY4 LMZl5ZBrDP5dqiP/4IqYFJKgeiJjbNmc3ENdL9D36FMreQx9xqvN41q6bcz80fjzySNPdCQhXeq KCwlbD9B5/WXJzo985gfXcL9h07Yrt/k9wkIaTF2gieicd64jRWm/+lKopWkIcCeXAeXcUqgQOx KrWPJO32q7VU0dsA8PZBUTca25GQl4pwkZ8ukPwNNGXXD0VS7gpSR7QANTAwp0KShXQxhbZsrqb 797wCZEwec+UXe1ctLw== X-Proofpoint-ORIG-GUID: AHV8HkE445plKP1XCY9mcSHVaGyZ0cYF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-08_05,2026-02-05_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 spamscore=0 bulkscore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602090045 Hi Krzysztof, On 2/6/2026 4:20 PM, Krzysztof Kozlowski wrote: > On 06/02/2026 11:07, Harshal Dev wrote: >> Hi Krzysztof, >> >> On 2/5/2026 4:47 PM, Krzysztof Kozlowski wrote: >>> On 03/02/2026 10:26, Harshal Dev wrote: >>>> Hi Krzysztof and Konrad, >>>> >>>> On 1/26/2026 3:59 PM, Konrad Dybcio wrote: >>>>> On 1/23/26 12:04 PM, Harshal Dev wrote: >>>>>> Hi Krzysztof, >>>>>> >>>>>> On 1/23/2026 2:27 PM, Krzysztof Kozlowski wrote: >>>>>>> On 23/01/2026 08:11, Harshal Dev wrote: >>>>>>>> Update the inline-crypto engine DT binding to reflect that power-domain and >>>>>>>> clock-names are now mandatory. Also update the maximum number of clocks >>>>>>>> that can be specified to two. These new fields are mandatory because ICE >>>>>>>> needs to vote on the power domain before it attempts to vote on the core >>>>>>>> and iface clocks to avoid clock 'stuck' issues. >>>>>>>> >>>>>>>> Signed-off-by: Harshal Dev >>>>>>>> --- >>>>>>>> .../bindings/crypto/qcom,inline-crypto-engine.yaml | 14 +++++++++++++- >>>>>>>> 1 file changed, 13 insertions(+), 1 deletion(-) >>>>>>>> >>>>>>>> diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml >>>>>>>> index c3408dcf5d20..1c2416117d4c 100644 >>>>>>>> --- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml >>>>>>>> +++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml >>>>>>>> @@ -28,12 +28,20 @@ properties: >>>>>>>> maxItems: 1 >>>>>>>> >>>>>>>> clocks: >>>>>>>> + maxItems: 2 >>>>>>> >>>>>>> This is ABI break and your commit msg suggests things were not perfect, >>>>>>> but it is not explicit - was this working or not? How is it that ICE was >>>>>>> never tested? >>>>>>> >>>>>> >>>>>> I took some time to educate myself on the point of DT bindings stability being a >>>>>> strict requirement now, so I understand how these changes are breaking ABI, I'll >>>>>> send a better version of this again. >>>>>> >>>>>> As for your question of how it was working till now, it seems that >>>>>> things were tested with the 'clk_ignore_unused' flag, or with CONFIG_SCSI_UFS_QCOM >>>>>> flag being override set to 'y'. When this is done, QCOM-ICE (on which QCOM-UFS >>>>>> depends) initiates probe _before_ the unused clocks and power-domains are >>>>>> disabled by the kernel. And so, the un-clocked register access or clock 'stuck' >>>>>> isn't observed (since the clocks and power domains are already enabled). >>>>>> Perhaps I should write this scenario explicitly in the commit message? >>>>>> >>>>>> To maintain backward compatibility, let me introduce minItems and maxItems for clocks. >>>>>> When the Linux distro uses CONFIG_SCSI_UFS_QCOM=y, we can do with just 1 clock as >>>>>> before. >>>>> >>>>> You must not assume any particular kernel configuration >>>>> >>>>> clk_ignore_unused is a hack which leads to situations like this, since >>>>> the bootloader doesn't clean up clocks it turned on, which leads to >>>>> situations like this where someone who previously wrote this binding >>>>> didn't care enough to **actually** test whether this device can operate >>>>> with only the set of clocks it requires >>>>> >>>>> I believe in this case it absolutely makes sense to break things, but >>>>> you must put the backstory in writing, in the commit message >>>>> >>>> >>>> I took some more time to think this through, and I agree with you now Konrad. >>>> >>>> These DT bindings appear to be invalid from day-1. ICE being an independent >>>> and common IP for both UFS and SDCC, it cannot operate correctly without its >>>> power-domain and clocks being enabled first. Hence, it should be mandatory for >>>> them to be specified in the DT-node and the same should be reflected in the DT >>>> binding. >>>> >>>> The only reason I can think of for omitting the 'power-domain' and 'iface' clock >>>> in the original DT-binding for ICE is because we failed to test the driver on >>>> a production kernel where the 'clk_ignore_unused' flag is not passed on the cmdline. >>> >>> That's a reason to change ABI in the bindings, but not a reason to break >>> in-kernel or out of tree DTS. >>> >>>> Or if we did test that way, we were just lucky to not run into a timing scenario >>>> where the probe for the driver is attempted _after_ the clocks are turned off by the >>>> kernel. >>>> >>>> Sending a new patch, which makes these two resources optional (to preserve the DT >>>> binding) would either imply that we are make this bug fix optional as well or >>>> asking the reporter to resort to some workaround such as overriding >>>> CONFIG_SCSI_UFS_QCOM to 'y'. >>> >>> Either I do not understand the point or you still insist on breaking a >>> working DTS on kernels with clk_ignore_unused, just because what >>> exactly? You claim it did not work, but in fact it did work. So you >>> claim it worked by luck, right? And what this patchset achieves? It >>> breaks this "work by luck" into "100% not working and broken". I do not >>> see how is this an improvement. >>> >> >> My point is something more fundamental. It worked before and it will still continue >> to work if: >> 1. We pass the 'clk_ignore_unused' flag. or, >> 2. If the Linux distro is overriding CONFIG_SCSI_UFS_QCOM to 'y'. > > I do not agree with this. I already commented about your driver. If you > do not believe me, apply your driver patch and show the test results of > existing working device. > > Apologies, it seems like I failed to explain correctly what I meant. Here I was talking about the existing in-tree ICE driver and not about this particular DT binding commit. This commit, as you rightly said and I mentioned below too, breaks backward compatibility for existing in-tree and out-of-tree DTS. >> >> But that does not change the fact that the current DT binding does not fully describe all >> the resources required by the hardware block to function correctly. >> >>> My NAK for driver change stays. This is wrong approach - you cannot >>> break working DTS. >>> >> >> I agree that this patch in it's current form will break both the in-kernel and >> out of tree DTS written in accordance with the old binding. If this isn't acceptable > > What? You just said few lines above: > "it will still continue to work if:" > I hope I am clear now, 'it' referred to the in-tree ICE driver and not to this particular DT schema commit. :) > So either this will continue to work or not. I don't understand this > thread and honestly do not have patience for it. I gave you already > reasoning what is wrong and why it is. Now it is just wasting my time. > Apologies again for the confusion. I totally agree, as replied previously too, that the updated DT binding breaks backward compatibility. Like I said, I will post another patch to preserve the correctness of existing in-tree and out-of-tree DTS. The only point I am trying to highlight for everyone's awareness is that as per this bug report https://lore.kernel.org/all/ZZYTYsaNUuWQg3tR@x1/ the kernel fails to boot with the existing DTS when the above two conditions aren't satisfied. Thank you, Harshal > Best regards, > Krzysztof