From: Dan Carpenter <dan.carpenter@linaro.org>
To: Philipp Stanner <pstanner@redhat.com>
Cc: Kees Cook <keescook@chromium.org>,
Andy Shevchenko <andy@kernel.org>,
Eric Biederman <ebiederm@xmission.com>,
Christian Brauner <brauner@kernel.org>,
David Disseldorp <ddiss@suse.de>,
Luis Chamberlain <mcgrof@kernel.org>,
Siddh Raman Pant <code@siddh.me>,
Nick Alcock <nick.alcock@oracle.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Zack Rusin <zackr@vmware.com>,
VMware Graphics Reviewers <linux-graphics-maintainer@vmware.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
kexec@lists.infradead.org, linux-hardening@vger.kernel.org,
David Airlie <airlied@redhat.com>
Subject: Re: [PATCH v2 1/5] string.h: add array-wrappers for (v)memdup_user()
Date: Sat, 16 Sep 2023 17:32:42 +0300 [thread overview]
Message-ID: <b219788a-69e6-44cf-a609-91f9640967f5@moroto.mountain> (raw)
In-Reply-To: <93001a9f3f101be0f374080090f9c32df73ca773.1694202430.git.pstanner@redhat.com>
On Fri, Sep 08, 2023 at 09:59:40PM +0200, Philipp Stanner wrote:
> +static inline void *memdup_array_user(const void __user *src, size_t n, size_t size)
> +{
> + size_t nbytes;
> +
> + if (unlikely(check_mul_overflow(n, size, &nbytes)))
> + return ERR_PTR(-EOVERFLOW);
No need for an unlikely() because check_mul_overflow() already has one
inside. I feel like -ENOMEM is more traditional but I doubt anyone/userspace
cares.
> +
> + return memdup_user(src, nbytes);
> +}
regards,
dan carpenter
next prev parent reply other threads:[~2023-09-16 14:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 19:59 [PATCH v2 0/5] Introduce new wrappers to copy user-arrays Philipp Stanner
2023-09-08 19:59 ` [PATCH v2 1/5] string.h: add array-wrappers for (v)memdup_user() Philipp Stanner
2023-09-10 7:43 ` Andy Shevchenko
2023-09-16 14:32 ` Dan Carpenter [this message]
2023-09-18 6:55 ` Andy Shevchenko
2023-09-18 9:13 ` Philipp Stanner
2023-09-08 19:59 ` [PATCH v2 2/5] kernel: kexec: copy user-array safely Philipp Stanner
2023-09-11 0:25 ` Baoquan He
2023-09-08 19:59 ` [PATCH v2 3/5] kernel: watch_queue: " Philipp Stanner
2023-09-08 19:59 ` [PATCH v2 4/5] drm_lease.c: " Philipp Stanner
2023-09-08 19:59 ` [PATCH v2 5/5] drm: vmgfx_surface.c: " Philipp Stanner
2023-09-12 1:27 ` [PATCH v2 0/5] Introduce new wrappers to copy user-arrays Kees Cook
2023-09-12 1:55 ` Dave Airlie
2023-09-12 2:32 ` Kees Cook
2023-09-12 1:53 ` Zack Rusin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b219788a-69e6-44cf-a609-91f9640967f5@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=airlied@gmail.com \
--cc=airlied@redhat.com \
--cc=andy@kernel.org \
--cc=brauner@kernel.org \
--cc=code@siddh.me \
--cc=daniel@ffwll.ch \
--cc=ddiss@suse.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=ebiederm@xmission.com \
--cc=keescook@chromium.org \
--cc=kexec@lists.infradead.org \
--cc=linux-graphics-maintainer@vmware.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mcgrof@kernel.org \
--cc=mripard@kernel.org \
--cc=nick.alcock@oracle.com \
--cc=pstanner@redhat.com \
--cc=tzimmermann@suse.de \
--cc=zackr@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®