mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Judith Mendez <jm@ti.com>
To: "Sverdlin, Alexander" <alexander.sverdlin@siemens.com>,
	"msp@baylibre.com" <msp@baylibre.com>
Cc: "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: ti: k3-am62a7-sk: Disable mmc Schmitt Trigger
Date: Thu, 19 Feb 2026 18:42:37 -0600	[thread overview]
Message-ID: <b22958ce-fb67-44d3-841a-d02a185942e5@ti.com> (raw)
In-Reply-To: <7ad9d8bf-a962-40f0-bc8a-92228aeb0b4e@ti.com>

On 2/19/26 6:10 PM, Judith Mendez wrote:
> Hi Alexander,
> 
> On 2/17/26 7:23 AM, Sverdlin, Alexander wrote:
>> On Tue, 2026-02-17 at 13:57 +0100, Alexander Sverdlin wrote:
>>>>>>>> Can you please run a quick tap sweep on MMC1 and MMC0 interfaces 
>>>>>>>> like
>>>>>>>> so? https://gist.github.com/jmenti/f4a73a8323e44bf717c6d2c528c499ca
>>>>>>>>
>>>>>>>> This will give me an idea if whether we should be talking about
>>>>>>>> revisiting characterization with ST_ENA=1.
>>>
>>> I wanted to apply your patch and test on our HW, but I have some 
>>> doubts, if
>>> the patch maybe missing something:
>>>
>>> - am654_sdhci_write_otapdly() turns out to be unused in any upstream 
>>> U-Boot version
>>> - new "omap" variable in am654_sdhci_execute_tuning() is in fact 
>>> unused as well
>>
>> and
>>
>> | /home/sverdlin/u-boot/drivers/mmc/am654_sdhci.c: In function 
>> 'j721e_4bit_sdhci_set_ios_post':
>> | /home/sverdlin/u-boot/drivers/mmc/am654_sdhci.c:598:9: error: 
>> 'itap_del_sel' is used uninitialized [-Werror=uninitialized]
>> |   598 |         printf("j721e_4bit_sdhci_set_ios_post, mode=%d, 
>> otap=%d, itap=%d\n", mode, otap_del_sel, itap_del_sel);
>> |       |         
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> | /home/sverdlin/u-boot/drivers/mmc/am654_sdhci.c:594:13: note: 
>> 'itap_del_sel' was declared here
>> |   594 |         u32 itap_del_sel;
>> |       |             ^~~~~~~~~~~~
>>
>>
>> so I'm not sure regarding the previous test results at all any longer..
> 
> Sorry for the late reply, somehow I missed this email.
> 
> Oh my, I am not sure what happend but seems like I did not copy the
> whole patch correctly. Were you able to bypass or do you need me
> to rebase the patch and copy correctly?
> 

Your response actually explains why Marcus's log did not make
sense at all, thanks. Here is the updated patch in case you need
it: https://gist.github.com/f4a73a8323e44bf717c6d2c528c499ca.git

Markus, can you try with this patch instead?

~ Judith

  reply	other threads:[~2026-02-20  0:42 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-06 16:22 Markus Schneider-Pargmann (TI.com)
2026-01-06 17:25 ` Alexander Sverdlin
2026-01-06 20:25   ` Markus Schneider-Pargmann
2026-01-07 14:23     ` Alexander Sverdlin
2026-01-07 22:57     ` Alexander Sverdlin
2026-01-08 16:40       ` Nishanth Menon
2026-01-08 17:54         ` Sverdlin, Alexander
2026-01-07 14:49   ` Alexander Sverdlin
2026-01-08 19:04     ` Markus Schneider-Pargmann
2026-01-08 14:07 ` Vitor Soares
2026-01-08 14:23   ` Alexander Sverdlin
2026-01-08 16:42   ` Nishanth Menon
2026-01-13  0:29 ` Judith Mendez
2026-01-14  9:16   ` Markus Schneider-Pargmann
2026-01-14 22:04     ` Judith Mendez
2026-02-03 10:35       ` Markus Schneider-Pargmann
2026-02-05  2:03         ` Judith Mendez
2026-02-05  7:24           ` Francesco Dolcini
2026-02-05 17:07             ` Judith Mendez
2026-02-05 17:57               ` Alexander Sverdlin
2026-02-17 12:57           ` Sverdlin, Alexander
2026-02-17 13:19             ` Sverdlin, Alexander
2026-02-17 13:23             ` Sverdlin, Alexander
2026-02-20  0:10               ` Judith Mendez
2026-02-20  0:42                 ` Judith Mendez [this message]
2026-02-26 19:59                   ` Markus Schneider-Pargmann
2026-03-16 12:22                   ` Sverdlin, Alexander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b22958ce-fb67-44d3-841a-d02a185942e5@ti.com \
    --to=jm@ti.com \
    --cc=alexander.sverdlin@siemens.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=msp@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®