From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F59F3033DE for ; Fri, 31 Jul 2026 13:52:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785505957; cv=none; b=h2MCO0UYWl8eUVLQryhD6ralGpUDyC30enxG7m/qBA8LlMQZ7N41co/DTcSQz5ziR6SsPs3OiOB3I8OKyl6hUtUUFji5RB3sh2SgJqBDyYie/YFCAM0UtFxi1K+uVU0ZRge9BYToXxZm6/2kUYKKOO7C4odX7/U1u2h5L7SA7HA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785505957; c=relaxed/simple; bh=lSZ+/tv9wX7w51bK6R7N7Sqsdlr7yLBGjQShbkEuqZY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iC1kIUloEhrJjOahhKQJBYS37HagCYwrw7WkfJLkffq6g+x7rcfL1rV5mIKvNTJPU8aZpLTjJdyD1T2iSRQVshg83TjLjfbRcz/Wz0j5RWH8TMI37TiDOdkNxjRrlWkFgZgijLMYmAHwkBWq2WamKH+hZyoD4qYx2+YNV9CvvyE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=lmmWoqP1; arc=none smtp.client-ip=209.85.210.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="lmmWoqP1" Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-7e9ecb1e13cso1061282a34.3 for ; Fri, 31 Jul 2026 06:52:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1785505954; x=1786110754; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=JsZfkDKXnNJmRKluxq/2lt4f+eKCbGLQWu+itVq10m8=; b=lmmWoqP1KgsDx3pYF+Keo8N13MBpcUFNNbKDJq74TJkzPQrqizqy9c/w+PLZi+h2qm We0bz/bT2+m2IS8g2crmvQvf0swQ149nUMfEbM1sJZd3Dq5mxYvk13mZjz5ZW71wgGPA hune1U8ZiAq3i76z4bmeGxFIA4OYMS/3M12LwiRBjWOKkZyAYCUf14e9plwTrvZTo0zU RYgprHlckkRhvXMjqRJ6dtWvmi/2FVd9xZDqw+J0d1tP9wEtLPzd6RHvZSdJRqf4kPld 4UuLP6/26572oRaMCjV1pHBy3hZdhchqJWhANaZVUC/qwqZgZG2HWbySN0QEnz9HE5gS C6mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785505954; x=1786110754; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=JsZfkDKXnNJmRKluxq/2lt4f+eKCbGLQWu+itVq10m8=; b=V1c6Fc0ZEtmI+DeQKanhc256VQb3F2AbOuZGtkEhEC+8cB2f2FLl5JwwY+x6oXIGYH Rb3VjnC5WSgDboouYdMBbLtsqnlkgsRBudhpEdCbtMcs3x5PLYA62HMrbZUYK3JhhsxA PWBXxbRj/MC/J8WuzpPoQipSeqlSIoZUQFwKXUf2FyecoACzmkiEpWfyJ7zmjaQYHhwD iUZU5Wvi2y2uSyDLtWE9b0otzM6P9doIYXj5YOER0FGeRu3rX17eEWsMfGHGPJi87+XT V+npnGqzOVsw/oLmDOrO8kMWrLmY/OmDa/H9IIp2s+iznvijIavL4HcDo1XYKUC3k9yt exrw== X-Forwarded-Encrypted: i=1; AHgh+Ro+6TJeFGp5h6+afwtKibazBqxqbQPcqHyQUkNLqHJHoxRwkO2BRjm8309+l4rZNrYvn0m7oAQ50G/sqUw=@vger.kernel.org X-Gm-Message-State: AOJu0YyaP9nHKAf2fQHIqs+lqjlHE6DOOy6uDROln1t9GyyhbDz/sibE BqLPMzUgNsGavJCs1HSv0yVKF9GZiwacrRTBlQhh5EbW2BOFGJNH+1hbaLbm/WGFlZ4= X-Gm-Gg: AR+sD137JpiPmlTf9ps9KXzrYVbzn1GBVc2eNaz1Z4h7eBYZ7Hp+j2bLQ/PAS5srNxa t8IaHdMu5drv6b929/YGFPVw5Zvo0lMFR18h/zOD0L5SYTJFgnWHmPYV98eJxTzsB6E8QwpEpYM F2ATXwzd+BZVB077fsCoafgHtpY7jJPAaOBGNKls5sTdogTmR+ojtwjlLPhxYlhZn+w06E/940J ckarePIBcVV7HGx5T54FH7abIiTcpft6XW3tDe90zaJayIA/EIzhgnEA6Qlppao5+Fvs7pauK/a 0Oi+WiiTmCSlTN4AcJuSr36R2vJuCqLaAY+Gpb8RcTgpELtQiDPO+RCUHOUUqSdCCYH+c92iVa8 Zh+vRvv5wUq5a5u4y78EJmoskRRIceCrFczXcpqWwBYsAGMEe228Vk98rid93qAAlHwJFFIVrvY CWpTW3K4V+Q3dUfa6J2lYAYRFjSHt7ioVIXQSEZN9uw/4iJL20+aIMZJPys8RkQYVvKySadX3gV kyfaON83UW/Xh0nc6ceoYSpbjb2wY9yLuat2Js= X-Received: by 2002:a05:6830:4983:b0:7dc:df37:844b with SMTP id 46e09a7af769-7f189afca30mr3300344a34.4.1785505954129; Fri, 31 Jul 2026 06:52:34 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:fa40:746f:401a:3b75? ([2600:8803:e7e4:500:fa40:746f:401a:3b75]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7f18ed9af83sm653269a34.10.2026.07.31.06.52.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jul 2026 06:52:32 -0700 (PDT) Message-ID: Date: Fri, 31 Jul 2026 08:52:31 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] dt-bindings: iio: adc: ti,ads112c04: Add binding for ADS112C04 To: Kyle Hsieh , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liam Girdwood , Mark Brown Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260731-ti-ads112c04-driver-v2-0-aab0168c3c01@gmail.com> <20260731-ti-ads112c04-driver-v2-1-aab0168c3c01@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260731-ti-ads112c04-driver-v2-1-aab0168c3c01@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/30/26 9:58 PM, Kyle Hsieh wrote: > Add device tree binding documentation for Texas Instruments ADS112C04 > I2C Analog-to-Digital Converters. > > These devices provide 4-channel, 16-bit delta-sigma ADCs with an I2C > interface, programmable gain amplifier (PGA), and data-ready (DRDY) > interrupt output. > > The binding uses child nodes to dynamically define the connected > single-ended or differential channels. > > Signed-off-by: Kyle Hsieh > --- > .../devicetree/bindings/iio/adc/ti,ads112c04.yaml | 122 +++++++++++++++++++++ > 1 file changed, 122 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads112c04.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads112c04.yaml > new file mode 100644 > index 000000000000..6a5ffda84b80 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads112c04.yaml > @@ -0,0 +1,122 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/ti,ads112c04.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments ADS112C04 ADC > + > +maintainers: > + - Kyle Hsieh > + > +description: | The | isn't needed in this case. (It is only needed if we needed to preserve formatting, or if there is a : in the text that would be interpreted as a dict key.) > + The ADS112C04 (16-bit) are precision analog-to-digital converters (ADCs) > + with an I2C interface. They feature a flexible input multiplexer, a > + low-noise programmable gain amplifier (PGA), two programmable excitation > + current sources, a voltage reference, and a precision temperature sensor. > + > +properties: > + compatible: > + enum: > + - ti,ads112c04 > + > + reg: > + maxItems: 1 > + description: I2C address of the device. > + > + interrupts: > + maxItems: 1 > + description: Data ready (DRDY) interrupt output. > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + reset-gpios: > + maxItems: 1 > + description: GPIO connected to the RESET pin. Active low. > + > + avdd-supply: true > + dvdd-supply: true > + > + refp-supply: true > + refn-supply: true > + > + ti,refp-refn-resistor-ohms: > + $ref: /schemas/types.yaml#/definitions/uint32 As the bot said, don't need $ref here because it is a standard unit. (So don't forget to run `make dt_binding_check DT_SCHEMA_FILES=ads112c04` before sending.) > + description: Resistance of the external resistor between REFP and REFN. > + > +patternProperties: > + "^channel@[0-9a-f]$": > + $ref: adc.yaml > + unevaluatedProperties: false > + properties: > + reg: > + items: > + - maximum: 15 This chip doesn't allow arbitrary combinations, so there are actually only 12 possible single-channel + diff-channels values. So maximum: 11 and channel@[0-9a-b] would make sense. > + > + single-channel: > + maximum: 3 > + > + diff-channels: > + items: > + maximum: 3 For this chip, we should also have excitation-channels, excitation-current-nanoamp, and reference-sources. > + > + oneOf: > + - required: [ single-channel ] > + - required: [ diff-channels ] > +