From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE74D30E0D1 for ; Fri, 12 Sep 2025 13:32:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757683972; cv=none; b=Z1aUJIzNcITPm/96NVg6Jhm80crBrEbUETihJTbB48jrNFUInM7LoGWwIqVwAFD7QmHg/X0ZFSMa32EJ0VMn0FX/4prsAyIGA7VIGP4mayBchB8rNRkowIL3T22iqkByyhclMA5z52fhS0Grruj6eJ21PFEWKmDmD41JbA39KOc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757683972; c=relaxed/simple; bh=7iYpSjnNZlF584j4SaaGW7J0wzvD9uJDKsgiq1vHdl0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=D6bERR3aeRa3HpmY8L7Iy9ARk6GWtTz81JxFTy2kQ6gDyu7rWanRptV9AhRiof3lCooNy93wpGOGQHnD7JrnF3EojUYn3YswffewFuB9fD5wh6ebkpEl7hxEZxwS0N2G/+f7pDe+8rr7CO+unWNXf+6Aq844o51jlr0qBHFh3m4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HnG/1Jwn; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HnG/1Jwn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757683969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=d3WySasVKe/ME+w6oNrrZ2gd9OipXbQaPkCZGsmbrHU=; b=HnG/1JwnQeb/Kvs5hB+WJA0Ygi/64zz+jQyRp9v0jFoYxZh5umO3n1ff7qZSWFd07Fq613 +OQcybDk5NT9UjG0/aVqVN3RQMKasCW221UgHzk/NpwdM9vzMl2KSzr4EyoGmMCMTnbRXD 9OAk9SBA4taDLsNwjvP8DhBLwAzxA5o= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-482-QWnpLs7ROPCPi4bmU7nmHQ-1; Fri, 12 Sep 2025 09:32:46 -0400 X-MC-Unique: QWnpLs7ROPCPi4bmU7nmHQ-1 X-Mimecast-MFC-AGG-ID: QWnpLs7ROPCPi4bmU7nmHQ_1757683966 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3df2f4aedd1so1383941f8f.3 for ; Fri, 12 Sep 2025 06:32:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757683965; x=1758288765; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=d3WySasVKe/ME+w6oNrrZ2gd9OipXbQaPkCZGsmbrHU=; b=HAW6cIH0haN5n+xq7raT9yPKh/4S7LcX6rz+7IU5Vr/GPRoC2JOAQSuFGwH1lCL8XJ FmgZhqsCMrVK5Ue5V1j0UADTds9qYphMCA7X1bAgXvW3CZmeUaXU1NdkVwMPxxtCZmqX yvWPsI2OnSor9Pc/nF12xWRMtUDPSRyMZZBosiFohIblIIeXPjR4LmMgYas3VdOTmuqb 1JZUPBCN+P/VLLZLKuGauy1fdxOIsnraYN3yBhcSCYTHsUm9j2AgatmWSOdJkzz9coIj Mgs77h2hKO7iHXW9zPFYfKK3cHszyUC5yXcuXsUZb01kzY6q+US/R56HpcD27yIssNYk ucOw== X-Forwarded-Encrypted: i=1; AJvYcCUHcfynEGUJ2QZMuiLzCmUU11NG/j1gdCLcPdmz5Rb41hQgBp1mQ+a72p7uMbUBH8XSt5nIwCGnv+jJoC8=@vger.kernel.org X-Gm-Message-State: AOJu0YwoSG7boQe5oWgl6eH/+GiP/GI7W+w+/wufqlAi6GxH8AKvFpBz 3ctC5JK8fxNu6FbCayYL2/WLgL4M6pmnw+3eTJvZKd9hibqFFaVxtU5UPsSItE6MOrRFWgOgtPj vKSSp3m38hwTsSYSwQMm/JvX8Bl/oBgSDFZU+uKky0jzgrIwsnkm/DSAwiHTZG0knKg== X-Gm-Gg: ASbGncsibsEE99PYdFyWlcS36k0Qporeqyv1lA1KeoQL83+z/pFf+uU7po7QKA2BRX2 OmzI6+dJz/6XHtxciZVSJUFzGoN37Dhrj5dHrG0p/mCM980IbCJ+eOBxMS46xsQU9ig09BRKvqM GQI8w7Daw7XB0HHWtWZeCwEPm/O55AX7vVnToMbDOHfXubjSEFQjyRkZwOBeAPQwgFL8gA2YxB/ xEFuhxzo8XeoEfPHDYL1267y+k5I/0tHlR7qNRo/IA6KfT9aj/720WBYWICXRov386jXC87sJLK 2uY1M9qxLVIABnsYytIeK1LSqi8GICtGMgNajhaebvU3icgDvSag+Jmqs6HVh2o78Q8x/AQUgsK I1I4QeN1vT7oO4yAvlXWXOIjjOCX9Aq7Z46Ls5EaLVdHzeAi+6WTZ60wamQ0vzhq0ZLM= X-Received: by 2002:a05:6000:2584:b0:3d2:208c:45aa with SMTP id ffacd0b85a97d-3e7659eb4damr2923130f8f.29.1757683965376; Fri, 12 Sep 2025 06:32:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGQvIA7aWaWPgRmM3ibF4CzK7cagNHsOvK16zCwCwknz8tuIMHPgwLUmt6YVpOJeww1hCUbMg== X-Received: by 2002:a05:6000:2584:b0:3d2:208c:45aa with SMTP id ffacd0b85a97d-3e7659eb4damr2923086f8f.29.1757683964875; Fri, 12 Sep 2025 06:32:44 -0700 (PDT) Received: from ?IPV6:2003:d8:2f20:da00:b70a:d502:3b51:1f2d? (p200300d82f20da00b70ad5023b511f2d.dip0.t-ipconnect.de. [2003:d8:2f20:da00:b70a:d502:3b51:1f2d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e760786ceasm6793014f8f.16.2025.09.12.06.32.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Sep 2025 06:32:44 -0700 (PDT) Message-ID: Date: Fri, 12 Sep 2025 15:32:42 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 1/5] mm: softdirty: Add pgtable_soft_dirty_supported() To: Chunyan Zhang Cc: Chunyan Zhang , linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Deepak Gupta , Ved Shanbhogue , Alexander Viro , Christian Brauner , Jan Kara , Andrew Morton , Peter Xu , Arnd Bergmann , Lorenzo Stoakes , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Axel Rasmussen , Yuanchu Xie References: <20250911095602.1130290-1-zhangchunyan@iscas.ac.cn> <20250911095602.1130290-2-zhangchunyan@iscas.ac.cn> <9bcaf3ec-c0a1-4ca5-87aa-f84e297d1e42@redhat.com> <04d2d781-fd5e-4778-b042-d4dbeb8c5d49@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12.09.25 11:21, Chunyan Zhang wrote: > On Fri, 12 Sept 2025 at 16:41, David Hildenbrand wrote: >> >> [...] >> >>>>> +/* >>>>> + * We should remove the VM_SOFTDIRTY flag if the soft-dirty bit is >>>>> + * unavailable on which the kernel is running, even if the architecture >>>>> + * provides the resource and soft-dirty is compiled in. >>>>> + */ >>>>> +#ifdef CONFIG_MEM_SOFT_DIRTY >>>>> + if (!pgtable_soft_dirty_supported()) >>>>> + mnemonics[ilog2(VM_SOFTDIRTY)][0] = 0; >>>>> +#endif >>>> >>>> You can now drop the ifdef. >>> >>> Ok, you mean define VM_SOFTDIRTY 0x08000000 no matter if >>> MEM_SOFT_DIRTY is compiled in, right? >>> >>> Then I need memcpy() to set mnemonics[ilog2(VM_SOFTDIRTY)] here. >> >> The whole hunk will not be required when we make sure VM_SOFTDIRTY never >> gets set, correct? > > Oh no, this hunk code does not set vmflag. > The mnemonics[ilog2(VM_SOFTDIRTY)] is for show_smap_vma_flags(), > something like below: > # cat /proc/1/smaps > 5555605c7000-555560680000 r-xp 00000000 fe:00 19 > /bin/busybox > ... > VmFlags: rd ex mr mw me sd > > 'sd' is for soft-dirty > > I think this is still needed, right? If nobody sets VM_SOFTDIRTY in vma->vm_flags, then we will never print it. So you can just leave the "#ifdef CONFIG_MEM_SOFT_DIRTY" as is to handle the VM_SOFTDIRTY=0 case. So you should not have to change anything in show_smap_vma_flags(). [...] >>>> That should be handled with the above never-set-VM_SOFTDIRTY. >>> >>> We don't need to check if (!pgtable_soft_dirty_supported()) if I >>> understand correctly. >> Hm, let me think about that. No, I think this has to stay as the comment >> says, so this case here is special. > > I will cook a new version and then we can discuss further based on the > new patch. Sounds good! -- Cheers David / dhildenb