From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Manojkiran Eda <manojkiran.eda@gmail.com>,
patrick.rudolph@9elements.com, chiawei_wang@aspeedtech.com,
ryan_chen@aspeedtech.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au,
miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
jk@codeconstruct.com.au, openbmc@lists.ozlabs.org
Subject: Re: [PATCH v2 3/4] ARM: dts: aspeed: Add eSPI node
Date: Tue, 19 Mar 2024 10:50:02 +0100 [thread overview]
Message-ID: <b238d70e-0361-4f3c-ae6a-4e6497b95d75@linaro.org> (raw)
In-Reply-To: <20240319093405.39833-4-manojkiran.eda@gmail.com>
On 19/03/2024 10:34, Manojkiran Eda wrote:
> This commit adds eSPI to the device tree for aspeed 5/6th
> generation SoCs.
>
> Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
> ---
> arch/arm/boot/dts/aspeed/aspeed-g5.dtsi | 19 +++++++++++++++++++
> arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 20 ++++++++++++++++++++
> 2 files changed, 39 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed/aspeed-g5.dtsi
> index 04f98d1dbb97..eaf7d82b6f46 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed/aspeed-g5.dtsi
> @@ -343,6 +343,25 @@ sdhci1: sdhci@200 {
> status = "disabled";
> };
> };
> + espi: espi@1e6ee000 {
spi or syscon
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "aspeed,ast2500-espi", "simple-mfd", "syscon";
> + reg = <0x1e6ee000 0x1000>;
> +
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x0 0x1e6ee000 0x1000>;
> +
> + espi_ctrl: espi-ctrl@0 {
What is this device? If parent is espi, then what is this?
Where is the binding?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-19 9:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 9:34 [PATCH v2 0/4] Add eSPI device driver (flash channel) Manojkiran Eda
2024-03-19 9:34 ` [PATCH v2 1/4] " Manojkiran Eda
2024-03-19 9:49 ` Krzysztof Kozlowski
2024-03-19 9:34 ` [PATCH v2 2/4] mtd: Replace module_init with subsys_initcall Manojkiran Eda
2024-03-19 9:51 ` Krzysztof Kozlowski
2024-03-19 9:53 ` Miquel Raynal
2024-03-19 9:34 ` [PATCH v2 3/4] ARM: dts: aspeed: Add eSPI node Manojkiran Eda
2024-03-19 9:50 ` Krzysztof Kozlowski [this message]
2024-03-19 9:34 ` [PATCH v2 4/4] dt-bindings: aspeed: Add eSPI controller Manojkiran Eda
2024-03-19 9:56 ` Krzysztof Kozlowski
[not found] ` <a9faa9b4-9bf6-49b6-b7eb-f642e2d261c3@gmail.com>
2024-03-20 14:44 ` Krzysztof Kozlowski
2024-03-28 11:33 ` Manojkiran Eda
2024-03-30 18:36 ` Krzysztof Kozlowski
2024-03-20 15:40 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b238d70e-0361-4f3c-ae6a-4e6497b95d75@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@codeconstruct.com.au \
--cc=chiawei_wang@aspeedtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jk@codeconstruct.com.au \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=manojkiran.eda@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=openbmc@lists.ozlabs.org \
--cc=patrick.rudolph@9elements.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=ryan_chen@aspeedtech.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®