From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07C7F4CA298 for ; Thu, 23 Jul 2026 13:03:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784811810; cv=none; b=bRy5TTVZ84vGZZ9iQ6xS5CiLQ96m+Od8ZeFZQG564jjGWMCu7yjoNyK9ldp8De4572OgCOSu74qfb0e+W5+m+fZccadk+DCaLDvtfnNZvaPa38ib6VXNvskKMKsQVgMd8OcybIjvDNQDUaQgcVUhfxCsp/O0H4714MANx7tLu9I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784811810; c=relaxed/simple; bh=o4I21Izv9BhqeNzRRuSgO3vorZoOkvzJ/7C19kIPh/I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=abfy/MVqubHhdCDx5huuCHeiGcScaybBUD9rPe+d/dEPP3ZFys/PuqkRW6V4EGK4yi+yAE8Fhi8J4FpRceidUEu5vVuWbizIuKz0UPRfrL+rBAQn6igtpY1rvGnxoZSGSC7RApX/d/SrUFL+p0no1Lw96cWn2GY9NXVKczeNlqI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pX9MhGfn; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aW8yvnf3; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pX9MhGfn"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aW8yvnf3" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66NCvlHd4050212 for ; Thu, 23 Jul 2026 13:03:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uNSSLfxtoiUMkYrN0H0VYtMiS9IIkqhLoMRgaUQ/d9k=; b=pX9MhGfnt1WQ8PVN JO+Zt0Mc/BbxqCMj8s8WwkqpJANa8ojXWaV+oMjOst4HkNViKzrtqkFXtANm4D/t 3wuXoScRh67SQ4GoMJciNrzMY3I7rRJ65cxjmF9498scJbeeoW9+fIvgVCeuOUGr fzWyZVOsvngWKHOzjr4DqxcFd03SO4EPKPxkS6fibwGSWWs8XqnHdR7CVD5T2M8w OXQfxdLIDwMR8qnDhsWjKLvOa1FDd8aePtEHMLyF55YZueDeeCh8++NMKd3zziKG YIOcjw/MMhkzWAvJNREXAgQEfdR/gUFbD83Wv87CROEgfxLBuJCA0SyIurxM7HCx Qr1h2w== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fk28vm7a9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Jul 2026 13:03:23 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51c1e777a15so1586411cf.2 for ; Thu, 23 Jul 2026 06:03:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784811799; x=1785416599; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=uNSSLfxtoiUMkYrN0H0VYtMiS9IIkqhLoMRgaUQ/d9k=; b=aW8yvnf3bR2CK+Cl+zKi+yaLSCFW9H585HG+kPH1KjwbCL7LxGsK9CwYCsBZkAdH33 pe17urlP5WGwfXWkXwsmpvT35DlGRk47pQllWzLbx1riE7tT1DDVtv/rqO0QGT1x2vfb gOj8FL2yzDWYyH6LQQdJYPR0gByLpeN5319ACosej2RDqgi3M55Ej8DZ7jLFoh5VocEf WZlVrWCW33CmVFBsYLKpkrCsEr85MZjATvvcWoCS/zxqxqV90JiOMX+CxMW6hDJYlq1k vvqN6x2iSd/RpDQPoXPKaMDCTTYaUOnwGCLwkFsrXWNgK15MiEng1e8jMTW9EekgZIJY 6VaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784811799; x=1785416599; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=uNSSLfxtoiUMkYrN0H0VYtMiS9IIkqhLoMRgaUQ/d9k=; b=PWeRhFEnvkceSJ8zurHsEJQHggM5KGBEUYouhvT7fW09MxkVfoyi1tFr+kFLvdseEW Dr3HtnzNY3PXNoLwG/im0+CCwSLtRg610L/QKSBqYxkfFiMBtKsmIp4OOA3eAO7qqkpc SEVQowQXN2JMFKZiqcTIgqZNVzDAe3Gq7VpaPv0CgLsCmhNLareEI5JZLd6S3ewu99rh rrcKlWpxKEUNDXOSB83Iy7Vbwv8QBu7L58cId/+F8nz6z+ScL42vJrDghwaskSzkdHft eFeF+o+and1YzHa2fNam2xmgLyCf6q1vyxQ1bZr4Hla2uJR9caCOt6qf/tEMo87+AaQS asoQ== X-Forwarded-Encrypted: i=1; AHgh+Ro1expT3X1IdATE3sKVSQk1WwsF+WVHu4PnhZN7Bhw7bui1nMXsJiI70rFjiz74d/WV1BkUYJud2tO83Ds=@vger.kernel.org X-Gm-Message-State: AOJu0YzsePD8aS9qo+xq1jTpIle7g7lCHXGMWuV+YJMZFwXVMI2rawmm OdkdACln5hCa1ULbUrq4pdUa/VcSF16JJshaUgNf30IEKhWJGjA0fIdObugiSSV9wZ+VXzIJuJL izsx5Fh0AbH6j1UaJZiEQhHwAq/ailVwoU/fF+raTfG7uJFsB9+WqcUpKRKwnfzpZBzs= X-Gm-Gg: AR+sD13UljuulKbND76wo4q0d7kBWANoH+BS3sWP60fJHo2jvQiuiTGJDwgTFPCp48H c7UkbXpYO7nVHhYDvJInjFm9sfAMaPyxVS3FOhfY7JtHpES6bObBpp48EQ0xBdQlddyt/8mlLCd YhHs5NrW8DC+QOlLb2jSjvweKkc1Zdvq82+omT+jORPW1Bn9pihoxJ1EVEQlrOERD3GArG2xRxN 6u7NYBcvcLCM5hpw7XqJiXRha6pKLVTpOvltVfFSq+bMMK7gCoGmRfPH74FYcvixgf4OqbkpN4o QxfqNlwH+bxxQNOVEXUWqpmm/nl7utTp/cmV8axqHkN/M4fqH2JeCfkgHO74lnSKvZzpWGRAEAW 49G9fkXUnBivC5vFbirglGG6d X-Received: by 2002:a05:622a:64f:b0:51c:83f1:bcd4 with SMTP id d75a77b69052e-5283db3bd2fmr22151601cf.0.1784811799026; Thu, 23 Jul 2026 06:03:19 -0700 (PDT) X-Received: by 2002:a05:622a:64f:b0:51c:83f1:bcd4 with SMTP id d75a77b69052e-5283db3bd2fmr22150981cf.0.1784811798317; Thu, 23 Jul 2026 06:03:18 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b2a9f48edcsm991679e87.73.2026.07.23.06.03.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jul 2026 06:03:16 -0700 (PDT) Message-ID: Date: Thu, 23 Jul 2026 15:03:13 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Revert "scsi: ufs: core: Remove unnecessary block I/O quiesce for clock scaling" To: Manivannan Sadhasivam , alim.akhtar@samsung.com, avri.altman@sandisk.com, bvanassche@acm.org, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com Cc: peter.wang@mediatek.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Shawn Guo References: <20260723124733.341789-1-manivannan.sadhasivam@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260723124733.341789-1-manivannan.sadhasivam@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIzMDEyOSBTYWx0ZWRfX4gxQV0kIOcm1 UAAiwFUxKlSa7zJ1xNsNeHBzW4cwUAuHjO83SHHCSERDl6bUFxgvdfc9mKQ66ZaJ93FVk7Gz5BU uUd2cJPczKr7i971gY0IqOe1Dlib9QM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIzMDEyOSBTYWx0ZWRfXxh3TCXG4RYTF gDgqZE0vJrt1v39l7zga8KMc7KOiiktiUoyGV5Y91LZqcwV9KEJBM4UB3GsM7l8WTeDD2HTqANg JLsIjmWPJKAbyd9E2GXW5i45/sb1zk7Q9CMiZNMbOlxTfGL7EuDaRbo5j6yli7U8gTbAufjKqHE pQkAU/iW2VybxCP1xnscxwgWw4wEK7J0QtAhiK9CTkAuy1kqKvBt5xR4aa+5JZjP4hQVlMWXECl 0ux2NXBux2m6gEboGsFP1fHLxfAfjgvyysop3xNFhD3uDBGHLCVUklk1wu+aCUnZE3icbhnMlnW /c/rgH9ZAC6ZqJr7+LORjBKHE8No+yHVfu3WooLQw23njiP+fvegLIMiJgUs9x00mn/khgpF/K3 6bOyNRObb/T8jaXJ2tI4zRprRaFQaxr9uYCrmbOTGYDHER3rfWUKxElocot+N+4z3IWZNr3+gFQ of9OqfQ3Jv8RP4mzqdA== X-Proofpoint-ORIG-GUID: IBZ4QwQKbXQ8Gy561pl2uoof5jNqDT2i X-Proofpoint-GUID: IBZ4QwQKbXQ8Gy561pl2uoof5jNqDT2i X-Authority-Analysis: v=2.4 cv=D4V37PRj c=1 sm=1 tr=0 ts=6a62111b cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=vq3bXs1Fwz2bHWXBoJUA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-23_04,2026-07-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 adultscore=0 priorityscore=1501 phishscore=0 spamscore=0 bulkscore=0 suspectscore=0 impostorscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607230129 On 7/23/26 2:47 PM, Manivannan Sadhasivam wrote: > This reverts commit 85b2b966285498e1b551ac85f02c79cd06c0cff0. > > Qcom UFS Host Controllers do not support scaling clocks when the traffic is > ongoing. But the offending commit removed the block I/O quiesce in the > clock scaling path, which causes below UFS failures during clock scaling: > > ufshcd-qcom 1d84000.ufshc: ufshcd_check_errors: saved_err 0x80 saved_uic_err 0x0 > ufshcd-qcom 1d84000.ufshc: ufshcd_err_handler started; HBA state eh_fatal; powered 1; shutting down 0; saved_err = 0x80; saved_uic_err = 0x0; force_reset = 0 > ufshcd-qcom 1d84000.ufshc: pwr ctrl cmd 0x2 with (MIBattribute 0x1571, mode 0x11) completion timeout > ufshcd-qcom 1d84000.ufshc: UFS Host state=3 > ufshcd-qcom 1d84000.ufshc: 7 outstanding reqs, tasks=0x0 > ufshcd-qcom 1d84000.ufshc: saved_err=0x80, saved_uic_err=0x0 > ufshcd-qcom 1d84000.ufshc: Device power mode=1, UIC link state=1 > ufshcd-qcom 1d84000.ufshc: PM in progress=0, sys. suspended=0 > ufshcd-qcom 1d84000.ufshc: Auto BKOPS=0, Host self-block=0 > ufshcd-qcom 1d84000.ufshc: Clk gate=1 > ufshcd-qcom 1d84000.ufshc: last_hibern8_exit_tstamp at 196451913 us, hibern8_exit_cnt=20 > ufshcd-qcom 1d84000.ufshc: error handling flags=0x0, req. abort count=0 > ufshcd-qcom 1d84000.ufshc: hba->ufs_version=0x300, Host capabilities=0x1587031f, caps=0x124f > ufshcd-qcom 1d84000.ufshc: quirks=0x0, dev. quirks=0x310c4 > ufshcd-qcom 1d84000.ufshc: UFS dev info: SAMSUNG KLUDG4UHDB-B2D1 rev 0400 > ufshcd-qcom 1d84000.ufshc: clk: core_clk, rate: 300000000 > ufshcd-qcom 1d84000.ufshc: clk: core_clk_unipro, rate: 300000000 > > Hence, revert the commit to bring back UFS on all Qcom platforms. > > Reported-by: Shawn Guo > Closes: https://lore.kernel.org/linux-scsi/al8YkXydXJQZrl_Y@QCOM-aGQu4IUr3Y > Signed-off-by: Manivannan Sadhasivam > --- Tested-by: Konrad Dybcio # SC8280XP CRD Konrad