From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755491AbcHXNAl (ORCPT ); Wed, 24 Aug 2016 09:00:41 -0400 Received: from mx2.suse.de ([195.135.220.15]:46841 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755288AbcHXNAk (ORCPT ); Wed, 24 Aug 2016 09:00:40 -0400 Subject: Re: [PATCH v2 7/8] hisi_sas: add TMF success check To: John Garry , jejb@linux.vnet.ibm.com, martin.petersen@oracle.com References: <1472036754-156813-1-git-send-email-john.garry@huawei.com> <1472036754-156813-8-git-send-email-john.garry@huawei.com> Cc: linuxarm@huawei.com, zhangfei.gao@linaro.org, xuwei5@hisilicon.com, john.garry2@mail.dcu.ie, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org From: Hannes Reinecke Message-ID: Date: Wed, 24 Aug 2016 15:00:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <1472036754-156813-8-git-send-email-john.garry@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/24/2016 01:05 PM, John Garry wrote: > When a tmf is issued, various response codes can be > returned from the target. For a query tmf the > response may be TMF_RESP_FUNC_COMPLETE or > TMF_RESP_FUNC_SUCC. > Add a condition for TMF_RESP_FUNC_SUCC to > hisi_sas_exec_internal_tmf_task(). > This affects query tmf, as the result is success > the returned value was for failure. > > Signed-off-by: John Garry > --- > drivers/scsi/hisi_sas/hisi_sas_main.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c > index 73f581f..85c73d3 100644 > --- a/drivers/scsi/hisi_sas/hisi_sas_main.c > +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c > @@ -744,6 +744,12 @@ static int hisi_sas_exec_internal_tmf_task(struct domain_device *device, > } > > if (task->task_status.resp == SAS_TASK_COMPLETE && > + task->task_status.stat == TMF_RESP_FUNC_SUCC) { > + res = TMF_RESP_FUNC_SUCC; > + break; > + } > + > + if (task->task_status.resp == SAS_TASK_COMPLETE && > task->task_status.stat == SAS_DATA_UNDERRUN) { > /* no error, but return the number of bytes of > * underrun > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)