From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2F91366553 for ; Fri, 4 Sep 2026 09:01:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788512472; cv=none; b=im2dsqxJRFTODJweGrm9MsRZl+RMnHvCD0ByDSX8Uo3joU2i1+zZHoQ4kA+drhtea/fd04NhNKGhmJns8nKT7sP0t4PS+m3LWxehIETrOWz0bCbRy8L03AeHgEuvwB/VHInlbICzctpAGY8T/cyjkX8FlkjSSru4VOQZ5Qg2z/4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788512472; c=relaxed/simple; bh=z8mUeY8jdDe+OPla++cCBqYJoVtldQxpArBHUi5E2dA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=n3ppq6OyLPLXJodQ0odQkv20NTayH5MXnC3NIQQVghzHAEt3Xb3i0JDZbBMIVp1GSKNyROaF/dJMWQCSj1yWhjWWw4iGhhhoZ8re/Bunai9d9Z6HMs6r21c5sTrg7voNlkJ3p5eaBC0qdTXj05aWwwAxElhKvqtdgH1oxrPVCXU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jdPDAK05; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QBhOSDB8; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jdPDAK05"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QBhOSDB8" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6847n5HW2839766 for ; Fri, 4 Sep 2026 09:01:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XfbM+zSlZv8MMTw8htQZYg+PCfRFWtMlG3dHQRCYpuc=; b=jdPDAK053fGQzOXD 4cj+xPyScRRHFDeNL8zcHzs4mOeJur0khdg/RqOwN2LWNkaAIBRuQ66CDy9SNfUz cdjxEZOdcuoo5xTcBheqPhDXrE3G5fga5X8nlO191lDpsOMTqPXi6oWY2jljfKQV 59dl4zlsOQKAGJaFwidGakLayrYMXJrPbLTGEjifEYBP7lgmaCOAlYeIx9GCaBDf M2HQZMn55+SmjevbfDJp9azLFpkl/eyqSfKf8dsWQyuZeGef6wUQhnewV2I6jRla FTBgBvCfz4S00/OEhRxPpzd4j/JAyFQY6vx5JFZwoS0qJnO2TdcU0HCQ3mRYVUjR lvuEAg== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gfqqtrpcn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 04 Sep 2026 09:01:09 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-52ea38b1e7eso1984401cf.3 for ; Fri, 04 Sep 2026 02:01:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788512469; x=1789117269; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=XfbM+zSlZv8MMTw8htQZYg+PCfRFWtMlG3dHQRCYpuc=; b=QBhOSDB8lo6bge+DCDfeiHrVM3sOSlH3kqz/P13gL8NurK61xFei5bbILuU5+kCB3a HMuo8xfm6vu62yaXy99Q2EzMEN17Jl6BqBXBliwKiK5YHcEbMBsKim8/hO/0fLC8czUY V7cko+I/GHTDzh0aTA8wyJOBZGTC2sKct13hFtlHGPIZhsFVEGrsFcCOzra7m3nvKEU5 H2TeuKSNP03m41L3Mb1lp+PrUwJfVNFynnTrnaTGu2hvkVLJzeJMv2q4ak8AHWXCYid6 Soshfdw4gGGdrbNcwN8p08KQ25FQ6E3bET9rqHYItl1N3y+LI1odM/49RIoDs8yTkoMv IwBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788512469; x=1789117269; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XfbM+zSlZv8MMTw8htQZYg+PCfRFWtMlG3dHQRCYpuc=; b=ktNbKEx94g0DuUVQcNph2Xc0Tc7YO8jrXRtlKkOAPDWST6LJ5jMSDgFWgxwpYlWVjm vgziPXFLK6OGZVG1x0ihYbmyyPzmTIsaS9WSjHJ4eXLTcFl7U/6RCKGrqGdRtL3+PKUA /JzD2atHHCLrnLaOyiLPqLqLNOGFK22InOVuT8sUP96xNdugHhYzkdM0dnLR4fklc+PY o+q9MJe/nrLc/jpb5+4VtBXvspJPVe7GTuRf2xLXzrnc+6e04+zndEFZbk/SKBZSxWwK LC+FeY/UlTT2f31a1FcqKXTZMmWqjLHY/6woNpKrbqGXWp4qDVTEJPDlPCvH5lzF44bB 3OzQ== X-Forwarded-Encrypted: i=1; AKwUvBwYBySSvdLS4vosMh+UR8LyXFI740Z/x1CLb1eR3MHylwEezmnMKLB9z/a8mmM0uQqCoXCulnLDMPMwZEQ=@vger.kernel.org X-Gm-Message-State: AFuF++kBwhNMS3YLlHlRS9B5B0GWC3e4R7e4TotiaPOnRApeEjhNSo3o 9CAWg3XNJdhONe5mKPScxYgOEayOwhQFqyqnclqI2og4XqOkh40Jkhna1mIVpkwIXOpZSTrVoU3 OS/I5Ae9xBzN++pEofrRNOlm55aVpXkFY5lg5N5mxJMu+ZtA+1ZZc549W6u/ys6im8eY= X-Gm-Gg: AYBFou2thCpQ02wzo2mxZRJwbvU1kDIohEu2srap37OlWlKwu8wzoTPYn1UrkJzZwxd HX1Peae4zZjqchzYgW091u4yFB/FKcTj5z11jZUS/uUTG/3j7p/dhwYuZU/tuwkMIZEdwsmWYYr R1KzOcpN0C9STxa3z52jVzFF0Lj4z6TwV69/3It/2WNlcytCZ23R/UAgevIRm1oWsI1dsaG8RwF qhJ/CzGvXdiHfsJgYbWYanT+wb5Fzot8dm++kVMiOROlUiOx5Panna+H8P15MfyvZ0UpDEx1XEr oz59bSj9A5kFl6TNtVBj3ERZsl4p75KKIXUwJqQKpsiZvz2209p5UiPXbtclGwNt1PklvYMWjO4 bk4qZke4iITDZGvkNWUmF3g== X-Received: by 2002:a05:620a:1b81:b0:939:2c96:1551 with SMTP id af79cd13be357-9398055cc61mr341377285a.1.1788512469157; Fri, 04 Sep 2026 02:01:09 -0700 (PDT) X-Received: by 2002:a05:620a:1b81:b0:939:2c96:1551 with SMTP id af79cd13be357-9398055cc61mr341372085a.1.1788512468661; Fri, 04 Sep 2026 02:01:08 -0700 (PDT) Received: from [192.168.202.12] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c260d5773c5sm76155866b.40.2026.09.04.02.01.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Sep 2026 02:01:07 -0700 (PDT) Message-ID: Date: Fri, 4 Sep 2026 11:01:05 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/9] soc: qcom: geni-se: Add helper to set SE clock rate via OPP To: Praveen Talari , Sudeep Holla , Cristian Marussi , Ulf Hansson , Bjorn Andersson , Konrad Dybcio , Greg Kroah-Hartman , Jiri Slaby , Mark Brown , Viken Dadhaniya , Andi Shyti Cc: mukesh.savaliya@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, linux-spi@vger.kernel.org, linux-i2c@vger.kernel.org References: <20260827-derive_clk_perf_tbl_from_perf_domain_opp_table-v2-0-091697dbeb02@oss.qualcomm.com> <20260827-derive_clk_perf_tbl_from_perf_domain_opp_table-v2-3-091697dbeb02@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260827-derive_clk_perf_tbl_from_perf_domain_opp_table-v2-3-091697dbeb02@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=YtA/gYYX c=1 sm=1 tr=0 ts=6a9a88d5 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=9aiwZt7zaXvVnErAyWsA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-ORIG-GUID: Ieu1MDJIXXONdiCaiucPxfM3DJngR5X8 X-Proofpoint-GUID: Ieu1MDJIXXONdiCaiucPxfM3DJngR5X8 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA0MDA4MSBTYWx0ZWRfX5istIM8Cnvqi gN6d0XgRa5xcC4wcqmq0luwLfXLKTPvp3P1v9Tsp4L2Y+bTI7qxdaGmUbyGU3FfWQL/xn1M3UGU KvewY1BMmoS/bWKtEPptpf7XBPr4hrc= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA0MDA4MSBTYWx0ZWRfX2WutnluXHZPt XjQ6FL5kVo5xFH5SB6//1m1We4qw3Ej3bQ1Y+TkvKoBvMQJ/NL/YyBZzWOr48xLS+ivEcqAxmHj /jaPvjRBl9T0pCBjeyaYIrSQiK1s+O0jSk18Mew2/o+d1coKzYGEIMj0Q0Jnj2AFhTj5Fwk5Fr+ /BWYLTg7EX8ztn5YmbdS6FsFY+8sUJSEasOnR/IcoJuBS70QxOJ7vzZQMBmfbg3/4QsxjTKk7YZ 0NMNVy5Y/i9OI1v6US5dsTyr5F8sOwwUzY40FrmqzZ0/GYem3ea6ofG9hM07+8d0eGIo3Kc2HTd y4rpit4oJOm+NZSpO1bIV5K6On+Jy3hrgsV8jKmzxMmQ6BN3zA6UoyAvYHYEpmTGOi91gBuRpcQ BJl8yNPUpd5cwpwroYzP9AVhAVax28enJYhZR4s+N9dEY7W1nBOT56P85TUqf8i8wA6UVKiR7zC JeebKJOoMVnI6VXO5tw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-04_02,2026-09-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 malwarescore=0 impostorscore=0 phishscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609040081 On 8/27/26 7:59 PM, Praveen Talari wrote: > GENI protocol drivers need a common way to scale the SE source clock > through the OPP framework. However, the device that owns the OPP table > differs depending on how the SE resources are managed. For Linux clock > managed platforms, the OPP table is associated with the SE device, > whereas on firmware-managed platforms it is associated with the > performance power-domain device. This requires protocol drivers to be > aware of the underlying resource management model when requesting > frequency changes. [...] > +int geni_se_set_rate(struct geni_se *se, unsigned long freq) > +{ > + struct device *perf_dev = se->dev; > + > + if (se->pd_list && se->pd_list->pd_devs[DOMAIN_IDX_PERF]) > + perf_dev = se->pd_list->pd_devs[DOMAIN_IDX_PERF]; > + > + return se->has_opp ? dev_pm_opp_set_rate(perf_dev, freq) : 0; For !se->has_opp, this silently does nothing, which presumably may have bad consequences if the caller is unaware Konrad