From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: korryasdlerto@gmail.com, Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Abel Vesa <abelvesa@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Kees Cook <kees@kernel.org>,
Tony Luck <tony.luck@intel.com>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: sm7325: Add Samsung Galaxy M52 5G
Date: Thu, 5 Nov 2026 09:09:57 +0100 [thread overview]
Message-ID: <b2498fed-5420-44a3-a215-02438b623ef6@oss.qualcomm.com> (raw)
In-Reply-To: <20261104-m52xq-dts-v1-2-b198f02912ff@gmail.com>
On 11/4/26 7:59 PM, Asdlerto Korry via B4 Relay wrote:
> From: Asdlerto Korry <korryasdlerto@gmail.com>
>
> Add the device tree for the Samsung Galaxy M52 5G (samsung,m52xq)
> smartphone, which is based on the SM7325 SoC.
[...]
> + chosen {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + framebuffer0: framebuffer@e1000000 {
> + compatible = "simple-framebuffer";
> + reg = <0x0 0xe1000000 0x0 (1080 * 2400 * 4)>;
Drop the reg and unit address (numbers after the @ sign), since you
have a memory-region handle
[...]
> + /* NFC chip power, switched by TLMM 42 (no consumer property in the binding) */
Please fix the binding
[...]
> +&usb_1 {
> + dr_mode = "peripheral";
> + maximum-speed = "high-speed";
> + phys = <&usb_1_hsphy>;
> + phy-names = "usb2-phy";
> + qcom,select-utmi-as-pipe-clk;
> +
> + status = "okay";
> +};
No superspeed / displayport?
Konrad
next prev parent reply other threads:[~2026-11-05 8:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 18:59 [PATCH 0/2] arm64: dts: qcom: " Asdlerto Korry via B4 Relay
2026-11-04 18:59 ` [PATCH 1/2] dt-bindings: arm: " Asdlerto Korry via B4 Relay
2026-11-04 18:59 ` [PATCH 2/2] arm64: dts: qcom: sm7325: " Asdlerto Korry via B4 Relay
2026-11-05 8:09 ` Konrad Dybcio [this message]
2026-11-05 11:11 ` Asdlerto Korry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2498fed-5420-44a3-a215-02438b623ef6@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gpiccoli@igalia.com \
--cc=kees@kernel.org \
--cc=konradybcio@kernel.org \
--cc=korryasdlerto@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®