From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58D09C433E1 for ; Fri, 21 Aug 2020 14:43:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2FD922078B for ; Fri, 21 Aug 2020 14:43:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RDvtAUTu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727914AbgHUOnZ (ORCPT ); Fri, 21 Aug 2020 10:43:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726118AbgHUOnY (ORCPT ); Fri, 21 Aug 2020 10:43:24 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0A2EC061573; Fri, 21 Aug 2020 07:43:23 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id y6so968040plt.3; Fri, 21 Aug 2020 07:43:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=KxSiaalwJaME4ZfRAha7YffGpv+JyYBz2E05xYHBT9o=; b=RDvtAUTu0zgMV7yaQDSc9aYO/XI5MPDNeFekaOswDUpcu94OPV5HdA0a54YLa2yA7L AL0GDo8vxaDZK9LXJ2179GGJHLSA+j3VQLOwzwf15/ZaZHncVvImEdpjrRIe3bfsefor GfzvK10EgBFAt6ZZaTpgtx4CQKjkghmQ38XIhN4I/F1bozSWtTJSKc1V1FPrSCe9Yc+1 OBGlVWBAdX37jy3efbhRvs7rmaKNZNS36HoT6j2UfD2AhiOhfngZVXjxFwVU/ciblhFS FW92LJrc4Z8Lmw1pcUlHM9eLuE4kHoHG8jwozUNPHRPlkEIT/V7vJVF3R5DNaMRU0tfh 4mYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KxSiaalwJaME4ZfRAha7YffGpv+JyYBz2E05xYHBT9o=; b=PvGnpLOu6Ugh4ToaN9MO2SIggFI4mykgxq7+ZD6/D7UaKJ6izw0v6WexWh/JON5Tue 2oRNlBFxPT4gEmh+y7Rl10gycyd9tXtMqevaKZiRaUOCZpBOTWJv+E7mK3ebZI6nji8I cyhR+8zhTM5Mz6ejvZrjK7e5mtnP9k9fjcQNSgu3outtw6WbuEvaFFa842tJSRntJVGC 9T0HTw9eEcJUE/1w3Of/nHGN1KrYUeRbkMl4cRDA5NMwST82FgmG/J3GbnGIzjfVm+bX hBIdoaaxZFaJ80LDrxVwpoWYvbLzryXFEzhmoRCQmkB+0pDgQaf+Knozadz6P93sCBR5 rK5A== X-Gm-Message-State: AOAM530grrcXTqEdhESSyqkcetF1yjFA3qPnkcWNAXL3lUoS70oas0/I nL9+00oxP0LsBz4xB6ZrtoZZYoDQMfg= X-Google-Smtp-Source: ABdhPJxgldVhE1PcofC9mYkwJyVlEM4WbizC8HPHrqcEoChF65VDb1ZOAavOBDNY96gC3+eObka9Lg== X-Received: by 2002:a17:902:221:: with SMTP id 30mr2674485plc.222.1598021002532; Fri, 21 Aug 2020 07:43:22 -0700 (PDT) Received: from [192.168.1.3] (ip68-111-84-250.oc.oc.cox.net. [68.111.84.250]) by smtp.gmail.com with ESMTPSA id n26sm2795181pff.30.2020.08.21.07.43.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Aug 2020 07:43:21 -0700 (PDT) Subject: Re: [PATCH] net: dsa: b53: check for timeout To: trix@redhat.com, andrew@lunn.ch, vivien.didelot@gmail.com, davem@davemloft.net, kuba@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200821135600.18017-1-trix@redhat.com> From: Florian Fainelli Message-ID: Date: Fri, 21 Aug 2020 07:43:20 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.1.1 MIME-Version: 1.0 In-Reply-To: <20200821135600.18017-1-trix@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/21/2020 6:56 AM, trix@redhat.com wrote: > From: Tom Rix > > clang static analysis reports this problem > > b53_common.c:1583:13: warning: The left expression of the compound > assignment is an uninitialized value. The computed value will > also be garbage > ent.port &= ~BIT(port); > ~~~~~~~~ ^ > > ent is set by a successful call to b53_arl_read(). Unsuccessful > calls are caught by an switch statement handling specific returns. > b32_arl_read() calls b53_arl_op_wait() which fails with the > unhandled -ETIMEDOUT. > > So add -ETIMEDOUT to the switch statement. Because > b53_arl_op_wait() already prints out a message, do not add another > one. > > Fixes: 1da6df85c6fb ("net: dsa: b53: Implement ARL add/del/dump operations") For future submissions: no need for a newline between your tags here, the Fixes tag is just a regular tag in the commit message. > > Signed-off-by: Tom Rix Acked-by: Florian Fainelli -- Florian