From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62BE431BCB6 for ; Fri, 14 Nov 2025 13:40:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763127635; cv=none; b=GnT94UiYW5rCtpcDyPGON57gNMoNGmHChkHH0jCQ3YwQrUIJaL1TYe3lAtI8tJLKJSDspAsMm0gjC8fm4rvM9y9KKu/vNe4AZIDL+cK8y7C2u6OXhLAD0PC2/8GM5RLMNWZ5d7JqEFiVGFhC4xiUaQAEO/tRScqEFd2gcy4pyr0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763127635; c=relaxed/simple; bh=5A6JdhBRmv6MbsALQsZRtyY2qGt4NnOfRC53jAZgmFY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QgORJTEidKvZah208ZcHm2GE3sAI1/I1IJYfIU33LDw7xXJtnZGrcrDwA3SPuG787yrpgC5nbkEJhfeLUUBDjde3kWV5UIEtAakhRk0j0ZhKEnwthhKvmuH4nnADd15WcVWmJT/o4aWQ3GxbL4zm+apkomQWY+2mRLNJt/QQNp0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Px8eC1GN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fpF5mLJC; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Px8eC1GN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fpF5mLJC" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AE89ltq1629469 for ; Fri, 14 Nov 2025 13:40:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 8h49vkr88QSRBl9WHezGJ3lwgPLQouFMI9a6UN+Msr4=; b=Px8eC1GNB+h53rBi AHLdNzs9wzRong0sgZpOFxhmv8tOx2bGXzY6g48J0V4yTldUCYZ7HvhWIRLCc9/B dZzQe7rWq7T2rFNrpB3t6A9i90zdUJlTL7DKJOiP+vqlA7esjgnN/nFesuwUKIHJ tEOuzegbRECPDxnDtJGKWVZP1UrJWDrS2L5CD61BnK786Q73j8o4b3hbVuaOvTfW CRSvt4IGa9v0jLQV7SqS57w2+vYNZO9F80COknejBqcHUA5cYcxtySm8Sb63Ooql jfuiNrza+y/oPuqr2RI/qTJv1fGGzVgqOw3ds9K7FsC8QIujV+WaUzU0QolzpS8P M3bS9w== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4adr9daatg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 14 Nov 2025 13:40:33 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-7a26485fc5dso2082900b3a.1 for ; Fri, 14 Nov 2025 05:40:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763127633; x=1763732433; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8h49vkr88QSRBl9WHezGJ3lwgPLQouFMI9a6UN+Msr4=; b=fpF5mLJC7wXF1HJYs1njWkIFyqETCdgArEkaTO8+rbQmIQBRu3SCTYBrO3Jo1hNA2B IHJbSNM9fPugmi+Z+8517eLXQH99vUIGnCgT5otv3hJ7Y9Ag2t+uohDVolYBks9Vqwxt 7p1cTUvj25Db+tiBAW1p8Ns7gJxtZTmfJBZOiW682FLlI36EjQ+7x4Wdp1d0+KYj/CkV XOUNjzCpdWuP6sfj9uxgMZ/phVeZp09juHoagKqtT53yuCKlGF6by542TvzaEn013+sz jPS9FtyacAuEVXCxsSNtRYN98K4uJZ8KxxNl49ykyaR7vZHe8sSXNZvvAyOJRW+zfaV2 1z2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763127633; x=1763732433; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8h49vkr88QSRBl9WHezGJ3lwgPLQouFMI9a6UN+Msr4=; b=ttOZrbvR0X6IpcX1OqtS6C8wWr5VuytiUcQI6Zrcn8SVYMKgggw+gbxv58ZFBz0LRF /bg2nXGfRdNAK6bcIbaV9Eo6bCaOCcFUVsyX+rGFxlWQSJdBhRwadUoSuOTc7abQibCi DJye6l8Wc61v1P8DzUlNOGYQMg5XdW78KWxBEtocqtG8ObS5Z7IYaf+CepzJWuEpuE5i kT+OEiyRAtQFvq+kJ/oGZDgf/vZetmLsHeygkbEwor84A3mwrvL4DRBkGtl9WBXJPUb7 spyvJQA+KvY9iYsNSX4RLjINHT5aPyHwcnzCZgEPw8Auceeq+7AobQI/E+cDT/mXG2Le 3k3w== X-Forwarded-Encrypted: i=1; AJvYcCVZgXV5tD5OblrybbJSInMxa5Xz08IYdjftZiIisbTASVJPiuCrqhuvmcPcIQwzTru3fVj+DHeXbPvFwDs=@vger.kernel.org X-Gm-Message-State: AOJu0YyyXl21lTdYxlv8zX1kgvg0CXEk+rXvLwnK/ol/WSR6q1l//LiR HVcoZ3BcKCmeeVN39I6LUG/2wKvyRo2KgiSMgLb9dm8h4+DFZKjs0Y8Iyml7kqVNOC09vazews2 HI2n1YJw0O7Z9+n522SUrkz+7dE57xz6U0J6Re1bAdDmFBorlyAMPGFg7LWIzKhH18eU= X-Gm-Gg: ASbGncvQXhOH32RkrBSH2rEx7ZJFXLJdrSOWdBq+K4gw0XPHszbAzDBlg/TDiGOs012 vjwQovHVX32GvXp5K7WD/NNDRwG/g8w6YXaBazOyHRIDJTM6GgGYu8yD7Oq8Fqv9w3GAFs4MvEU CACGI/yZuK3OgjCyoYlcgoELwGw1ksog//aN5Uw6oGm0+nEJyb3DcJ5rJk/dp3p+xPfT7HDugnO pVt+XmPt0mcK+jSDboJBVKdhfUyYX7i0fS68bfV/RiL/5Yn3I1NZ0UqMGKB43h/y7MxLGftk99Z YL+wMCqJzh1edIr+THQbZH5kcjbsnwFFw0dDS+IZgzuaNaCfQfDj+40BK99DXzD5uRTJFsDedsl V50zniFkIpMuKFCZPkvoByj9Mlg3lSEJ0twqOcj2S9uYbefB/dor1Av/Ptrwx9T2Tim86OaNrVR cjZxgs X-Received: by 2002:a05:6a00:4b12:b0:780:ed4f:e191 with SMTP id d2e1a72fcca58-7ba3c479c6cmr3119083b3a.23.1763127632767; Fri, 14 Nov 2025 05:40:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IGU919LE5QV0HkXIS1uAsaA3rGe0/n1O0dclAyr16aS8Fl3W3rmFXwCmYqvA/A5OkK9XfJp6Q== X-Received: by 2002:a05:6a00:4b12:b0:780:ed4f:e191 with SMTP id d2e1a72fcca58-7ba3c479c6cmr3119053b3a.23.1763127632266; Fri, 14 Nov 2025 05:40:32 -0800 (PST) Received: from [10.133.33.68] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7b9256b8824sm5284823b3a.31.2025.11.14.05.40.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Nov 2025 05:40:31 -0800 (PST) Message-ID: Date: Fri, 14 Nov 2025 21:40:24 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] rpmsg: char: Remove put_device() in rpmsg_eptdev_add() To: Dawei Li , andersson@kernel.org, mathieu.poirier@linaro.org Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, set_pte_at@outlook.com, stable@vger.kernel.org, zhongqiu.han@oss.qualcomm.com References: <20251113153909.3789-1-dawei.li@linux.dev> <20251113153909.3789-2-dawei.li@linux.dev> Content-Language: en-US From: Zhongqiu Han In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: cyIDLSM-RojvBC_8LJFykJ6mdNoPb4qw X-Authority-Analysis: v=2.4 cv=Rdidyltv c=1 sm=1 tr=0 ts=69173151 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=sFvjiMhPOwDUbjvKCIEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-ORIG-GUID: cyIDLSM-RojvBC_8LJFykJ6mdNoPb4qw X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTE0MDEwOSBTYWx0ZWRfX2+m0aom3uURl PP3jmwVzi2oM9wqT7RfJTqOGB+e+ND8hkuPfhSBrEPWJ2duV7JTAkj5yq1Q5cC86PC5u8SqjcKM OCjzlKZvRZ8CEnf0JYGkbY+msOJetQ2RvOAi/vHuVBAnYPgB6PBVJCfDgigSdlicNKN+b3bjKst RH6hq01k8UXYTDmPfWCaDlg/VOwaLBPZpNFr2yOA/7jd/lRvDclx0Op4nKXu3PP0sYTpFljAt+1 7b9UpAw38NDmlxkOei38dq2mC9tiZdE0mZ/hTx4C2GXvByV6khPFg5x/y6OVIiHRGCEVADhJBsI d5/xBPCxvHhlAEfGKsoTys8LBllb8arSVFChfmEpYOi2gUVhpFGmHOlGbloV5V3+OfB3r/XAL9z L8njGCVjZrAR0DcOkdOIvjWg5rz7Eg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-14_04,2025-11-13_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 adultscore=0 impostorscore=0 bulkscore=0 spamscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511140109 On 11/14/2025 5:53 PM, Zhongqiu Han wrote: > On 11/13/2025 11:39 PM, Dawei Li wrote: >> put_device() is called on error path of rpmsg_eptdev_add() to cleanup >> resource attached to eptdev->dev, unfortunately it's bogus cause >> dev->release() is not set yet. >> >> When a struct device instance is destroyed, driver core framework checks >> the possible release() callback from candidates below: >> - struct device::release() >> - dev->type->release() >> - dev->class->dev_release() >> >> Rpmsg eptdev owns none of them so WARN() will complaint the absence of >> release(): > > Hi Dawei, > > >> >> [  159.112182] ------------[ cut here ]------------ >> [  159.112188] Device '(null)' does not have a release() function, it >> is broken and must be fixed. See Documentation/core-api/kobject.rst. >> [  159.112205] WARNING: CPU: 2 PID: 1975 at drivers/base/core.c:2567 >> device_release+0x7a/0x90 >> > > > Although my local checkpatch.pl didn’t complain about this log line > exceeding 75 characters, could we simplify it or just provide a summary > instead? > > >> Fixes: c0cdc19f84a4 ("rpmsg: Driver for user space endpoint interface") >> Cc: stable@vger.kernel.org >> Signed-off-by: Dawei Li >> --- >>   drivers/rpmsg/rpmsg_char.c | 1 - >>   1 file changed, 1 deletion(-) >> >> diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c >> index 34b35ea74aab..1b8297b373f0 100644 >> --- a/drivers/rpmsg/rpmsg_char.c >> +++ b/drivers/rpmsg/rpmsg_char.c >> @@ -494,7 +494,6 @@ static int rpmsg_eptdev_add(struct rpmsg_eptdev >> *eptdev, >>       if (cdev) >>           ida_free(&rpmsg_minor_ida, MINOR(dev->devt)); >>   free_eptdev: >> -    put_device(dev); > > > Yes, remove put_device can solve the warning issue, however it would > introduce one memleak issue of kobj->name. > > https://git.kernel.org/pub/scm/linux/kernel/git/remoteproc/linux.git/ > tree/drivers/rpmsg/rpmsg_char.c#n381 > The above link I arised was wrong; it’s now updated to the correct one. https://git.kernel.org/pub/scm/linux/kernel/git/remoteproc/linux.git/tree/drivers/rpmsg/rpmsg_char.c?h=for-next#n476 > dev_set_name(dev, "rpmsg%d", ret); is already called, it depends on > put_device to free memory, right? > > >>       kfree(eptdev); >>       return ret; > > -- Thx and BRs, Zhongqiu Han