From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932182AbcIJJg5 (ORCPT ); Sat, 10 Sep 2016 05:36:57 -0400 Received: from mout.web.de ([212.227.17.11]:49529 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751962AbcIJJgy (ORCPT ); Sat, 10 Sep 2016 05:36:54 -0400 Subject: [PATCH 2/30] ACPI-processor: Improve two size determinations in acpi_processor_get_performance_states() To: linux-acpi@vger.kernel.org, Len Brown , "Rafael J. Wysocki" References: Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini From: SF Markus Elfring Message-ID: Date: Sat, 10 Sep 2016 11:36:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:sDqXi4+7GGILRIJi/u7ubiXLOzLtSAgl3CGzg4zGOXihQvj8poK 65t0DHubwsL9wRwRmygUvjcTfu22l2gcgPE1x+YFoWQCTAndWLxjkdguDR+0WEuJr3iRGDg GJLH8M6BDelv0LKO5aJfAhMhkXOu5zvhYJxpAbUPtd2SEyaQMdeBLVbtitB+sVF83YGKNQD W8KZuiUGi6f6Oi5dJcixg== X-UI-Out-Filterresults: notjunk:1;V01:K0:EnNs0MzUiCY=:ZdNlZplaPRkSSHmDemNCgQ FNF/gQ0Me2A6FGPRb8lg5wygehu5Uj0prQdeB+/Y7ntd5NEDQpKoqZ9AxkTn7jTvs/nwTLIBK 8YYaixiTOCcgmNw5FPOsd2JtVrhjwN6gZfYe6kSHJOlp/MryUeadtO7oAm4cwXmWJ4ZDZwB3z QMEx89lW5fRvyvaGfxMLa1ZS6gFkeyZXzl0GIxoBp0Q7u3Ut/8ldWn4AIr2HWKHDaNYk99AS3 Cf05TXywXuWwlJVqr8xdtfq1MWaFAUKbYpgoEaFSwsJA9RaTEZr2rdMjsI4MD5BRyd/DaXIN7 0qElaS3FtwctxuAc77ZlL/35B5aiMsYCsGXN2dhPqDXrqRhV4rmt6/4gb3ssG50SIEqWsnTzy 4kPEQUMc9EDuePgcjm5UQ2rvyLiAvWJyQUkfivnP+BF37tbF4B72BnWzcpfkBoBeLkof2SDq7 79BhZsh6mbOi11C6pxC70CX5rZtLYFekLNavCmM1W9+fv/TdSuhlJrUD/fNkHtMAZHgNWBEk5 YOeFea/50NGk7cOk437cjQIGxAtWJkrGyGZfYXWcUixZ4jtN68VJWBjrO3RAe/eXOgpJwA9CI BQ7wArJNuLdraf5tPmJGV96J7CG0JsQhwtzVy7e+yJILNR6z5DDcP7DnUS51yhFm9TtQGYHRG kp4E1FJ+722syu8F5862QaMRSdBLkJ3QEl1blUuYJoKVAPW+fqdoThob3JUoTHuh0UAVw/bM7 ADNHl9NLZoSoW9iWLEBVy/qYvUMhDxPZbTI/CWCFtaju6Z8Sbw42dRgHgk6oN8o0+vDWILZDU ep0N00V Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 6 Sep 2016 11:11:12 +0200 Replace the specification of a data structure by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/acpi/processor_perflib.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/processor_perflib.c b/drivers/acpi/processor_perflib.c index 78f9025..004e24c 100644 --- a/drivers/acpi/processor_perflib.c +++ b/drivers/acpi/processor_perflib.c @@ -358,7 +358,7 @@ static int acpi_processor_get_performance_states(struct acpi_processor *pr) struct acpi_processor_px *px = &(pr->performance->states[i]); - state.length = sizeof(struct acpi_processor_px); + state.length = sizeof(*px); state.pointer = px; ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Extracting state %d\n", i)); @@ -400,7 +400,8 @@ static int acpi_processor_get_performance_states(struct acpi_processor *pr) * Copy this valid entry over last_invalid entry */ memcpy(&(pr->performance->states[last_invalid]), - px, sizeof(struct acpi_processor_px)); + px, + sizeof(*px)); ++last_invalid; } } -- 2.10.0