From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753423Ab2BFRom (ORCPT ); Mon, 6 Feb 2012 12:44:42 -0500 Received: from stats.peacock.arvixe.com ([174.122.104.67]:44857 "EHLO peacock.arvixe.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751016Ab2BFRok (ORCPT ); Mon, 6 Feb 2012 12:44:40 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=firszt.eu; h=Message-ID:In-Reply-To:References:Date:Subject:From:To:Cc:User-Agent:MIME-Version:Content-Type:Content-Transfer-Encoding:X-Priority:Importance; b=njQPd4dRiWdmwGFnBXKWpU5U9YJOYDMeE6jp4PaPSuVrhD6pBQf4e7Wmopvwo4gWLeUUdc+kauVkw/V/sxn3WXu7HQ+0BdnHHupmzi0e3Kj/TxLxX6cBwPBqi/sKzqCE; Message-ID: In-Reply-To: <4F300F2C.9030308@goop.org> References: <1328481324-7241-1-git-send-email-przemo@firszt.eu> <4F300F2C.9030308@goop.org> Date: Mon, 6 Feb 2012 17:44:17 -0000 Subject: Re: [PATCH] HID: wacom: Fix invalid power_supply_powers calls From: przemo@firszt.eu To: "Jeremy Fitzhardinge" Cc: "Jiri Kosina" , "Przemo Firszt" , chris@cnpbagwell.com, pinglinux@gmail.com, linuxwacom-devel@lists.sourceforge.net, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: SquirrelMail/1.4.22 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Priority: 3 (Normal) Importance: Normal X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - peacock.arvixe.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - firszt.eu Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On 02/06/2012 04:42 AM, Jiri Kosina wrote: >> On Mon, 6 Feb 2012, przemo@firszt.eu wrote: >> >>>> Hmm, seems valid. How did you notice? Have you seen crashes because of >>>> wild pointers? >>> Hi Jiri, >>> Yes, the driver was unusable - 100% crashes during connection. >> Okay, I thought that'd be the case. > > Very sorry about that. I don't have a device to test with, so I should > have reviewed the code extra carefully. > > Does the same bug apply to the Wii changes, which were of the same form? > Hi Jeremy, The wii code looks the same, so probably it's affected as well. Can you make a patch? power_supply_powers call in wiimote driver: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=drivers/hid/hid-wiimote-core.c#l1229 regards, Przemo Firszt