From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B553279918 for ; Wed, 1 Oct 2025 08:39:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759307953; cv=none; b=dHd3z5G++xbRCHOn8glLE08PyZbju7B7IOQ1/MtblJxajE2P+ZJkaCPlrAKkwvswTYgNyQQ/PwEEiHvl3eSi10ji4NSO453t7LTx/PT4h2sD1rL/mfPSjKhP3TtR8gwUG82rUOk/VXMCiPJO/wrkm1rTUWjgn9P659+WtGVton0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759307953; c=relaxed/simple; bh=34z8TKBxNNfyGXYlesOl8gVHHvcdvVpRaMlcgy9wB3c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=acTxbB26nF7wZry/vZGAr/+bc3bHxzVDuv8uTyjKPUcQKneXI6Sf6OV07Xt9uZPa6PfFdVTBgu0Lif/csDpnEwDxVdxrra8sDuoVm5/VO2NJR9jskbOh8Z7uHP+ueQhmQ6q//AeZNS9d+lVBcusTO6FcILxoQ1EwLMaze1tvllY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=eHmDvwlh; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eHmDvwlh" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-3ecde0be34eso363670f8f.1 for ; Wed, 01 Oct 2025 01:39:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759307949; x=1759912749; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:reply-to:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=zCTgTfue23R4yaOrFb9ybWje80AchWn0YqIMIdLz6FE=; b=eHmDvwlhw2vzDQPZ+12heWy6ZXU8p9l60vfCBnxDw5mJO12AprOwF6zcMyniQD8wTk z2RxXM3r6Hqg64FC0CypxAPA4m4dJmKCLqaUGD142/qxk/Nj87CslTT5V432ckxG/y48 MjM8VwLezHujPsilUszZbNJtjjvex1oh25KTPc3xCPdK2rNVXTwuQU41GIu1LcNIVlvw fLExXiY+8Bqa2FLYk7it2qNcTDGTsFp9zgkZxjaVO10ECb5VSsFs9cfSn9nKPhNHRscc p7caW2FmF7oPqI6iOMnhbDmiqL7USTyrewVoHKtDkUeXHgLz8H3o8QXaDh3K9yg9RCU6 +rMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759307949; x=1759912749; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:reply-to:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=zCTgTfue23R4yaOrFb9ybWje80AchWn0YqIMIdLz6FE=; b=iEOMwQ9Ip7HCSD53aVtpUmzoTx9MUNIZw14f6DrnET7MLJanPW4I/b4mkQQ3C1dpgS cgbEcDcYuQzaLiaPeVbV0ryD/z0qsHTDe7XkpowEWibq0Dh/24k7ZyfEEaGX/ssSn7OZ ucnm1eW11m/CygMbl5T6oIjKcBUX7L9yFOGBH/2IXi1roz/oDEVF0s1HgugNnw2M24l2 1sx7d/f6ZcFmYXMNwsE49e3lfP3boB8hTju81tqrFS7fPHxHPrmzBr1J7TvwTN4iYMQx JzhGPOQ8sulNgAlNZWxrFhCRCneQior2QlVIeXQFwuwsUdWcEk4pMrWkYw7ayV6n1cxc BdzA== X-Forwarded-Encrypted: i=1; AJvYcCWylzfE18AsB4OXAH5b7LbPm8GhMKNdUHfkVRoRZxh5HseAEsuM2flOQAKs7+BQhOsDNBP7uhkhfX/+mJY=@vger.kernel.org X-Gm-Message-State: AOJu0Yya2QJiQSix0dtm73u8YHnuDOxC+fQG2IIsjzmqNTZecIsZTU6H Jwhgnpz01rFi6OV8JaZp5b8t1L+yyEJotF9ESBodEcu4qirQRd44bZ6+dy18V24eh9s= X-Gm-Gg: ASbGnctYuArXeM5af940Hx0e1YuIDRz6fV5UxJjcxyYsXVk7E5PCMm6ZaYYFaM5+6lg d5LqRFU8gekniWT023U0jwzdjij4pknurHXK910KbVnnfv/PhDs0MOlrlAWBSL/+W2sudMLFc3A rL9UQYyPeoMsCY79dnstqFf8ra6Kue2Xfkkx4TnZOaafHmDtYDarZUsifKpO0VVehcsXsKDDQOM yFvCPYYn89Sl/yup5QJbmmO2+zIByYVMDD3Icl+MxZdv+IFcc7oH8FiFEfCvEfb6KqOejVjDVVK BFjzqp8+g81Oh3cE5/n4hgMvWJfw6eTA8cgVnk0t4FdbM5Yw9rb7msqrl0E9D3u9aYoCCvBjgbl 2tcKbFXCa2KDiAKytNetr8ovzwkOrPjQQIRh+nDiRQ07ZcA3d6BwQfwfhkXBkNrE8WVgZMckboM DCDOFOPSPy1wmKd6CGDDIGlSg= X-Google-Smtp-Source: AGHT+IGm/mLJsRK7kBe5ekjqKSsxSCM8B9iiIVyHDmsGInuaLbxLzmbW+1QwwhIPIWQgKg9zYJRPzg== X-Received: by 2002:a05:6000:4013:b0:3fc:cbfc:fbee with SMTP id ffacd0b85a97d-4241111f7demr5393668f8f.19.1759307949119; Wed, 01 Oct 2025 01:39:09 -0700 (PDT) Received: from ?IPV6:2a01:e0a:3d9:2080:f45f:c590:9006:d394? ([2a01:e0a:3d9:2080:f45f:c590:9006:d394]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-40fc6de90desm26516197f8f.47.2025.10.01.01.39.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Oct 2025 01:39:08 -0700 (PDT) Message-ID: Date: Wed, 1 Oct 2025 10:39:08 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Neil Armstrong Subject: Re: [PATCH 0/2] Add support for QC08C format in iris driver To: Dikshita Agarwal , Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250919-video-iris-ubwc-enable-v1-0-000d11edafd8@oss.qualcomm.com> From: Neil Armstrong Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20250919-video-iris-ubwc-enable-v1-0-000d11edafd8@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 9/19/25 17:47, Dikshita Agarwal wrote: > Add support for the QC08C color format in both the encoder and decoder > paths of the iris driver. The changes include: > > - Adding QC08C format handling in the driver for both encoding and > decoding. > - Updating format enumeration to properly return supported formats. > - Ensuring the correct HFI format is set for firmware communication. > -Making all related changes required for seamless integration of QC08C > support. > > The changes have been validated using v4l2-ctl, compliance, and GStreamer (GST) tests. > Both GST and v4l2-ctl tests were performed using the NV12 format, as > these clients do not support the QCOM-specific QC08C format, and all > tests passed successfully. Sorry but this means you didn't test the full decoding and encoding with GST and v4l2-ctl using QC08C ? So how did you test ? Thanks, Neil > > During v4l2-ctl testing, a regression was observed when using the NV12 > color format after adding QC08C support. A fix for this regression has > also been posted [1]. > > [1]: https://lore.kernel.org/linux-media/20250918103235.4066441-1-dikshita.agarwal@oss.qualcomm.com/T/#u > > Signed-off-by: Dikshita Agarwal > --- > Dikshita Agarwal (2): > media: iris: Add support for QC08C format for decoder > media: iris: Add support for QC08C format for encoder > > drivers/media/platform/qcom/iris/iris_buffer.c | 17 ++++-- > .../platform/qcom/iris/iris_hfi_gen1_command.c | 15 ++++-- > .../platform/qcom/iris/iris_hfi_gen2_command.c | 21 +++++++- > .../platform/qcom/iris/iris_hfi_gen2_defines.h | 1 + > drivers/media/platform/qcom/iris/iris_instance.h | 7 ++- > .../media/platform/qcom/iris/iris_platform_gen2.c | 1 + > drivers/media/platform/qcom/iris/iris_utils.c | 3 +- > drivers/media/platform/qcom/iris/iris_vdec.c | 61 ++++++++++++++++++---- > drivers/media/platform/qcom/iris/iris_venc.c | 59 +++++++++++++++++---- > 9 files changed, 152 insertions(+), 33 deletions(-) > --- > base-commit: 40b7a19f321e65789612ebaca966472055dab48c > change-id: 20250918-video-iris-ubwc-enable-87eac6f41fa4 > > Best regards,