From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: ACJfBouEpLe2Z6ggRDuEUSAlveC2yYtZPnYuftZVtrmF9t5q3er880TWZ2XRs06bCf1DNA+8owl/ ARC-Seal: i=1; a=rsa-sha256; t=1516206463; cv=none; d=google.com; s=arc-20160816; b=RisHCKu2I8yiJSTC5oScwL41lDOsmd+hnUnOz+THpCcBAjWu/GnYmTor3Ndm3PdLB1 3xO+AV3yfdU85jSCHBk4ZB3gu8KPy6nSZGUasimjBv6UCzPexKgPq28pOcGhSwhedpjs kBU+06UkMzLkAP+vtqSb9KbM/gLKsETo1T3JdUUikHqGfrgcRsaLySAecdyC2xHxb94O DmrIdZ/yjccE8KC4gqVE/HK3cQ2boNFSAgESpFnU1mJefpf8Vc9j1JYLkGBFfuM/VL2T z4/IAD9rOy3E2/mleUuV/yrI+EWlqgTtf5GpIT2W4MkQdnqSYBzTafVU1tTYUupWG45l YhwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=TkLNH64Z9Kkt4QwdvMZukKpU7Lt8SEqmbIHE8UjTEc4=; b=VM7W7Tm1QClB14ThzIhla4nze993GtTYK1lw8hvUR0CfvFJYehiaqNPVpHWRgFWI9K F+OKg6w8KyvEjMofK88QBquIWdHPV3yOAXvIQRpsKLzOxjErWYojRYjqx2IlEg7fXyUB k/SuazU2398hWORvWfhW9aCzd+17p71KaeGK9CywNVs3OPrAba3fkqxCDOnKHI7QdwSN SlPmK2uFSMz8zf/JXeXWo7BrJI7o43ANMMvxtVMwnKZHH5jG7HIt/WFoOb68StsBH53K 11L4ZCFLQhFQDZH76AOSkm3Av1vZEukGbn6wfu+egwt/mGnjvVKGWdnqfTv/8/zxfK4o lIgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=T6PzH6XA; dkim=pass header.i=@codeaurora.org header.s=default header.b=T6PzH6XA; spf=pass (google.com: domain of okaya@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=okaya@codeaurora.org Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=T6PzH6XA; dkim=pass header.i=@codeaurora.org header.s=default header.b=T6PzH6XA; spf=pass (google.com: domain of okaya@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=okaya@codeaurora.org DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org CE10960115 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH v5 4/4] PCI/DPC: Enumerate the devices after DPC trigger event To: Oza Pawandeep , Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Keith Busch , Wei Zhang , Timur Tabi References: <1516185438-31556-1-git-send-email-poza@codeaurora.org> <1516185438-31556-5-git-send-email-poza@codeaurora.org> From: Sinan Kaya Message-ID: Date: Wed, 17 Jan 2018 11:27:39 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1516185438-31556-5-git-send-email-poza@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589835695085239135?= X-GMAIL-MSGID: =?utf-8?q?1589857708206769705?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 1/17/2018 5:37 AM, Oza Pawandeep wrote: > +static bool dpc_wait_link_active(struct pci_dev *pdev) > +{ I think you can also make this function common instead of making another copy here. Of course, this would be another patch. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.