From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBE9B22EE5 for ; Sat, 11 Jan 2025 04:17:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736569056; cv=none; b=CXOVbLQILx4YwzQKyscoyKSSSu051+JLMl3giBAjN6j+j7+rCaEdtlNHoeHwJWPAaH+vbDmmZdBvnRTkM17E1m0jKV/gL/vLlzGz+b/F2tjK1kFcnyYHNdHUuKhbL6cOrHSVUs/t0w7/Sb9MSxFeLg+vnluYs1m+oTkLoMoMlD0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736569056; c=relaxed/simple; bh=K7gRjzmtM/J7U7/lf6E/qQ9zy+evV0LUEE9IeCzR8A8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ase/6yYhGNe395g83+Ps2ndsqTOculVBnKKWq4/BhGLOKj7rtwJmJQ759R0O6RmatV7RmCp8WqqUldO/uQOxP/pRKWl/5gYrXOpJiysFPzNHHaWvVIFCETCRBhNNdYiwE5MmsDJMOri+Q72//mlbjEtP4aDqsG37bZFxzpDMGx0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tweaklogic.com; spf=pass smtp.mailfrom=tweaklogic.com; dkim=pass (2048-bit key) header.d=tweaklogic.com header.i=@tweaklogic.com header.b=UCVz/Tp7; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tweaklogic.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tweaklogic.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tweaklogic.com header.i=@tweaklogic.com header.b="UCVz/Tp7" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-21631789fcdso49495325ad.1 for ; Fri, 10 Jan 2025 20:17:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tweaklogic.com; s=google; t=1736569054; x=1737173854; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yrtUXt/u1nUbUgY5XqlvlTqRPS1ObOgO+r968EJV84o=; b=UCVz/Tp7Kg/uQHEHgSBRYjyVHR2evQKbOvAH4Qp58WNanicjPq22GLG6Pb+yg0DPks JgXOGOnkSxal0xIGfXMbkR+ns6k51xkU4wCbshqlQ2d/g9RG5IN16O8JW0HldGU9OJJh U7H7IY9zA/C/FY3b3vrOIL5LB0yhAjCJqB2vfwPqd4Dy1OZIVGK7J7GzJrgKlRcin5Ei hFbS/qcew5g1RlrQ7mzbMo6Ke/j8DVGE7HaBRoSw4qFKAP6GO7brOxo9CtjTPeAQ0jXe wO9y44UkCIExcAb7b99N9oWIeX80SCXpz3sOKB0l84N54ug4KkfhhDPcFkhJ42vnCWjg kgBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736569054; x=1737173854; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yrtUXt/u1nUbUgY5XqlvlTqRPS1ObOgO+r968EJV84o=; b=ftV2LQak3/p9p1ilcRAkt2dddcqeTxj4Dfn1i7XEPI2iMsCI8OhupzoB1ri9NTpRQL vcLTy9zDF9ZSXumpThYE7MS+T0UKPO2Ti5PG8yuTySCvMFIUUe13yKMlPC8mA+J3ZcHS 20ndzHFASF+gvQZFZsNGxoHetwxK2CVHCD0oT+FyrHXLN/apguQKb9gzyys5cTRAwoV1 GAxHrb8zocKgdzMwcJrR2VUsOYiWktYKPQDv4P2Xpm8rMVuZ9xTQ5ApmLjX7PfeQMVNK BLM7k8A1Ogj9FsO7zPRu0MfOSKOUON2AVkKoeYA3Bm1dXwJ1YwULlfENhPfbLsg4VbMf Y8VA== X-Forwarded-Encrypted: i=1; AJvYcCWhLT+Vwo+3U1A3VWUbtE48Ch77g4kgUeQcZZohClVk6J86uWBuuqOSgqoezGsZzTyl9kGr+Y3gnJSZJnw=@vger.kernel.org X-Gm-Message-State: AOJu0YwFHoQjSn5w68Hh7cz+Io4BIj+Azrtl4jsflzDsSUH31QJCLHOc KR2ChJ55LBYPdaTL/i54HGLHCb/oHFg8x8OGNOno540cS8yw8rF2VVT2P5TcUFTn5L0D7hX5HnS Q X-Gm-Gg: ASbGncvbLp6672YJ28w+uo1qYJq75nhI5W2LALGI7Sfu3oFmGSqv/VvS/XSZ2keObPd rZcjq69c2aLOqFmSMjbrhIT4wn2yBuZ2eMVaga5VLN+AUHcf6b8uw8sFLhgPf3SKRE0A8z2kMd5 ZLQC+KAtocheGkj26UptvfKcdIn0uuWeQzqeMnmKY9GcqjzUOY93T7yrWnZhy6Ow9lLdAou/pdh jCDl6ehHdtR86nIKYG8Spt8ZthHE6gauiyEHXIRbieVIHLOGqZHbk97OulWTqZZLGfOJrvkJzmY X-Google-Smtp-Source: AGHT+IGTv3Geg9Zg0MonI/5srbNCzhCmd4d6jcre+MPqD6TPKTLmRJHAo4NKsnVxDeGO7doERNefbQ== X-Received: by 2002:a05:6a00:4096:b0:725:cd8b:d798 with SMTP id d2e1a72fcca58-72d30393c81mr14194667b3a.9.1736569054104; Fri, 10 Jan 2025 20:17:34 -0800 (PST) Received: from [192.168.50.161] ([180.150.112.66]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72d405943c2sm2218746b3a.79.2025.01.10.20.17.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jan 2025 20:17:33 -0800 (PST) Message-ID: Date: Sat, 11 Jan 2025 14:47:28 +1030 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] iio: gts: Simplify available scale table build To: Matti Vaittinen , Jonathan Cameron Cc: Matti Vaittinen , Lars-Peter Clausen , Mudit Sharma , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241220192118.3e9ba7f9@jic23-huawei> <9c07b71a-160f-4336-8a8d-cad7003e4b68@gmail.com> Content-Language: en-US From: Subhajit Ghosh In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/1/25 00:56, Matti Vaittinen wrote: > On 22/12/2024 11:24, Matti Vaittinen wrote: >> On 20/12/2024 21:21, Jonathan Cameron wrote: >>> On Mon, 16 Dec 2024 10:56:37 +0200 >>> Matti Vaittinen wrote: >>> >>>> Make available scale building more clear. This hurts the performance >>>> quite a bit by looping throgh the scales many times instead of doing >>>> everything in one loop. It however simplifies logic by: >>>>   - decoupling the gain and scale allocations & computations >>>>   - keeping the temporary 'per_time_gains' table inside the >>>>     per_time_scales computation function. >>>>   - separating building the 'all scales' table in own function and doing >>>>     it based on the already computed per-time scales. >>>> >>>> Signed-off-by: Matti Vaittinen >>> Looks good to me, but I want to leave it on list a while before applying. >>> Ideal if it gets some tested-by or other tags before I pick it up. >>> As always, this is fiddly code, so the more eyes the better! >> >> Please, let it wait until the Christmas has passed. I got information we might be getting some testing before the year changes :) > > Well, the year changed and no tested-by tags emerged. I suppose my sources weren't right at this time. > > Yours, >     -- Matti Hi Matti, Hope you had a good Christmas and new year. After my US trip, it took me some time to come to terms that I have to work for a living! The code works fine. I tested it with apds9306 driver with stm32mp157-dk2 board. Tested-by: subhajit.ghosh@tweaklogic.com Just want to report something else which may not be related to this. When I tried to cross-compile with linux-gnueabi-gcc version 12.2.0 with Linux kernel 6.1.28, I got the following errors: CC [M] /home/subhajit/opensource_contributions/apds9306/apds9306_backport/./drivers/iio/industrialio-gts-helper.o /tmp/ccn9UpwF.s: Assembler messages: /tmp/ccn9UpwF.s:22: Error: junk at end of line, first unrecognized character is `I' ... ... I had to remove the double quotes from the macros for all symbol exports: EXPORT_SYMBOL_NS_GPL(iio_gts_total_gain_to_scale, "IIO_GTS_HELPER"); to EXPORT_SYMBOL_NS_GPL(iio_gts_total_gain_to_scale, IIO_GTS_HELPER); However the x86_64 native build of the mainline kernel 6.13.0-rc6 on my laptop went just fine with this patch. Regards, Subhajit Ghosh