From: Sylvain Petinot <sylvain.petinot@foss.st.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: <benjamin.mugnier@foss.st.com>, <mchehab@kernel.org>,
<robh@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<conor+dt@kernel.org>, <laurent.pinchart@ideasonboard.com>,
<linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <tomm.merciai@gmail.com>
Subject: Re: [PATCH v8 2/2] media: i2c: Add driver for ST VD56G3 camera sensor
Date: Mon, 5 May 2025 12:47:23 +0200 [thread overview]
Message-ID: <b25bf051-1459-4572-8d41-ebdf5fd7abf3@foss.st.com> (raw)
In-Reply-To: <aBhwIl7G60EJ9k9F@kekkonen.localdomain>
Hi Sakari,
Le 05/05/2025 à 10:00, Sakari Ailus a écrit :
> Hi Sylvain,
>
> Thanks for the update.
>
> On Fri, May 02, 2025 at 10:18:49PM +0200, Sylvain Petinot wrote:
>> +static int vd56g3_check_csi_conf(struct vd56g3 *sensor,
>> + struct fwnode_handle *endpoint)
>> +{
>> + struct v4l2_fwnode_endpoint ep = { .bus_type = V4L2_MBUS_CSI2_DPHY };
>> + u32 phy_data_lanes[VD56G3_MAX_CSI_DATA_LANES] = { ~0, ~0 };
>> + u8 n_lanes;
>> + u64 frequency;
>> + int p, l;
>
> unsigned int. There are more cases where you have a loop variable that
> doesn't need to be signed. Please address these in a follow-up patch.
>
Thanks for raising the point. I'll do that asap.
--
Sylvain
prev parent reply other threads:[~2025-05-05 11:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-02 20:18 [PATCH v8 0/2] media: " Sylvain Petinot
2025-05-02 20:18 ` [PATCH v8 1/2] media: dt-bindings: Add " Sylvain Petinot
2025-05-02 20:18 ` [PATCH v8 2/2] media: i2c: Add driver for " Sylvain Petinot
2025-05-05 8:00 ` Sakari Ailus
2025-05-05 10:47 ` Sylvain Petinot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b25bf051-1459-4572-8d41-ebdf5fd7abf3@foss.st.com \
--to=sylvain.petinot@foss.st.com \
--cc=benjamin.mugnier@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tomm.merciai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®