From: "Joonwoo Park" <joonwpark81@gmail.com>
To: "David Miller" <davem@davemloft.net>
Cc: w@1wt.eu, cfriesen@nortel.com, kaber@trash.net,
auke-jan.h.kok@intel.com, netdev@vger.kernel.org,
djohnson+linux-kernel@sw.starentnetworks.com,
linux-kernel@vger.kernel.org, e1000-devel@lists.sourceforge.net
Subject: Re: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode
Date: Tue, 13 Nov 2007 10:21:57 +0900 [thread overview]
Message-ID: <b25c3fa70711121721o32bcab0fldf64ff0434a44a3c@mail.gmail.com> (raw)
In-Reply-To: <20071112.154046.117031917.davem@davemloft.net>
2007/11/13, David Miller <davem@davemloft.net>:
> From: Willy Tarreau <w@1wt.eu>
> Date: Tue, 13 Nov 2007 00:32:57 +0100
>
> > At least, being able to disable the feature at module load time
> > would be acceptable. Many people who often need to sniff on decent
> > machines would always keep it disabled.
>
> I'm willing to accept the feature, in whatever form, as long
> as the performance issue is dealt with properly.
I agree with disabling the hw acceleration feature by manually would
be a non-negative solution.
IMO implementation in the ethtool seems better than module param.
As like Auke mentioned.
If you guys confirm it, I'll try it.
Thanks.
Joonwoo
next prev parent reply other threads:[~2007-11-13 1:22 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-11 0:51 Joonwoo Park
2007-11-12 17:12 ` Kok, Auke
2007-11-12 17:21 ` Patrick McHardy
2007-11-12 18:01 ` [E1000-devel] " Kok, Auke
2007-11-12 22:33 ` David Miller
2007-11-12 22:43 ` Chris Friesen
2007-11-12 22:54 ` Kok, Auke
2007-11-14 11:48 ` Benny Amorsen
2007-11-12 22:57 ` David Miller
2007-11-12 23:15 ` Willy Tarreau
2007-11-12 23:19 ` David Miller
2007-11-12 23:32 ` Willy Tarreau
2007-11-12 23:38 ` Kok, Auke
2007-11-12 23:40 ` David Miller
2007-11-13 1:21 ` Joonwoo Park [this message]
2007-11-13 10:21 ` Patrick McHardy
2007-11-13 11:09 ` Herbert Xu
2007-11-13 11:36 ` David Miller
2007-11-13 12:03 ` Herbert Xu
2007-11-13 12:06 ` David Miller
2007-11-13 12:16 ` Herbert Xu
2007-11-13 12:18 ` Patrick McHardy
2007-11-13 16:41 ` Kok, Auke
2007-11-13 17:26 ` Patrick McHardy
2007-11-13 17:30 ` Kok, Auke
2007-11-14 9:42 ` Patrick McHardy
2007-11-14 23:30 ` Kok, Auke
2007-11-13 19:59 ` Kok, Auke
2007-11-13 12:32 ` David Miller
2007-11-13 1:21 ` Joonwoo Park
2007-11-12 22:28 ` David Miller
2007-11-13 20:43 ` Stephen Hemminger
2007-11-14 4:47 Joonwoo Park
2007-11-14 5:12 ` Kok, Auke
2007-11-14 6:15 ` Joonwoo Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b25c3fa70711121721o32bcab0fldf64ff0434a44a3c@mail.gmail.com \
--to=joonwpark81@gmail.com \
--cc=auke-jan.h.kok@intel.com \
--cc=cfriesen@nortel.com \
--cc=davem@davemloft.net \
--cc=djohnson+linux-kernel@sw.starentnetworks.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®