From: "Joonwoo Park" <joonwpark81@gmail.com>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: netdev@vger.kernel.org, chas@cmf.nrl.navy.mil,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] atm/ambassador: kmalloc + memset conversion to kzalloc
Date: Mon, 26 Nov 2007 19:23:48 +0900 [thread overview]
Message-ID: <b25c3fa70711260223w5a15bb1bk4652b3ab8f05c40c@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.0.9999.0711260409110.551@localhost.localdomain>
2007/11/26, Robert P. J. Day <rpjday@crashcourse.ca>:
> i'm not sure the above is a safe thing to do, as you're zeroing that
> area, then making a function call and assuming, upon entry to the
> function call, that the caller has done the right thing. i don't see
> how you can count on that, depending on who else might want to call
> that routine and whether they get sloppy about it. unless you're
> prepared to guarantee that there will never be another call to
> setup_dev() from elsewhere.
>
Thanks for your response.
But setup_dev is static function and only amb_init calls it.
IMO it's safe.
Thanks.
Joonwoo
next prev parent reply other threads:[~2007-11-26 10:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-26 9:02 Joonwoo Park
2007-11-26 9:11 ` Robert P. J. Day
2007-11-26 10:23 ` Joonwoo Park [this message]
2007-11-26 10:29 ` Robert P. J. Day
2007-11-26 10:53 ` Joonwoo Park
2007-11-26 11:20 ` Robert P. J. Day
2007-11-27 14:40 ` chas williams - CONTRACTOR
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b25c3fa70711260223w5a15bb1bk4652b3ab8f05c40c@mail.gmail.com \
--to=joonwpark81@gmail.com \
--cc=chas@cmf.nrl.navy.mil \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®