mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Joonwoo Park" <joonwpark81@gmail.com>
To: "Stephen Hemminger" <shemminger@linux-foundation.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	jgarzik@pobox.com, baum@tehutinetworks.net, andy@greyhouse.net
Subject: Re: [RFC] net: napi fix
Date: Wed, 12 Dec 2007 15:05:26 +0900	[thread overview]
Message-ID: <b25c3fa70712112205l2e778bacx66470606272b199@mail.gmail.com> (raw)
In-Reply-To: <20071211214634.4dedb274@freepuppy.rosehill>

2007/12/12, Stephen Hemminger <shemminger@linux-foundation.org>:
> Isn't this a better fix for all drivers, rather than peppering every
> driver with the special case. This is how the logic worked up until
> 2.6.24.
>
>
> --- a/net/core/dev.c    2007-12-11 12:16:20.000000000 -0800
> +++ b/net/core/dev.c    2007-12-11 21:43:39.000000000 -0800
> @@ -2184,7 +2184,7 @@ static void net_rx_action(struct softirq
>
>                have = netpoll_poll_lock(n);
>
> -               weight = n->weight;
> +               weight = min(n->weight, budget);
>
>                /* This NAPI_STATE_SCHED test is for avoiding a race
>                 * with netpoll's poll_napi().  Only the entity which
>

Stephen,
Could you explain how it fix the problem?
IMHO I think your patch cannot solve the problem.
The drivers can call netif_rx_complete and net_rx_action can do
list_move_tail also.
Am I missing something?

Thanks
Joonwoo

  reply	other threads:[~2007-12-12  6:05 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-12  4:01 [PATCH 6/7] [NETDEV]: tehuti Fix possible causing oops of net_rx_action Joonwoo Park
2007-12-12  5:39 ` Stephen Hemminger
2007-12-12  5:46   ` [RFC] net: napi fix Stephen Hemminger
2007-12-12  6:05     ` Joonwoo Park [this message]
2007-12-12 15:22       ` David Miller
2007-12-12 15:21     ` David Miller
2007-12-12  5:48   ` [PATCH 6/7] [NETDEV]: tehuti Fix possible causing oops of net_rx_action Joonwoo Park
2007-12-12  5:53     ` Stephen Hemminger
2007-12-12 15:20   ` David Miller
2007-12-12 16:36     ` Stephen Hemminger
2007-12-12 15:18 ` David Miller
2007-12-13  7:07   ` Joonwoo Park
2007-12-12 17:29 [RFC] net: napi fix Andrew Gallatin
2007-12-12 17:38 ` David Miller
2007-12-12 17:40   ` Andrew Gallatin
2007-12-12 18:41   ` Kok, Auke
2007-12-13  7:41     ` Joonwoo Park
2007-12-13 14:13       ` Andrew Gallatin
2007-12-13 14:19         ` David Miller
2007-12-13 16:45           ` Kok, Auke
2007-12-13 18:22           ` Stephen Hemminger
2007-12-13 19:02             ` Andrew Gallatin
2007-12-13 19:09               ` David Miller
2007-12-13 19:35                 ` Stephen Hemminger
2007-12-13 20:38                   ` David Miller
2007-12-14  2:06         ` Joonwoo Park
2007-12-13 13:49     ` Jarek Poplawski
2007-12-13 13:50       ` David Miller
2007-12-13 14:14         ` Jarek Poplawski
2007-12-13 20:16         ` Jarek Poplawski
2007-12-13 20:37           ` David Miller
2007-12-13 20:41             ` Stephen Hemminger
2007-12-13 21:55               ` Jarek Poplawski
2007-12-13 22:28             ` Jarek Poplawski
2007-12-13 22:34               ` David Miller
2007-12-13 22:58                 ` Jarek Poplawski
2007-12-20  9:52   ` Robert Olsson
2007-12-20 11:22     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b25c3fa70712112205l2e778bacx66470606272b199@mail.gmail.com \
    --to=joonwpark81@gmail.com \
    --cc=andy@greyhouse.net \
    --cc=baum@tehutinetworks.net \
    --cc=davem@davemloft.net \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®