From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Ding, Shenghao" <shenghao-ding@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"perex@perex.cz" <perex@perex.cz>,
"tiwai@suse.com" <tiwai@suse.com>,
"13916275206@139.com" <13916275206@139.com>,
"Chawla, Mohit" <mohit.chawla@ti.com>,
"soyer@irl.hu" <soyer@irl.hu>,
"Huang, Jonathan" <jkhuang3@ti.com>,
"tiwai@suse.de" <tiwai@suse.de>,
"Djuandi, Peter" <pdjuandi@ti.com>,
"Agrawal, Manisha" <manisha.agrawal@ti.com>,
"Hari, Raj" <s-hari@ti.com>, "Yashar, Avi" <aviel@ti.com>,
"Nagalla, Hari" <hnagalla@ti.com>,
"Bajjuri, Praneeth" <praneeth@ti.com>,
"Baojun.Xu@fpt.com" <Baojun.Xu@fpt.com>,
Rob Herring <robh@kernel.org>
Subject: Re: [EXTERNAL] Re: [PATCH v7 4/4] ASoc: dt-bindings: PCM6240: Add initial DT binding
Date: Sun, 31 Mar 2024 21:42:25 +0200 [thread overview]
Message-ID: <b26314d1-a059-4fd8-b52a-1234606bb7e5@linaro.org> (raw)
In-Reply-To: <41797fe7d5bb41b4bdea4ee7f4957291@ti.com>
On 31/03/2024 15:20, Ding, Shenghao wrote:
> Hi Krzysztof
> Answer inline
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Sent: Sunday, March 31, 2024 4:15 PM
>> To: Ding, Shenghao <shenghao-ding@ti.com>; linux-kernel@vger.kernel.org
>> Cc: lgirdwood@gmail.com; broonie@kernel.org; robh+dt@kernel.org;
>> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; linux-
>> sound@vger.kernel.org; devicetree@vger.kernel.org; perex@perex.cz;
>> tiwai@suse.com; 13916275206@139.com; Chawla, Mohit
>> <mohit.chawla@ti.com>; soyer@irl.hu; Huang, Jonathan
>> <jkhuang3@ti.com>; tiwai@suse.de; Djuandi, Peter <pdjuandi@ti.com>;
>> Agrawal, Manisha <manisha.agrawal@ti.com>; Hari, Raj <s-hari@ti.com>;
>> Yashar, Avi <aviel@ti.com>; Nagalla, Hari <hnagalla@ti.com>; Bajjuri,
>> Praneeth <praneeth@ti.com>; Baojun.Xu@fpt.com; Rob Herring
>> <robh@kernel.org>
>> Subject: [EXTERNAL] Re: [PATCH v7 4/4] ASoc: dt-bindings: PCM6240: Add
>> initial DT binding
>>
> .............................
>>> - remove unneeded items and if branches.
>>> - Add missing compatible devices, such as adc6120, etc.
>>> - Add necessary people into the list for DTS review
>>> - correct misaligned.
>>> - simplify the compatibility
>>> - remove sound-name-prefix and revert back
>>> - Add review information
>>
>> All these changes in v7 and you still kept Rob's review? I think either review
>> was not given or your changelog is just incorrect.
> Since Rob's review, nothing changed in yaml. Even in this patch, only removed kcontrol interfaces
> in the code and added the mixer-test report in cover-letter as Mark suggested, which is no effect
> on yaml file.
Then for the future, please use some reasonable format of changelog, e.g.:
https://lore.kernel.org/all/20240210-topic-8280_pcie-v3-0-ee7af6f892a0@linaro.org/
Best regards,
Krzysztof
prev parent reply other threads:[~2024-03-31 19:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-31 2:18 [PATCH v7 0/4] mixer-test report Shenghao Ding
2024-03-31 2:18 ` [PATCH v7 1/4] ASoc: PCM6240: Create PCM6240 Family driver code Shenghao Ding
2024-03-31 2:18 ` [PATCH v7 2/4] ASoc: PCM6240: Create header file for " Shenghao Ding
2024-03-31 2:18 ` [PATCH v7 3/4] ASoc: PCM6240: Add compile item for PCM6240 Family driver Shenghao Ding
2024-04-02 14:35 ` Dan Carpenter
2024-03-31 2:18 ` [PATCH v7 4/4] ASoc: dt-bindings: PCM6240: Add initial DT binding Shenghao Ding
2024-03-31 8:15 ` Krzysztof Kozlowski
2024-03-31 13:20 ` [EXTERNAL] " Ding, Shenghao
2024-03-31 19:42 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b26314d1-a059-4fd8-b52a-1234606bb7e5@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=13916275206@139.com \
--cc=Baojun.Xu@fpt.com \
--cc=aviel@ti.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hnagalla@ti.com \
--cc=jkhuang3@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=manisha.agrawal@ti.com \
--cc=mohit.chawla@ti.com \
--cc=pdjuandi@ti.com \
--cc=perex@perex.cz \
--cc=praneeth@ti.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=s-hari@ti.com \
--cc=shenghao-ding@ti.com \
--cc=soyer@irl.hu \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®