From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756279AbdETTRM (ORCPT ); Sat, 20 May 2017 15:17:12 -0400 Received: from mout.web.de ([212.227.17.12]:50300 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752424AbdETTRL (ORCPT ); Sat, 20 May 2017 15:17:11 -0400 Subject: [PATCH 5/5] fsl_hypervisor: Delete error messages for failed memory allocations in ioctl_memcpy() From: SF Markus Elfring To: Arnd Bergmann , Jan Kara , Jesper Nilsson , Kumar Gala , Lorenzo Stoakes , Michal Hocko , Timur Tabi Cc: LKML , kernel-janitors@vger.kernel.org, Wolfram Sang References: <38a9b933-4cdc-53e7-0a4c-20f96c57648c@users.sourceforge.net> Message-ID: Date: Sat, 20 May 2017 21:16:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <38a9b933-4cdc-53e7-0a4c-20f96c57648c@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:pIIXX6XNaHpqDOTpBIxq4y49VbeRNeY2VyJWi251bbXnWHsGG6Z 5oiRBjMPGABFoiBl7hkiInfBzXmkVR1w4W8XHWvcuQ6XHqKwnFt02YxFelC9V+bnp6lkgDS V9KP+z4lfd18RDmVahSGdkjLH7ncXC3AhJEiLZ22sVFlXd96yNXm60/iTCS81PgU9bqDj+a 5PxcIneyrTDclQAf5uj2Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:DFMi8XwGH7k=:lWHXdYQniwCjSpP8xh2Xtq Dg1dG3k9Ap2S68HJdp1cZlryh7KotQDODbLGFunxVIyds24MS1mn9QYCYRSMlEtXJbk4B8KpV m5psYIU+lUxyPDu1J7mzET6mUju7fcuYgCIFU6xuen99dQh4pGkuMD3fJ0Qq4bXV6uzbGlaF4 P6oRy73SKwamTk+skAsn7vNvaATR4o6zBFLNpi8ZXNZok7NuSEeyRVuBW2qe68PU2QwB6zeSP AzABcI82Ez0z0Wg1EApiItUKrjVv1Ju5o/t2YLDhozT8JWd2UaPk8S05yMgpSZ79JZT5+vt8e 1EzPAODWsVm8pvdMUsPoMs49WWxuVNdtwdggBIYng+le2ViJ5fF+ir1+UwITcG1yiselltavU suxsdq70WTko2xbSsOUtYWFEkYRFJZeRc9/AWx4Jiczz0u00VNPA2JEaM5D2oB27g9sWEwH9f Fd6M7iKJvkIQ7reuo0OvtncemAuMtmHWzAVFPaXVus9szDa/ugiSbS6iP04k+z5jV0wkGK2WH q1eJ97xI0wfpj1vfSGka8RPKp6/jYIBsUbSjaNYtlkYnZt8Bj5TK7vph9AguHOgZoM4RFlT2h 859l7drb4H9cq+FmshGGccl07AYvsVI7xLOtPr57d3s8UQZP+Qnk6dRk2U8XOMjbQS1NZblyZ nUP9letgd5z8n/GxypGFGms2xxQ5qBnOqyPKdoWIsnHcdAaOuPEadaz1alajABhWq28YPwCCI hOilYnPbcnJyqfB/prsAXgMXDTfZI+bYQ7h+Cs3S0eeQVsZfnA+mIwSVTXp3hSsiogq86Ttaj WYId6nq Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 20 May 2017 20:27:23 +0200 Omit two extra messages for memory allocation failures in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/virt/fsl_hypervisor.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/virt/fsl_hypervisor.c b/drivers/virt/fsl_hypervisor.c index 4031632b8c9d..db07c76f1ff7 100644 --- a/drivers/virt/fsl_hypervisor.c +++ b/drivers/virt/fsl_hypervisor.c @@ -227,7 +227,5 @@ static long ioctl_memcpy(struct fsl_hv_ioctl_memcpy __user *p) - if (!pages) { - pr_debug("fsl-hv: could not allocate page list\n"); + if (!pages) return -ENOMEM; - } /* * sg_list is the list of fh_sg_list objects that we pass to the @@ -238,5 +236,4 @@ static long ioctl_memcpy(struct fsl_hv_ioctl_memcpy __user *p) if (!sg_list_unaligned) { - pr_debug("fsl-hv: could not allocate S/G list\n"); ret = -ENOMEM; goto exit; } -- 2.13.0