From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9954C7EE2C for ; Fri, 25 Aug 2023 06:14:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241593AbjHYGOB (ORCPT ); Fri, 25 Aug 2023 02:14:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241607AbjHYGNf (ORCPT ); Fri, 25 Aug 2023 02:13:35 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 353BB1FEC; Thu, 24 Aug 2023 23:12:58 -0700 (PDT) Received: from kwepemm600003.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4RX8g86vp7zJrr7; Fri, 25 Aug 2023 14:09:40 +0800 (CST) Received: from [10.67.111.205] (10.67.111.205) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Fri, 25 Aug 2023 14:12:47 +0800 Subject: Re: [PATCH v6 6/7] perf test: Add test case for record sideband events To: Ian Rogers CC: , , , , , , , , , , , , , , References: <20230821012734.18241-1-yangjihong1@huawei.com> <20230821012734.18241-7-yangjihong1@huawei.com> From: Yang Jihong Message-ID: Date: Fri, 25 Aug 2023 14:12:46 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.111.205] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On 2023/8/25 13:28, Ian Rogers wrote: > On Sun, Aug 20, 2023 at 6:30 PM Yang Jihong wrote: >> >> Add a new test case to record sideband events for all CPUs when tracing >> selected CPUs >> >> Test result: >> >> # ./perf test list 2>&1 | grep 'perf record sideband tests' >> 95: perf record sideband tests >> # ./perf test 95 >> 95: perf record sideband tests : Ok >> >> Signed-off-by: Yang Jihong >> Tested-by: Adrian Hunter >> --- >> tools/perf/tests/shell/record_sideband.sh | 44 +++++++++++++++++++++++ >> 1 file changed, 44 insertions(+) >> create mode 100755 tools/perf/tests/shell/record_sideband.sh >> >> diff --git a/tools/perf/tests/shell/record_sideband.sh b/tools/perf/tests/shell/record_sideband.sh >> new file mode 100755 >> index 000000000000..2ecf00011cb1 >> --- /dev/null >> +++ b/tools/perf/tests/shell/record_sideband.sh >> @@ -0,0 +1,44 @@ >> +#!/bin/sh >> +# perf record sideband tests >> +# SPDX-License-Identifier: GPL-2.0 >> + >> +set -e >> + >> +err=0 >> +perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX) > > Could you add some kind of cleanup on trap function like: > https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/tests/shell/record.sh?h=perf-tools-next#n26 > It'd be okay to do this as a follow up patch. > Okay, it'll be modified in the next version. Thanks, Yang