From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932272AbdJUUAi (ORCPT <rfc822;w@1wt.eu>);
        Sat, 21 Oct 2017 16:00:38 -0400
Received: from mout.web.de ([212.227.15.14]:57689 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932226AbdJUUAg (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 21 Oct 2017 16:00:36 -0400
Subject: Re: crypto-testmgr: Use common error handling code in
 drbg_cavs_test()
To: =?UTF-8?Q?Stephan_M=c3=bcller?= <smueller@chronox.de>,
        linux-crypto@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <7c2b4df8-a04b-cacd-13ba-4d9afb346263@users.sourceforge.net>
 <7aa0ec0b-c00e-44c0-1c07-6bd87e2b6c47@users.sourceforge.net>
 <6795494.nv2bFMflat@tauon.chronox.de>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <b270d9f1-a508-b5c1-8f53-260f4deb6fde@users.sourceforge.net>
Date: Sat, 21 Oct 2017 22:00:23 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <6795494.nv2bFMflat@tauon.chronox.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:+abg5sNf/YxPabmIL7r16w2eHJ+b3iUvnPGjYsNVbso5L/jGw+J
 WCuf91s4X7RaPLTszFUfKrp/JbWXSiHltSILQYDDQr+wQYWlFvhyOyBo1edMKUkccd6Kaam
 ZqXVMSv8bACVoDvqiQHv5S2pman0w/YYPxiCEkN5Ee+8RRCHIeyDYl0UZBY4o5zIi+oibxv
 N36IfdRw1p0trCEDii5kg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:GAlGw57QdxA=:evNEXrfv/1YWFzR2pfG6CW
 Vtvx94PME5IIqCF+s13KWkVDkLKWOUK7qRnxHuETjC4uD34iRzl9hjmIccKqxud9lIhSA5IiZ
 T7Fh2rvptdah2XFNeszMaxxSEhZCLkkZCAcgZLfZWJM2B+UB/eQEM8DEc85KUY7YNvDBNFvDN
 Ygx0Nl0cYpsWbx4dy4XhqV8+TvFqXFs15RTZdmpQjC1HWc7B4GGnIqDe6RvvC8pKHpkA+D4Ze
 /uc2EfMoHoyfyuVmcVQ1GFG9ckc18aP6M77Tlk8pt8AZ+s81DWtq1fNDvBy1YLHbhMhJI8vdt
 JwKXp2kSF3PDq81RKNB49mNhQKxv5cixOMBH4DU9Ozu01aVL3Sd93y9LbDTr0mVmCU6P7nOGs
 SpndTHXy4Bw6dbNsCRflrtTT4Pnc6A9RshrJ4hN+fhUkmr+P1nROArpG40X+lO2kyI5my5G5e
 eR4OJATHY9DlNWoO/DYnyWGJoL4yD3cY1pSgexE8u2Ngi1J/8pGcJ5KfBiB5PGrbF16uv0HbX
 F2cCK0MdgUOBEnuKqJJE67St+0YZhmZa7nFa0IpCFs7PTzKOCKAzphJItveYqeo8aWv7X+vPv
 9FYysFIjQeHDKjEdVxlnZfsd1zfyIv07fOQQ+Vrv63JDY9flKrdiwpZ46a7Yp5mCqdtrpC4He
 3IpBbkR1g8sGDReHGkWBhBr7jRApnrnpMe7xyEgNlG1Ky29hw358Q3m/n8hn8Fo64AjmGr2ly
 5EHJT41oQxX9A7j9frBvXvyL/ek38Ln0PgMGIQ+zfZTkBmwTRGiV4RH1uXBcC5kW0Pcy3HwIj
 XWBxt0B7xDQ1SodJd6HUMiibtkJlMcz9c5EAaFAJ+8qSYrv8J8=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Though, jumping back and forth like this with goto directives is something 
> that looks a bit strange. At least to my taste, may I suggest to have gotos 
> pointing only downwards and not up again? (Note, the same applies to the 
> ansi_cprng patch set).
> 
> What about something like following:
> 
> ...
>     memcmp
>     goto free_rng;

Do you find an additional jump really acceptable at such a source code place?


> report_failure:
>     <failure report>
> 
> free_rng:
>     <the deallocation code>

I am curious on how feedback will evolve also for the other design approach.

Regards,
Markus