mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dinh Nguyen <dinguyen@kernel.org>
To: Ley Foon Tan <ley.foon.tan@intel.com>
Cc: linux-kernel@vger.kernel.org,
	Chin Liang See <chin.liang.see@intel.com>,
	lftan.linux@gmail.com
Subject: Re: [PATCH] arm64: dts: socfpga: agilex: Fix gmac compatible
Date: Thu, 27 Feb 2020 08:48:53 -0600	[thread overview]
Message-ID: <b2747826-8685-37ab-4a12-939d3ea7ee94@kernel.org> (raw)
In-Reply-To: <20200226183518.64673-1-ley.foon.tan@intel.com>

Hi Ley Foon,

Thanks for catching this. Can you resend with the Fixes tag and cc the
stable mailing list to get this backported to the stable kernels.

Thanks,
Dinh

On 2/26/20 12:35 PM, Ley Foon Tan wrote:
> Fix gmac compatible string to "altr,socfpga-stmmac-a10-s10". Gmac for
> Agilex should use same compatible as Stratix 10.
> 
> Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
> ---
>  arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
> index e1d357eaad7c..d8c44d3ca15a 100644
> --- a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
> @@ -102,7 +102,7 @@
>  		};
>  
>  		gmac0: ethernet@ff800000 {
> -			compatible = "altr,socfpga-stmmac", "snps,dwmac-3.74a", "snps,dwmac";
> +			compatible = "altr,socfpga-stmmac-a10-s10", "snps,dwmac-3.74a", "snps,dwmac";
>  			reg = <0xff800000 0x2000>;
>  			interrupts = <0 90 4>;
>  			interrupt-names = "macirq";
> @@ -118,7 +118,7 @@
>  		};
>  
>  		gmac1: ethernet@ff802000 {
> -			compatible = "altr,socfpga-stmmac", "snps,dwmac-3.74a", "snps,dwmac";
> +			compatible = "altr,socfpga-stmmac-a10-s10", "snps,dwmac-3.74a", "snps,dwmac";
>  			reg = <0xff802000 0x2000>;
>  			interrupts = <0 91 4>;
>  			interrupt-names = "macirq";
> @@ -134,7 +134,7 @@
>  		};
>  
>  		gmac2: ethernet@ff804000 {
> -			compatible = "altr,socfpga-stmmac", "snps,dwmac-3.74a", "snps,dwmac";
> +			compatible = "altr,socfpga-stmmac-a10-s10", "snps,dwmac-3.74a", "snps,dwmac";
>  			reg = <0xff804000 0x2000>;
>  			interrupts = <0 92 4>;
>  			interrupt-names = "macirq";
> 

  reply	other threads:[~2020-02-27 14:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-26 18:35 Ley Foon Tan
2020-02-27 14:48 ` Dinh Nguyen [this message]
2020-02-28  0:40   ` Tan, Ley Foon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b2747826-8685-37ab-4a12-939d3ea7ee94@kernel.org \
    --to=dinguyen@kernel.org \
    --cc=chin.liang.see@intel.com \
    --cc=ley.foon.tan@intel.com \
    --cc=lftan.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®