From: Guenter Roeck <linux@roeck-us.net>
To: Chiang Brian <chiang.brian@inventec.com>,
Jean Delvare <jdelvare@suse.com>,
Jonathan Corbet <corbet@lwn.net>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>
Cc: linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v9 2/2] hwmon: (pmbus/tps53679) Add support for TPS53685
Date: Mon, 16 Jun 2025 09:15:43 -0700 [thread overview]
Message-ID: <b278e83a-473f-46ee-b353-3f8c14d03aaf@roeck-us.net> (raw)
In-Reply-To: <20250610102556.236300-3-chiang.brian@inventec.com>
On 6/10/25 03:25, Chiang Brian wrote:
...
> @@ -263,6 +282,10 @@ static int tps53679_probe(struct i2c_client *client)
> info->identify = tps53681_identify;
> info->read_word_data = tps53681_read_word_data;
> break;
> + case tps53685:
> + info->pages = TPS53679_PAGE_NUM;
> + info->identify = tps53685_identify;
> + break;
0-day rightfully complains about the bad alignment above.
If you want this patch to be applied for the next kernel release,
I would suggest to copy the hardware monitoring list on the first patch
of the series. Without it, I get
WARNING: DT compatible string "ti,tps53685" appears un-documented -- check ./Documentation/devicetree/bindings/
#296: FILE: drivers/hwmon/pmbus/tps53679.c:316:
+ {.compatible = "ti,tps53685", .data = (void *)tps53685},
Since I am not copied on the first patch of the series, that patch has to be applied
through a different maintainer tree, and I have to wait until that is the case.
Not that I understand the logic behind it, but I mentioned that before, so I assume
this is on purpose.
Guenter
next prev parent reply other threads:[~2025-06-16 16:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250610102556.236300-1-chiang.brian@inventec.com>
2025-06-10 10:25 ` [PATCH v9 1/2] dt-bindings: trivial: Add tps53685 support Chiang Brian
2025-06-10 10:41 ` Krzysztof Kozlowski
2025-06-10 10:41 ` Chiang Brian
2025-06-11 6:19 ` Krzysztof Kozlowski
2025-06-17 11:28 ` [PATCH v9 2/2] hwmon: (pmbus/tps53679) Add support for TPS53685 Brian Chiang
2025-06-10 18:25 ` [PATCH v9 1/2] dt-bindings: trivial: Add tps53685 support Rob Herring
2025-06-11 2:44 ` Chiang Brian
2025-06-10 10:25 ` [PATCH v9 2/2] hwmon: (pmbus/tps53679) Add support for TPS53685 Chiang Brian
2025-06-12 18:15 ` kernel test robot
2025-06-16 16:15 ` Guenter Roeck [this message]
2025-06-17 10:51 ` Brian Chiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b278e83a-473f-46ee-b353-3f8c14d03aaf@roeck-us.net \
--to=linux@roeck-us.net \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=chiang.brian@inventec.com \
--cc=corbet@lwn.net \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®