From: David Daney <ddaney@caviumnetworks.com>
To: "Joe Perches" <joe@perches.com>,
"SF Markus Elfring" <elfring@users.sourceforge.net>,
linux-mips@linux-mips.org,
"Dan Carpenter" <dan.carpenter@oracle.com>,
"David Daney" <david.daney@cavium.com>,
"Ralf Bächle" <ralf@linux-mips.org>,
"Steven J. Hill" <steven.hill@cavium.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] MIPS: Octeon: Delete an error message for a failed memory allocation in octeon_irq_init_gpio()
Date: Tue, 23 May 2017 14:42:18 -0700 [thread overview]
Message-ID: <b27dc33b-c9c8-fb41-7fbc-00cd18cf202b@caviumnetworks.com> (raw)
In-Reply-To: <1495565752.2093.69.camel@perches.com>
Steven,
Take Joe Perches' patch, put a proper change log on it and test it.
Hopefully Joe will agree to a SoB and we will do that instead of the
Markus Elfring thing.
Thanks,
David
On 05/23/2017 11:55 AM, Joe Perches wrote:
> On Tue, 2017-05-23 at 20:10 +0200, SF Markus Elfring wrote:
>> From: Markus Elfring <elfring@users.sourceforge.net>
>> Date: Tue, 23 May 2017 20:00:06 +0200
>>
>> Omit an extra message for a memory allocation failure in this function.
>>
>> This issue was detected by using the Coccinelle software.
>>
>> Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
>> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
>> ---
>> arch/mips/cavium-octeon/octeon-irq.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/mips/cavium-octeon/octeon-irq.c b/arch/mips/cavium-octeon/octeon-irq.c
>> index c1eb1ff7c800..050c08ece5b6 100644
>> --- a/arch/mips/cavium-octeon/octeon-irq.c
>> +++ b/arch/mips/cavium-octeon/octeon-irq.c
>> @@ -1615,7 +1615,6 @@ static int __init octeon_irq_init_gpio(
>> irq_domain_add_linear(
>> gpio_node, 16, &octeon_irq_domain_gpio_ops, gpiod);
>> } else {
>> - pr_warn("Cannot allocate memory for GPIO irq_domain.\n");
>> return -ENOMEM;
>> }
>
> You really should reverse the test here and
> unindent the first block.
>
> Again: Don't be mindless.
> Take the time to improve the code.
> ---
> diff --git a/arch/mips/cavium-octeon/octeon-irq.c b/arch/mips/cavium-octeon/octe
> index c1eb1ff7c800..2bdc750f2f2d 100644
> --- a/arch/mips/cavium-octeon/octeon-irq.c
> +++ b/arch/mips/cavium-octeon/octeon-irq.c
> @@ -1609,15 +1609,13 @@ static int __init octeon_irq_init_gpio(
> }
>
> gpiod = kzalloc(sizeof(*gpiod), GFP_KERNEL);
> - if (gpiod) {
> - /* gpio domain host_data is the base hwirq number. */
> - gpiod->base_hwirq = base_hwirq;
> - irq_domain_add_linear(
> - gpio_node, 16, &octeon_irq_domain_gpio_ops, gpiod);
> - } else {
> - pr_warn("Cannot allocate memory for GPIO irq_domain.\n");
> + if (!gpiod)
> return -ENOMEM;
> - }
> +
> + /* gpio domain host_data is the base hwirq number. */
> + gpiod->base_hwirq = base_hwirq;
> + irq_domain_add_linear(gpio_node, 16,
> + &octeon_irq_domain_gpio_ops, gpiod);
>
> /*
> * Clear the OF_POPULATED flag that was set by of_irq_init()
>
next prev parent reply other threads:[~2017-05-23 21:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 18:10 SF Markus Elfring
2017-05-23 18:55 ` Joe Perches
2017-05-23 18:59 ` David Daney
2017-05-23 21:42 ` David Daney [this message]
2017-05-24 16:01 ` SF Markus Elfring
2017-05-24 19:43 ` Joe Perches
2017-05-29 19:38 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b27dc33b-c9c8-fb41-7fbc-00cd18cf202b@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=dan.carpenter@oracle.com \
--cc=david.daney@cavium.com \
--cc=elfring@users.sourceforge.net \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=steven.hill@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®