mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Imran Shaik <quic_imrashai@quicinc.com>
To: Stephen Boyd <sboyd@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>
Cc: Ajit Pandey <quic_ajipan@quicinc.com>,
	Taniya Das <quic_tdas@quicinc.com>,
	Jagadeesh Kona <quic_jkona@quicinc.com>,
	Satya Priya Kakitapalli <quic_skakitap@quicinc.com>,
	<linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	Dmitry Baryshkov <lumag@kernel.org>
Subject: Re: [PATCH v5] clk: qcom: Add support for Camera Clock Controller on QCS8300
Date: Wed, 26 Mar 2025 16:47:19 +0530	[thread overview]
Message-ID: <b28143c7-5980-4062-bf81-4ae9fd9b0258@quicinc.com> (raw)
In-Reply-To: <7292158ac0cd6b944d9d1f01314d24b1@kernel.org>



On 3/25/2025 5:08 AM, Stephen Boyd wrote:
> Quoting Imran Shaik (2025-03-20 20:56:43)
>> diff --git a/drivers/clk/qcom/camcc-sa8775p.c b/drivers/clk/qcom/camcc-sa8775p.c
>> index 11bd2e234811..bd75f59d3ffe 100644
>> --- a/drivers/clk/qcom/camcc-sa8775p.c
>> +++ b/drivers/clk/qcom/camcc-sa8775p.c
>> @@ -1811,6 +1830,7 @@ static const struct qcom_cc_desc cam_cc_sa8775p_desc = {
>>  };
>>  
>>  static const struct of_device_id cam_cc_sa8775p_match_table[] = {
>> +       { .compatible = "qcom,qcs8300-camcc" },
>>         { .compatible = "qcom,sa8775p-camcc" },
>>         { }
>>  };
>> @@ -1841,10 +1861,83 @@ static int cam_cc_sa8775p_probe(struct platform_device *pdev)
>>         clk_lucid_evo_pll_configure(&cam_cc_pll4, regmap, &cam_cc_pll4_config);
>>         clk_lucid_evo_pll_configure(&cam_cc_pll5, regmap, &cam_cc_pll5_config);
>>  
>> -       /* Keep some clocks always enabled */
>> -       qcom_branch_set_clk_en(regmap, 0x13194); /* CAM_CC_CAMNOC_XO_CLK */
>> -       qcom_branch_set_clk_en(regmap, 0x131ec); /* CAM_CC_GDSC_CLK */
>> -       qcom_branch_set_clk_en(regmap, 0x13208); /* CAM_CC_SLEEP_CLK */
>> +       if (of_device_is_compatible(pdev->dev.of_node, "qcom,qcs8300-camcc")) {
> 
> Can we just use device_is_compatible() here? Then we're not specific to
> DT. Or better yet, use the device match data to signal this instead of
> checking compatible again, and possibly getting it wrong due to a typo
> somewhere.
> 

Thanks Stephen for your review.

Sure, I will use device_is_compatible() and post another series.

Regards,
Imran


      reply	other threads:[~2025-03-26 11:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-21  3:56 Imran Shaik
2025-03-24 23:38 ` Stephen Boyd
2025-03-26 11:17   ` Imran Shaik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b28143c7-5980-4062-bf81-4ae9fd9b0258@quicinc.com \
    --to=quic_imrashai@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lumag@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=quic_ajipan@quicinc.com \
    --cc=quic_jkona@quicinc.com \
    --cc=quic_skakitap@quicinc.com \
    --cc=quic_tdas@quicinc.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®