From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752019AbdIMPTG (ORCPT ); Wed, 13 Sep 2017 11:19:06 -0400 Received: from mail-dm3nam03on0065.outbound.protection.outlook.com ([104.47.41.65]:5024 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751807AbdIMPTB (ORCPT ); Wed, 13 Sep 2017 11:19:01 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Cc: brijesh.singh@amd.com, linux-kernel@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org, Thomas Gleixner , Joerg Roedel , "Michael S . Tsirkin" , Paolo Bonzini , =?UTF-8?B?XCJSYWRpbSBLcsSNbcOhxZlcIg==?= , Tom Lendacky , Herbert Xu , "David S . Miller" , Gary Hook , linux-crypto@vger.kernel.org Subject: Re: [RFC Part2 PATCH v3 03/26] crypto: ccp: Add Secure Encrypted Virtualization (SEV) device support To: Borislav Petkov References: <20170724200303.12197-1-brijesh.singh@amd.com> <20170724200303.12197-4-brijesh.singh@amd.com> <20170913141749.pvphgxgcsjam4us7@pd.tnic> From: Brijesh Singh Message-ID: Date: Wed, 13 Sep 2017 10:18:52 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170913141749.pvphgxgcsjam4us7@pd.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BY2PR11CA0047.namprd11.prod.outlook.com (10.163.150.143) To BY2PR12MB0146.namprd12.prod.outlook.com (10.162.82.19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b094a577-45b5-49f8-4684-08d4fabac1f3 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:BY2PR12MB0146; X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0146;3:X4VchmcvhiBhztBcKyLsG2u7Pq341/KqV+f+X9kNUN5Lo8kpKMUm4E32+XKR7YYLXhdSKlCZl5L5ihn+xfOAXcn1BfwaHDLxY/2gZoQkGfN1GnTex5aarHHjUqD6uFfSWENo9lh3V8c5BQhy1hIukzQ32MSW/1ZZpqP41fwC1KuJ3U3IQz+AhCSFe6dfq4YHQFaJ2KIfQSnnKNO/ZF/tmxnexgLTYdwW2s4BgDjgkCPYIvPKM7ypZUncJUFZEOnl;25:BE8n06czfRfzdbDa6uwTzvi9hFF6ndybHPvOpN/hdOrQtM6QKo7r4Glbj4/vAclAKZJHqohVYipElzKVweDqeMMlMuv7diPpZ7jNh5nBZwq0CQr2ZzsUSHwA0J8KEO3QQVzgNi6x9w7cwIcuZiUd+ZxpM3N6JajYOgcNUqGh8fs+sIV04A2dI/SBRoYjDwtcliRKGxwgGzKZXI0QZjaW49kuiLh+LYHdK7TNM5x3emmr/VqpOZLBzeqw8uXEvp/mg1Af2uP01fnwXFgfV83wAT7RiXgSnuZRi0LMjSaVJWYSXgoHXNJ+1Whf1kKI3EAJ/dlxQZ86GvyvZPWNGX4Fog==;31:dSEaTPgu70uTb+m+gtFDNTDYzrP5nkzXsISkFNzz1J1OnRh84wJFqIE2CYPbodfiF9UNV74UWTSACWCvzaY0D0qxlMutpwh1zPNkIMfH2HN4awanKdMYPErJRfZSjXmkX0q4bxAT5kjUCRMDk11dp22DpZmceS/KnbghHnrnGg5dfKAcptJ3ILbWPf0vHfxIPgEU7KiKs4bMfXi/W50QKZa8j3dT4kCeJr016TD131Q= X-MS-TrafficTypeDiagnostic: BY2PR12MB0146: X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0146;20:L3DIua97JlPiCaecNK3jWqFq7dKpKBVtBXjUGZ0ljATPPwG16grjIORzRb8sygLulbail9J2QDd3P+jrewvuGPzxsmz3LZVU3PNMAlNyyUJYPc36gpesxs9dOE0b+2ZSYcRtf+7ui3SrkLAKMuMSfo4/0bkn2a4UhONkY9dYKq+BGkYeBKvRo2MckXrjrPuaW5PE9rPn8XENolMEJYmMFIW0SpGSmCYtbBftdzDjMdYIFhEeIADM2CcyaI04+/3i0wi+hrUoBfmZkHppIG8AA6Mw910IdhE8LtAMwAkR/3qmvJ/rvVTs7xAs1PqlDlhbKHiJRuU3zonjPOQLYeEbQKHRHAL/qVKiskFxpmZI9dhESMLeVVg+hRtDyCvvFigJyxnCBOPdvOfM/FRLG40B5YhU2h0jzuskaDik2cb5aCn8CPlRzqtjHssD5NmaC/t9tFMddvneti+OfuEhPBE5SnGesVxWizqsTUttEhVFATMnTFnP8KyM17XqokY+dVUn;4:zZ9bLrmV/lgoDuF3MD0vvNbLMFkOb1h0H7j/jDTOBKXjsjPv1LFhifl50Ws8MvYaebdGZP6ccNSxUapvl8n5awrTwb77plravdr9kDbZZxJrwfEo7cGY3hX+mKjxSSgX39GNur+LE30MzhyDxCqJP+1Pr+X7NYJA79KNfNStCmKS+a4xUQuKa8qzNakYMg01KlL9ZWKweOulsMvSqn8L6eveDR0puoZfIHopFNMHa73uSpt1sFDqy8i2MQjbU3sr X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(20161123560025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123562025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BY2PR12MB0146;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BY2PR12MB0146; X-Forefront-PRVS: 042957ACD7 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6049001)(376002)(366002)(346002)(39860400002)(24454002)(189002)(377454003)(199003)(77096006)(2950100002)(6916009)(106356001)(65806001)(47776003)(3846002)(90366009)(230700001)(6116002)(76176999)(50986999)(50466002)(54356999)(229853002)(6666003)(105586002)(478600001)(6486002)(101416001)(316002)(64126003)(25786009)(7736002)(66066001)(33646002)(83506001)(68736007)(53546010)(65956001)(4326008)(305945005)(81156014)(8676002)(7416002)(81166006)(5660300001)(110136004)(189998001)(65826007)(54906002)(31686004)(23676002)(6246003)(16526017)(53936002)(97736004)(31696002)(36756003)(86362001)(4001350100001)(8936002)(16576012)(2906002);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR12MB0146;H:[10.236.136.62];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTJQUjEyTUIwMTQ2OzIzOkkvZDgwZDBjaTRQcmNERk1WOURJV3RUTy9E?= =?utf-8?B?MUJvRUhRRW5CTFRvcjZNa3gvc2JlcG5jUlVjWkp2NE55c3YwTDMvQVl1T2kw?= =?utf-8?B?cHdabER5K1hUT0xiUWw3czRobTNKbFhhMGdrMWoxODFZaGZNeUpxYi8wQkZt?= =?utf-8?B?bWJOam1kM1BOblNBUHJEVXJ0Z3NFNktDV1BaYjkxeHJ5VU1TZytrczY3ejQ0?= =?utf-8?B?S0QrQm1QR1JobGxuWkxCY0owamlNSmZkMEUrMW5VNElHU2ZpdXBqV0d1a2Ju?= =?utf-8?B?NVRJams3QlczcHZzd2tVM2x1dlBaTWJhWWVmUUF4dzMxYXd6TzlnWGtYQ3VK?= =?utf-8?B?ZnJwZTRpYWRJa29MS3pFQzcwbENWaXFMQnhpM0pOSXMyYzc4UkhhUTJhN0lJ?= =?utf-8?B?c21RdEpKdEc0Y0lhNEQyUlU4Y0JEVVFEc3F0VGNEZitYcGhvcWNtYWdFc2pt?= =?utf-8?B?L29HZk1oNEN1S1BFNytRVlM2YXJnWEVJUGpxTjdxeGJMY2hwTnM1dTV4dHhh?= =?utf-8?B?WERJSFN5c042SDh3Tkd0MTI0d25YSXRvWFk0M1gvUzZrWUxEYXFrQjhrSjJR?= =?utf-8?B?V0tRZGhSRmNJcTEwWmVDVW9PNG11RitvS3M4a2FuazIvR2lBSDQrZW04bkZl?= =?utf-8?B?UlBTdHZEak9aNmUvcFYxM3kzL0VHYW1TREhqQnJnbXg4UzAvcDdsVXd5bE9I?= =?utf-8?B?R21wZzlNeHhYR3QwckxMTXloQUlzMklHZHZMYlFvZ2JzVkNNU2NLYXJOYytu?= =?utf-8?B?aXVjTE5FRy9TVGdNcjhNZFFxbE9qYmtIaFZHWGpxRXIycHNrN2ZURDdJUTA0?= =?utf-8?B?Z1dDcktaTE0xUk5DcXJvbXdab3RWVG0yMmliSHI1c1k5c0tSOTlTUUVubjRj?= =?utf-8?B?WmhxZTRyWE05V2FyQllHY1NYTlpBNkxxdUxDTmYrTWdSalRxckpsNFJHYnds?= =?utf-8?B?VDhOcnVNNVVxQnRFbUtVVDY2djNoSHkvYjJKTDFKZlAwMkN4SjIrZkpvQWt3?= =?utf-8?B?U1Jpak12dVJzejhXV25qOGVmSGI4ZW9wV3lkeWQvOFR0OW1BNjlERWJEdzhG?= =?utf-8?B?U2RiKzh1ZFl1Q2hSeVBBYmZTRTB0dWpSUWlNQnZRUTJxUk8zMTlhTWFldUd1?= =?utf-8?B?MWwvY2x5MGwrdTJNcDJpZE1lbzlWQlpqaWhiVU5id1MzdHhzRUxKdUtRQW1T?= =?utf-8?B?VmZ0OTYydkovVXk2NDdHTUszZlptaDFFWm1MYTJMVjJsdjlwcTV3dThGS290?= =?utf-8?B?eWlIV3ozOFowdnVHTWJ0djM3dG1MaVBvU2xMdlRobk02b1pMUkpJWnNTSVZs?= =?utf-8?B?bE9DUHQ1c2Mxem1tV3ZxYkxBSkdQWUxYN0pqa21jb0VKV0FjcTFpVjk0Y1FE?= =?utf-8?B?SXFjM0dRdFdoZEdSSko2QTU1cXhsVm13c3o4czlFQmg1akI1VHhXaVBJdFMw?= =?utf-8?B?M0MxWXkxb2lRbDZJcHc4TmtEU3h0Vm1SSi9QRFdRbDljZitXZURkalg3cWcz?= =?utf-8?B?dzhUVGdIUnZHLzFGM1hpendIVkZDam5xOGx5dVNMUzY4K0ZoTThEbk5BdCtI?= =?utf-8?B?WE4vd1lVWnBSTHFqd2VPc3kxcjlUMkNQNE5jTndsaFIvbmNKcm5SZDdzWFJC?= =?utf-8?B?OGVRUVlLQzk0U3h2cGVYZmpaZkR3OUhBd3ZjYlhsSlVRbjErNFFDbmliMVoy?= =?utf-8?B?S3kwNGFNWFVvT1JPMHZuUFBlYm10T0dwZTRvUmg5SmpPbEM2NFhnblZTenRP?= =?utf-8?B?L0x3SUFlalVuV1M0YkRlbmFrQ3ZHRU4xeDUxdU1ibjNjNTFSb1poQnhPRDZS?= =?utf-8?B?K25McXFtMlhoQjRWcnYrSWNaOU9RaFhVM0llMDdvZXVNMEkyYWJCVG9wNU9s?= =?utf-8?B?aDNLRU5lS2lwWVhNS1VGUDdJYkE0c0ZCSit3QllaWDhvcjh1UXpUcFYvd3VI?= =?utf-8?B?KzEzR2FqU2tlWUw4S3VvcHhzVjloUXFLcGQ0UEh1Z21La3dHVkxWdEVqNXpD?= =?utf-8?Q?AzGrz5?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0146;6:EfB+eOqtQ/DPxw0BKORL+EtS4rUE3UMkC6se966HmXOGuX9IxYB4TjWP6mOkU56cTde4i/+fF6jIOF5sz8IqKWESjY0hR2PGjwSQYxWSvgKzs1Th1oQDjLYZSSO69Iz9ZbBh+OgIj6pyKz/n2gqEp2z5VXEskQ5Qx2GTqLIRCuTB9qCaxQWDh13iysqbKX7OrulR6GxCpd3pV3iXVPp9ReE+7RhqCT7nZoM7XWl0nYkMpawi+khO2F2zKsDSfkfexVvFlmH1jXY8JfhQF6l2XBIyLU8yFFsmN5IRYkwk9cNpLFL72y8veLeHw3Yhn0/06iwVQfeEBnp6MCoxdDEglg==;5:Bv6Xnw/nRhdEDhzpkiJwIwvTUSIDbD4CKR1asgaWI0Q7Tkw/T+k6upsY4kOKQBP1NkAGzEwmqffkhKV8gVZsQPDSLHqNZciOXN/SW7tOI8AK1Vjhy7xgJN/oZJwubR8SU9x8KZUe5JEYxmcmwVREHg==;24:oRk1eUT/SRAEThbVrBf6Xujxo/CoZ88/pZc/S9YFlF4kEnfGembp+AcFbHDjHS06sRy7iKCc4GPadfsSu7JHFo71ozeIG5CWBe/nJlx1rtA=;7:noaTRZuv7W9lWiRpdRMs/ICpburoUBSIfzN7DAGHfgp9Em4FVLOQ2a9/sMUqc1x9AtNUiu+/T72NmDMNyHvVqBr7QPcbCBaJsMdiJtvmsXM3PwsQzDCUpUS0SCSAi+JVU/3wQnXtaRfUcGM2W1d4nRTMqsfyA7EO3CTFknL0QoG/CBqwDnLIv9PpsShcqWf4Vm+2Ps5x0BMsVmSxpQfoAecEGw2gGL9TDH1/+zs64Hc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0146;20:LYYQsomLonatfzHgS7ydORnisn6qjvv94jzAYmquqZ+52R6U4wU9hvlXbzX+Uy9cHUM13rbmI56XSgAFRkH16yNlVdyeH3oWm7PBXdezGSbkDwOnb81+Grr2rGSGnFs8UInQ1ya8aEgiuQtwVMh99yeokCTIwkzDq08zthHumYJBMzaaGrS98mgxU3T36ko43EWNorO1Q8dSB4DLtQDefF0+gYokPjI+vY6+mHbxwsDfJoN2fiM7oTr4/J4f2bGs X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2017 15:18:57.7764 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR12MB0146 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/13/2017 09:17 AM, Borislav Petkov wrote: ... >> + >> +unlock: >> + mutex_unlock(&sev_cmd_mutex); >> + print_hex_dump_debug("(out): ", DUMP_PREFIX_OFFSET, 16, 2, data, >> + sev_cmd_buffer_len(cmd), false); >> + return ret; > > ... and here you return psp_ret == 0 even though something failed. > > What I think you should do is not touch @psp_ret when you return before > the SEV command executes and *when* you return, set @psp_ret accordingly > to denote the status of the command execution. > > Or if you're touching it before you execute the SEV > command and you return early, it should say something like > PSP_CMDRESP_COMMAND_DIDNT_EXECUTE or so, to tell the caller exactly what > happened. > Agreed, very good catch thank you. I will fix it. -Brijesh