From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC013FA3741 for ; Thu, 27 Oct 2022 16:08:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236367AbiJ0QIM (ORCPT ); Thu, 27 Oct 2022 12:08:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234372AbiJ0QIK (ORCPT ); Thu, 27 Oct 2022 12:08:10 -0400 Received: from mail-qv1-xf29.google.com (mail-qv1-xf29.google.com [IPv6:2607:f8b0:4864:20::f29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0A7B181D9F for ; Thu, 27 Oct 2022 09:08:09 -0700 (PDT) Received: by mail-qv1-xf29.google.com with SMTP id n18so1711068qvt.11 for ; Thu, 27 Oct 2022 09:08:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+EByezWssNJpDNY0y+L8q4F549C1PMWF7aqVJonq+z0=; b=aAVZaCTCOqatS09ZMKrhBEnOEbQndq2u9CKWDuWcuRP38rqyHCkiTwZh9zPE1q2+mR gVCrlGA4rKcKHf1K8jkfpjSR/pPaLnDDzvrIbCYPTBNc9lncg0QvLmshiuF7Cxm4Gltx uCb8bYZaFFjiT7/PbY6/ZuMUYPXBEPw8I1xqdf2vDQ8xzr6B7vmxhvhJLJvrfImXcL4K X44hEmyBYA8IwWRc/hMhQ2db2BTq2sV17rr1r+/KCnuKEjqJ98Nlt3u1bPvOxe9S8epF 3Lii+YEzV+Nbr6Noz/2gnVYU5pU95cPX4XV1D8Jku1vlQEoIOW0NCsQdmSUADbhfr4mA ILCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+EByezWssNJpDNY0y+L8q4F549C1PMWF7aqVJonq+z0=; b=HadpRR16qAl31sfffL15Yb7rYNZXzX7ywMvk4IacheN1ICjp87zCTlDGK6sRn0zn/Q Wfry/AwuiU26Tms68khMzLjY1AJJh1fhSPB2QuJqNqNeTdZyg+0JvGGHLPB5lYkooN9p 4xJPoFVZQsUT2KapmuRn1O0CPRLGwi+YGGaDLvsj+uFSQ9CTNCLiRAnTZl6KR/thOhbq QfUxcMG5HL/SwEynMdXeFLu0gjyxVdSluTGMChDaoUgyrrfNpd4U9eBFZurN9oYKP7O+ ZXrSVTaSxBmuVVtgaIDHysXR7xDK3iSRGioETp1+nNUD30CKKA3SO8L0LIDavz6g1IGv N/Yg== X-Gm-Message-State: ACrzQf2smBUdjli89oTJPHAmyyQCQFb5jD+5tsw0Kz5pDQRXfp4CRcRY 7+Fk9sE69mQ4IKacyxnmja0TwA== X-Google-Smtp-Source: AMsMyM5KQ32g/c5YieGNUnfeAUqqnYFAbo62RxNtSDi/P5hmklPmYdfcPmNYo17iNk7me6skE3c8Ow== X-Received: by 2002:a05:6214:dac:b0:4bb:5901:38b1 with SMTP id h12-20020a0562140dac00b004bb590138b1mr26687385qvh.18.1666886888990; Thu, 27 Oct 2022 09:08:08 -0700 (PDT) Received: from [192.168.1.11] ([64.57.193.93]) by smtp.gmail.com with ESMTPSA id g19-20020a05620a40d300b006eeb3165565sm1214137qko.80.2022.10.27.09.08.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Oct 2022 09:08:08 -0700 (PDT) Message-ID: Date: Thu, 27 Oct 2022 12:08:06 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [RFC net-next 1/2] dt-bindings: net: dsa: add bindings for GSW Series switches To: Vladimir Oltean Cc: Camel Guo , Camel Guo , Andrew Lunn , "David S. Miller" , Eric Dumazet , Florian Fainelli , Jakub Kicinski , Krzysztof Kozlowski , Paolo Abeni , Rob Herring , Russell King , Vivien Didelot , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , Rob Herring , kernel References: <20221025135243.4038706-1-camel.guo@axis.com> <20221025135243.4038706-2-camel.guo@axis.com> <16aac887-232a-7141-cc65-eab19c532592@linaro.org> <20221027135719.pt7rz6dnjvcuqcxv@skbuf> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <20221027135719.pt7rz6dnjvcuqcxv@skbuf> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/10/2022 09:57, Vladimir Oltean wrote: > Hi Camel, > > On Thu, Oct 27, 2022 at 08:46:27AM -0400, Krzysztof Kozlowski wrote: >>> >> +      - enum: >>> >> +          - mxl,gsw145-mdio >>> > >>> > Why "mdio" suffix? >>> >>> Inspired by others dsa chips. >>> lan9303.txt:  - "smsc,lan9303-mdio" for mdio managed mode >>> lantiq-gswip.txt:- compatible   : "lantiq,xrx200-mdio" for the MDIO bus >>> inside the GSWIP >>> nxp,sja1105.yaml:                  - nxp,sja1110-base-t1-mdio >> >> As I replied to Andrew, this is discouraged. > > Let's compare apples to apples, shall we? > "nxp,sja1110-base-t1-mdio" is the 100Base-T1 MDIO controller of the > NXP SJA1110 switch, hence the name. It is not a SJA1110 switch connected > over MDIO. Thanks for clarifying. Then this could be fine. Let me then explain what is discouraged: 1. Adding bus suffixes to the compatible, so for example foo,bar LED controller is on I2C bus, so you call it "foo,bar-i2c". 2. Adding device types to the compatible, if this is the only function/variant of the device, so for example calling foo,bar LED controller "foo,bar-led". This makes sense in case of multi functional devices (PMICs, SoCs), but not standalone ones. So what do we have here? Is it one of the cases above? Best regards, Krzysztof