From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 057D1C4363C for ; Wed, 12 May 2021 18:06:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 17D3E613C3 for ; Wed, 12 May 2021 18:06:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352563AbhELSDe (ORCPT ); Wed, 12 May 2021 14:03:34 -0400 Received: from mga18.intel.com ([134.134.136.126]:23556 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241391AbhELQ1H (ORCPT ); Wed, 12 May 2021 12:27:07 -0400 IronPort-SDR: W49jOorMNATVSlfdFZ5xAzjB0zIITVOIi9q6yJs/hUQUFJqG6bU8IDtUOrwzt3wc6fhqVuasJr mDI4Ra/dC7bQ== X-IronPort-AV: E=McAfee;i="6200,9189,9982"; a="187172842" X-IronPort-AV: E=Sophos;i="5.82,293,1613462400"; d="scan'208";a="187172842" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2021 09:25:58 -0700 IronPort-SDR: dHfPVdrBuQvyobdL3A9WvlZuIsDR0OwBTAZWGxKLKH/0nZHrk0K2RmOiIZ11T4dXanxRqC3bLb vR0taFWc/cfg== X-IronPort-AV: E=Sophos;i="5.82,293,1613462400"; d="scan'208";a="455671473" Received: from tzehanch-mobl2.amr.corp.intel.com (HELO [10.213.186.26]) ([10.213.186.26]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2021 09:25:56 -0700 Subject: Re: [PATCH -next] ASoC: intel/boards: add missing MODULE_DEVICE_TABLE To: Mark Brown Cc: sathyanarayana.nujella@intel.com, fred.oh@linux.intel.com, cezary.rojewski@intel.com, dharageswari.r@intel.com, kai.vehmanen@linux.intel.com, kuninori.morimoto.gx@renesas.com, linux-kernel@vger.kernel.org, yang.jie@linux.intel.com, tiwai@suse.com, liam.r.girdwood@linux.intel.com, tzungbi@google.com, ranjani.sridharan@linux.intel.com, Zou Wei , alsa-devel@alsa-project.org, brent.lu@intel.com, yong.zhi@intel.com References: <1620791647-16024-1-git-send-email-zou_wei@huawei.com> <50fa973b-aa9f-ccb4-8020-9d38a63e2c30@linux.intel.com> <20210512155318.GA54562@sirena.org.uk> From: Pierre-Louis Bossart Message-ID: Date: Wed, 12 May 2021 11:25:53 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210512155318.GA54562@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> I wonder if this MODULE_DEVICE_TABLE generates the alias automatically, >> which would make the existing ones added manually at the end of the files >> unnecessary? If that was the case, then we should remove those MODULE_ALIAS >> as well, no? > > Yes, you shouldn't need the MODULE_ALIAS stuff there. ok, if that's alright with everyone I'll send a larger patchset that correct this for all machine drivers, and add the following two tags to give proper credits to the reporters. Reported-by: Hulk Robot Suggested-by: Zou Wei