From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C48428B3E7 for ; Mon, 22 Sep 2025 21:59:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758578358; cv=none; b=Q0pQdIveOEycKQO+r9RnUUgJMEIeMqeESn3K7GuG0i2zAs3BmCpl/Dr1E7shhUj16EUyzqavPtSh68eRM8mS7J82NNlyXlsoFqsfs87nwr4kjZcK6fM00t1jRJ79jZtCay/ObELfhJKxr3DkcgyyAznwmn3L8Xe4WQZpMOneRb4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758578358; c=relaxed/simple; bh=8EAdYteEsZfi3L8LNoGQ5Mo9rWCKtDhbyQqf6B5Tt4c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tGUETQIoYM8Cx7ECDBCEN+CdotRQ3B6OVSBBqzWBIWR0dpLvzWHE4dE6ctXMSiKr5lRORiCrWmIjlUmAMik/Wf+Oz1ZrXaYRiDZASQsm7jvgJ/6sZ1KgCtdS0V3ssr7FdCqKJxvq6AGABhmhb+tLSqKxvvB+6pLvh/R4zWvk/xk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AkT9iD5y; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AkT9iD5y" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58MITf6C029672 for ; Mon, 22 Sep 2025 21:59:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0LDmHGPzBvAlIgIdJc1sMUYY1nDOFFKwgh16pYuyb2I=; b=AkT9iD5yDkz2ePE9 hYrle13HGQ84SwGViegVrJ6NjaVVf9fJ3FyaBJbfL1X2x4RT/lgN52Ml6+WHRQyt 5YeTnbs3lnpqBjHSuHMcEBOCdK0mJFmXPHOs++OGR2rrJUeSAdNcPNlYQ0t/NqCs eu469/Us5gX6j/GKWdY2LCTXlsio0Kdeorghcz8EFiqvI48bT8Z0OprjBhROMVKu PzkXjw3Qqr/fyYTH4MMmuhHXAgkBXFl4A8WVyyhLa8B7CRRgrYU4UQLT00RuplP+ rVulvB0RwxUFSr0/FpwByc2FLc17qGncFQ2AjO1R6V4lOpZja55LzhuXaKs5DbuF wr9qQw== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49b3kk25pf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 22 Sep 2025 21:59:15 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2698b5fbe5bso61272795ad.0 for ; Mon, 22 Sep 2025 14:59:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758578354; x=1759183154; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0LDmHGPzBvAlIgIdJc1sMUYY1nDOFFKwgh16pYuyb2I=; b=GV3pmNcdW4Qoo+Lrr+q5Y8Hd4xOXYls4gG9MX/Gg/IsFdh7Ko1fv2uffn1JC1cniLS Y9SAAtSx9YN6wCH0IyAyi85L+T65FEoAPSBzoccXF5x1Q1wZtNTEhZOjjCH64wdHNkKw Qlj/bH/QeA5ApZ2v4RE9Lo26NJJL/hPRtF4uFiwqzMFL2sCaLtFt63qY1XAsQw9QNWJG LTihx9rYQWDywkZjiB1Y7XssaTBU2Xtq0hVqyWhX8WccIUMevRLngVK31d2twcuV00mD fEVt5QlLwhyXSst2l9PVU/YOqNahMgoMm2LtE5JkKTocH7E5AWyP2BMF+PvuIESunyKC bWEw== X-Forwarded-Encrypted: i=1; AJvYcCVneDH5uZ8PxFDtZzUxzWx6CDDD+aLazDg2DCegNFyMGLQmZj1SLkgNgHU6AV2jf7evkbeHkhDRUO2KVjo=@vger.kernel.org X-Gm-Message-State: AOJu0YxU7df89R8M3WfPm0etovPXPjIgSJLDym+FxtvdYHMeo9vdrFhV WIMRloUqwIxBixJiPggfTKi5Z0ywfhtKCShBx3dZlafSmP6ApvFK6Ee4PYHN4oLtT6LWbExiHtH ycj84PP5ubohQcGfrd5BqiBZ50AZQnk76ay7lCNuKZCxGeAngEIPrzesK9cPt5D6m/qg= X-Gm-Gg: ASbGncuv5oxTH7kmJJNQwcNLHM87I8a4szselaMfujTBoxy0Ixod5H3+q+UB5rmoDw0 EiXVVqKKR4qi4k/jZQjSNgdIz/gs6yCI0WaEOWH2/WhIafbtw1SbvtzmS464DN5uNAZKX3+YlZU 8lbHMWGbbT6sFK61RPT3yE7/cSr2v9yNuq5PnMeR+4kMCP+K671XULNwnfXn5R4m0wamimrLEYa 92ODEq8pGAmf7m4pF7ir4qF72ZkJWbyneQrTigmZxKLdaHllaMEvODItH3GudAB9xuEMVc34Hdx Xp3J61N59dlVOOFYMUwNBFCkH8OnRQvJMWDCzZ3Xjo+k8A/LfpIm5u40PxVu4rwIRiJnclyfiq1 rA9V/952CxfeM21/SdwJMVH1rXkn5daVsqn/W X-Received: by 2002:a17:903:1547:b0:248:79d4:93be with SMTP id d9443c01a7336-27cc5624f64mr3801125ad.30.1758578353851; Mon, 22 Sep 2025 14:59:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGGG6T7ySc8crxPcb7K8edEeVJNt96b5JVAn3AQ/h6MKUU8Y56um/AFywBRAM+AxXS7ufrcJg== X-Received: by 2002:a17:903:1547:b0:248:79d4:93be with SMTP id d9443c01a7336-27cc5624f64mr3800745ad.30.1758578353279; Mon, 22 Sep 2025 14:59:13 -0700 (PDT) Received: from [192.168.1.111] (c-73-202-227-126.hsd1.ca.comcast.net. [73.202.227.126]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2698016c08dsm141506235ad.51.2025.09.22.14.59.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Sep 2025 14:59:12 -0700 (PDT) Message-ID: Date: Mon, 22 Sep 2025 14:59:11 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] wifi: ath11k: HAL SRNG: don't deinitialize and re-initialize again To: Muhammad Usama Anjum Cc: kernel@collabora.com, stable@vger.kernel.org, Muna Sinada , Anilkumar Kolli , linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-kernel@vger.kernel.org, Julia Lawall , Baochen Qiang , Sathishkumar Muruganandam , Jeff Johnson , Manikanta Pubbisetty , Sven Eckelmann References: <20250722053121.1145001-1-usama.anjum@collabora.com> <1598d25d-e254-410e-ac5c-66d5450fd686@oss.qualcomm.com> <86c465a3-f9a1-4a63-9e21-7529a5634301@collabora.com> From: Jeff Johnson Content-Language: en-US In-Reply-To: <86c465a3-f9a1-4a63-9e21-7529a5634301@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: q3gu_pHBLrcAEVWIugRyVoT2X8KqzYbR X-Proofpoint-ORIG-GUID: q3gu_pHBLrcAEVWIugRyVoT2X8KqzYbR X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTIyMDA4OSBTYWx0ZWRfXxHs5lOOFJjox HKWandMD1CmotZuNZjmTPGiofLl7+QMJN7Pglxzi+0rXAOrKBgn4t4iSX6fsVu9Z/9ReTzxuofn 3bVAL73Lomz17+w/y2PPzZCwx4erB1zmxhDDOhhiT49v/1AZDGWb1K/DyalljsTPte7uetFON/b 40MTTUE9sRjWh64iJ4i9pABtH4jp4eO2WNseN/AZYAHr7I5CQQg3Lxkun1hBWDfjqYRm3XIDqyx s5OajnmHi+BFPE6etqD85tLKgeqzY6+1S7ww0MaNCh23JEUqQz64gSxNdDu0/IPOLe2RlQ3PDxR 9t8EcOR39QCqVR5XcghIP4W6CyGrvtj7zJBmmaF8mOnmjZzu1YgW7VeoCgWZUHJKJNA+l4zaukO 46LJl4Yq X-Authority-Analysis: v=2.4 cv=BabY0qt2 c=1 sm=1 tr=0 ts=68d1c6b3 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=e70TP3dOR9hTogukJ0528Q==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=QX4gbG5DAAAA:8 a=RL02kzwgQxJZJf316toA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 a=AbAUZ8qAyYyZVLSsDulk:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-22_04,2025-09-22_05,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 phishscore=0 bulkscore=0 priorityscore=1501 adultscore=0 malwarescore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509220089 On 7/22/2025 8:05 AM, Muhammad Usama Anjum wrote: > On 7/22/25 7:07 PM, Jeff Johnson wrote: >> On 7/22/2025 4:23 AM, Muhammad Usama Anjum wrote: >>> Hi Kalle, >> >> Kalle is no longer a maintainer -- I am currently the only ath11k maintainer. > Sorry, I missed it. > >> >>> >>> On 7/22/25 2:47 PM, Baochen Qiang wrote: >>>> >>>> >>>> On 7/22/2025 1:31 PM, Muhammad Usama Anjum wrote: >>>>> Don't deinitialize and reinitialize the HAL helpers. The dma memory is >>>>> deallocated and there is high possibility that we'll not be able to get >>>>> the same memory allocated from dma when there is high memory pressure. >>>>> >>>>> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03926.13-QCAHSPSWPL_V2_SILICONZ_CE-2.52297.6 >>>>> >>>>> Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") >>>>> Cc: stable@vger.kernel.org >>>>> Cc: Baochen Qiang >>>>> Reviewed-by: Baochen Qiang >>>>> Signed-off-by: Muhammad Usama Anjum >>>>> --- >>>>> Changes since v1: >>>>> - Cc stable and fix tested on tag >>>>> - Clear essential fields as they may have stale data >>>>> >>>>> Changes since v2: >>>>> - Add comment and reviewed by tag >>>>> --- >>>>> drivers/net/wireless/ath/ath11k/core.c | 6 +----- >>>>> drivers/net/wireless/ath/ath11k/hal.c | 16 ++++++++++++++++ >>>>> drivers/net/wireless/ath/ath11k/hal.h | 1 + >>>>> 3 files changed, 18 insertions(+), 5 deletions(-) >>>>> >>>>> diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c >>>>> index 4488e4cdc5e9e..34b27711ed00f 100644 >>>>> --- a/drivers/net/wireless/ath/ath11k/core.c >>>>> +++ b/drivers/net/wireless/ath/ath11k/core.c >>>>> @@ -2213,14 +2213,10 @@ static int ath11k_core_reconfigure_on_crash(struct ath11k_base *ab) >>>>> mutex_unlock(&ab->core_lock); >>>>> >>>>> ath11k_dp_free(ab); >>>>> - ath11k_hal_srng_deinit(ab); >>>>> + ath11k_hal_srng_clear(ab); >>>>> >>>>> ab->free_vdev_map = (1LL << (ab->num_radios * TARGET_NUM_VDEVS(ab))) - 1; >>>>> >>>>> - ret = ath11k_hal_srng_init(ab); >>>>> - if (ret) >>>>> - return ret; >>>>> - >>>>> clear_bit(ATH11K_FLAG_CRASH_FLUSH, &ab->dev_flags); >>>>> >>>>> ret = ath11k_core_qmi_firmware_ready(ab); >>>>> diff --git a/drivers/net/wireless/ath/ath11k/hal.c b/drivers/net/wireless/ath/ath11k/hal.c >>>>> index b32de563d453a..e8ebf963f195c 100644 >>>>> --- a/drivers/net/wireless/ath/ath11k/hal.c >>>>> +++ b/drivers/net/wireless/ath/ath11k/hal.c >>>>> @@ -1359,6 +1359,22 @@ void ath11k_hal_srng_deinit(struct ath11k_base *ab) >>>>> } >>>>> EXPORT_SYMBOL(ath11k_hal_srng_deinit); >>>>> >>>>> +void ath11k_hal_srng_clear(struct ath11k_base *ab) >>>>> +{ >>>>> + /* No need to memset rdp and wrp memory since each individual >>>>> + * segment would get cleared ath11k_hal_srng_src_hw_init() and >>>> >>>> nit: s/cleared /cleared in/ >>> Please can you make this change while applying the patch? >> >> I can make this change when I pull the patch into the pending branch. >> I'd like to see a public Reviewed-by before doing so. >> >> Also note that, except for anything critical, I'm not taking any patches into >> ath-next until the upcoming v6.17 merge window closes and all changes made to >> Linus' tree have been backmerged via net-next => wireless-next => ath-next. > Thank you for mentioning. I didn't know the workflow. > > No problem. There is no hurry. I've modified this comment in my 'pending' branch: https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/commit/?h=pending&id=9de41dd4c35fca6ebfe300b3799507dcafb9005e I'll promote to ath-next before my pull request to wireless for the v6.18 merge window. /jeff