From: Ivan Vecera <ivecera@redhat.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Prathosh Satish <Prathosh.Satish@microchip.com>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
Jiri Pirko <jiri@resnulli.us>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] dpll: zl3073x: Fix double free in zl3073x_devlink_flash_update()
Date: Thu, 25 Sep 2025 07:14:33 +0200 [thread overview]
Message-ID: <b288c52c-a3a6-4665-a777-2eb8464e883d@redhat.com> (raw)
In-Reply-To: <aNKAvXzRqk_27k7E@stanley.mountain>
On 23. 09. 25 1:13 odp., Dan Carpenter wrote:
> The zl3073x_devlink_flash_prepare() function calls zl3073x_fw_free()
> and the caller also calls zl3073x_devlink_flash_update() so it leads
> to a double free. Delete the extra free.
>
> Fixes: a1e891fe4ae8 ("dpll: zl3073x: Implement devlink flash callback")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/dpll/zl3073x/devlink.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/dpll/zl3073x/devlink.c b/drivers/dpll/zl3073x/devlink.c
> index f55d5309d4f9..ccc22332b346 100644
> --- a/drivers/dpll/zl3073x/devlink.c
> +++ b/drivers/dpll/zl3073x/devlink.c
> @@ -167,7 +167,6 @@ zl3073x_devlink_flash_prepare(struct zl3073x_dev *zldev,
> zl3073x_devlink_flash_notify(zldev,
> "Utility is missing in firmware",
> NULL, 0, 0);
> - zl3073x_fw_free(zlfw);
> return -ENOEXEC;
> }
Thanks, Dan!
Reviewed-by: Ivan Vecera <ivecera@redhat.com>
prev parent reply other threads:[~2025-09-25 5:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 11:13 Dan Carpenter
2025-09-24 17:00 ` Simon Horman
2025-09-25 13:28 ` Dan Carpenter
2025-09-25 5:14 ` Ivan Vecera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b288c52c-a3a6-4665-a777-2eb8464e883d@redhat.com \
--to=ivecera@redhat.com \
--cc=Prathosh.Satish@microchip.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=dan.carpenter@linaro.org \
--cc=jiri@resnulli.us \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®