From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6C5AD255F2C for ; Fri, 14 Nov 2025 16:33:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763138035; cv=none; b=Lu8qiUV321n3bG1TjuhLGIxb6N8MMepneWZZx4vcO1mxygAkYDjRq7U62iIFuQDP0FTt5h8/n4ii2l8/VCwQOzbHttxIhIZyO8UKegX8oAlvmNlBD35K6/+NgI8izwe/MFLBjKOw4ez7LKm9N11wXIFHRL56gRp0zJwwYzI0dvI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763138035; c=relaxed/simple; bh=xyPF6qjYtltKtKDt7x6yZ+7+BjAY9zStSXu6SzYs5fY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NaR0PKrR2Fid0LwYXEQLujvXKlwSIQRqIg+7BpcQ14opG9+7rOMLS/qpkRm/lRrX3v7+rv/MDzSmiDOHoXj3M9TcxdT+3GGNYpEiijfePhsFSzQMXyA9GKAi4+96QjD0I8f2uyJhejUQZhM6jYI6PKzcUig7PTXc+veZ6XhhTsY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0F0401063; Fri, 14 Nov 2025 08:33:46 -0800 (PST) Received: from [10.1.39.17] (e122027.cambridge.arm.com [10.1.39.17]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 756113F5A1; Fri, 14 Nov 2025 08:33:51 -0800 (PST) Message-ID: Date: Fri, 14 Nov 2025 16:33:49 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/8] drm/panthor: Add support for Mali-G1 GPUs To: Karunika Choo , dri-devel@lists.freedesktop.org Cc: nd@arm.com, Boris Brezillon , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org References: <20251107142440.1134528-1-karunika.choo@arm.com> From: Steven Price Content-Language: en-GB In-Reply-To: <20251107142440.1134528-1-karunika.choo@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Karunika, This series doesn't seem to cleanly apply on drm-misc-next (and I can't figure out what base you used). Would you mind doing a rebase and resend? Thanks, Steve On 07/11/2025 14:24, Karunika Choo wrote: > This patch series extends the Panthor driver with basic support for > Mali-G1 GPUs. > > The v14 architecture introduces several hardware and register-level > changes compared to prior GPUs. This series adds the necessary > architecture-specific support infrastructure, power control and reset > handling for Mali-G1 GPUs. > > Patch Breakdown: > [Patch 1-2]: Refactor panthor_hw to introduce architecture-specific > hooks and abstractions to support the v14 architecture. > These patches introduce architecture-specific HW binding > for function pointers. > [Patch 3-5]: Adds basic L2 power on/off and soft reset support for the > PWR_CONTROL block introduced in v14. > [Patch 6]: Update MCU halt and warm boot operations to reflect the > GLB_REQ.STATE changes in v14. This ensures that the MCU is > properly halted and the correct operations are performed > on warm boot depending on the FW version. > [Patch 7]: Align endpoint_req with changes introduced in v14, where > the register is widened to 64-bit and shifed down by > 4-bytes. This patch adds the necessary infrastructure to > discern the correct endpoint_req register to use. > [Patch 8]: Enables Mali-G1 support on Panthor by adding HW bindings > for v14 architecture, product names and path to FW binary. > > v4: > * Fixed include and forward declaration issues. > * Addressed code format issues. > * Picked up R-bs from Steve. > * Link to v3: https://lore.kernel.org/all/20251027161334.854650-1-karunika.choo@arm.com/ > v3: > * Updated include logic to enable static inline functions in > panthor_hw.h for function pointers and feature checks. > * Fixed missed replacement of CSF_IFACE_VERSION check with > panthor_fw_has_glb_state() check. > * Link to v2: https://lore.kernel.org/all/20251024202117.3241292-1-karunika.choo@arm.com/ > v2: > * Merged GPU_ID refactoring patch with the arch-specific panthor_hw > binding patch (formerly PATCH 01/10 and PATCH 02/10). > * Dropped panthor_hw feature bitmap patch in favor of functions that > performs the relevant architecture version checks. > * Fixed kernel test bot warnings. > * Replaced function pointer accessor MACROs with static inline > functions. > * Refined power control logic, removed unnecessary checks and redundant > stubs. > * Replaced explicit CSG_IFACE_VERSION checks with functions describing > the feature being checked for. > * General readability improvements, more consistent error handling, > behaviour clarifications, and formatting fixes. > * Link to v1: https://lore.kernel.org/all/20251014094337.1009601-1-karunika.choo@arm.com/ > > > Karunika Choo (8): > drm/panthor: Add arch-specific panthor_hw binding > drm/panthor: Add architecture-specific function operations > drm/panthor: Introduce panthor_pwr API and power control framework > drm/panthor: Implement L2 power on/off via PWR_CONTROL > drm/panthor: Implement soft reset via PWR_CONTROL > drm/panthor: Support GLB_REQ.STATE field for Mali-G1 GPUs > drm/panthor: Support 64-bit endpoint_req register for Mali-G1 > drm/panthor: Add support for Mali-G1 GPUs > > drivers/gpu/drm/panthor/Makefile | 1 + > drivers/gpu/drm/panthor/panthor_device.c | 18 +- > drivers/gpu/drm/panthor/panthor_device.h | 8 + > drivers/gpu/drm/panthor/panthor_fw.c | 131 +++++- > drivers/gpu/drm/panthor/panthor_fw.h | 32 +- > drivers/gpu/drm/panthor/panthor_gpu.c | 12 +- > drivers/gpu/drm/panthor/panthor_gpu.h | 1 + > drivers/gpu/drm/panthor/panthor_hw.c | 107 ++++- > drivers/gpu/drm/panthor/panthor_hw.h | 47 +- > drivers/gpu/drm/panthor/panthor_pwr.c | 549 +++++++++++++++++++++++ > drivers/gpu/drm/panthor/panthor_pwr.h | 23 + > drivers/gpu/drm/panthor/panthor_regs.h | 79 ++++ > drivers/gpu/drm/panthor/panthor_sched.c | 21 +- > 13 files changed, 989 insertions(+), 40 deletions(-) > create mode 100644 drivers/gpu/drm/panthor/panthor_pwr.c > create mode 100644 drivers/gpu/drm/panthor/panthor_pwr.h > > -- > 2.49.0 >