From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D81752C0F7F for ; Mon, 20 Oct 2025 18:06:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760983611; cv=none; b=Fpue493rkzMPtoDqewf4gQka72pcbMDoNUdH6VRnrpHbdtAmSul0K36lOH8U4wh7nOEmUCVCz/NkASxtdtlxV5y53n7a41RnCZZgbMCUIbo4lAkDMYhrdvpAtQ7cZzu0/Zp4cY+Dhyei7hvLDwkgVHsPRmlXlKw3tswCEIE5jac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760983611; c=relaxed/simple; bh=JSD7zMinFfnI7sgmhr156UXVmdLj4D4xD4iX+dvck18=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bmTKVTOxBpKQAedpbU9FsIxZ8sLIGWhPsSeX5xdDaLKLZqz3wGKWjQCnToYkkuqxRqn4f2mSEZ7aVzgYwvzDHrNM12J5LDkXaL77VwY1Q1h0XXnGI8d0Y6n0sgXsvZW9bxcxBd+3me9oO3AJERPl3inMDa0lbBxR6MACvx25fjE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=yL2syj3y; arc=none smtp.client-ip=209.85.166.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="yL2syj3y" Received: by mail-io1-f48.google.com with SMTP id ca18e2360f4ac-940d327df21so101523239f.1 for ; Mon, 20 Oct 2025 11:06:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1760983609; x=1761588409; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5AQlGU0mYQ6QSlBwOOl9dIxsMJVc/9az/WvQw51SeIA=; b=yL2syj3yBgiXoEj8bb/B4DosqxIP+OWLeFYusqaYaOFKse1m9BUCVCw2xd6rosL4Ge b61WVl1U8teBPjgTYcAZ485yPevfWJVl16PANjLe/pSOxFb/M69XPbFZqikhj2YcfuCm 2VnEYENQX5mhJdGrn1p1WG61d0g9FB7Xo3aT4YnawCag4KKV5ItO7xDw6u9YUNNWoThr RDPfNB/+oc/dDBpfkOBfeR1SIk/RhCiklfJYLe+wc8UCOyuRJHG5p7zx+o4ejt2MxtRv nfTIFI2/fpsNT4W6VULv+NLKqAD2JlTJ4uS2eJBIP6o5mS3YrrsMxwAcOx+QZTcMyA8H uskw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760983609; x=1761588409; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5AQlGU0mYQ6QSlBwOOl9dIxsMJVc/9az/WvQw51SeIA=; b=stibUXirowfm62qUxUfV/FHZFISFoj0lMKJpGOkeKaoe+6nuCKvIKVEXQo2IAHUtid WX1M0s0ehYXoMsew/rbCNmsaeFscs8tJyTOrYfDrpGXagpFgpYQ97np1gGzAEUuc83yL u9lo/XmYOA21GNNQBcejg0Cyol0Xd4DgjjrurqNriTWeH3DwjuqdlI1YCfBALytihnjH m6hFs80nxYdf6vM2kA0rppnyYg4uUuZE75m8bjV9sZ9WrCyQZIhhcdBekZ7RKbybGT+/ c9wXLfm5UJNKswQmZ+zzupPN3/1grSCL/m8X3MQ6vdPh8/k/k9GBs3dYUGGVXebbATvU tasA== X-Forwarded-Encrypted: i=1; AJvYcCWWmxu0QmLwsYB8ok+OWXy0eKMCLyUxxt0QFpouQYlyNIeL9/4miE5QtM6bl2WDTXN5Hb0dyD6D4Zdhgpk=@vger.kernel.org X-Gm-Message-State: AOJu0YxVAf/zcbE2RdMuxcGANGpILro6hG9VzUOWcXI7KqvH6NuGASgq 5IeJ0kXPa9l5N5YAc9nwZdcc79LXwaLwaTm710iAQ6cSW6InhGWG6aSouNy48hF+wLY= X-Gm-Gg: ASbGnctis3J8Q0OvXgEqG458gFupm+isgDSHDo0rH7L7DyfLwcUgd9WaIzTSbGQhkyl 6nbJrkuX0FS6PfNp1nQ5aEGzlOhWp3D6300aS35AfDlM77WLkQJYpuQkQS2L3EM6GGJ/oz066ep dQ/yPDJSGOsU58Glk+TgCcAIefYBJbMcOGuMZVEZJqrLICry5LDAR/fs7UGY7/FuNeFgF3KYBgq 3qgw9QiwR6MtYfnEN2bGpcvsYk3hDtL4IV83mke5FqRJK0YYShtD4UOsRVYrgZvYaPN3mM2jFwB y9Ghvy/NP6zXT3dYhoLP7DjHkf4+62iO1X4ktM0eh0S6PT1Qx/TMXBFc+ZxVSanlEnRWicPZLJl Ya5DjZXUWjxuJHe0TydA001comgEPOdwrH/b089RTmg1a+Rpgl3j3Y1b9+0k60W5HGKy9OK2WHm x6Z1t7vN71ZdOzVAUGMqFVs90YKrKPsD0Q7KoBPhQ= X-Google-Smtp-Source: AGHT+IHBHKCx2YHdGAi+SFpNeca9RlxGKdmS/mH/TPdmxuSdnx64GJbh4fpZfHVsL9gExE3U3dhRbA== X-Received: by 2002:a92:cda3:0:b0:430:b4ca:2696 with SMTP id e9e14a558f8ab-430c514e290mr212982775ab.0.1760983608698; Mon, 20 Oct 2025 11:06:48 -0700 (PDT) Received: from [172.22.22.28] (c-75-72-117-212.hsd1.mn.comcast.net. [75.72.117.212]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-5a8a961e88csm3172542173.15.2025.10.20.11.06.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Oct 2025 11:06:47 -0700 (PDT) Message-ID: Date: Mon, 20 Oct 2025 13:06:46 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/8] dt-bindings: spi: fsl-qspi: support SpacemiT K1 To: Conor Dooley Cc: han.xu@nxp.com, broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, dlan@gentoo.org, guodong@riscstar.com, devicetree@vger.kernel.org, linux-spi@vger.kernel.org, imx@lists.linux.dev, spacemit@lists.linux.dev, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org References: <20251020165152.666221-1-elder@riscstar.com> <20251020165152.666221-3-elder@riscstar.com> <20251020-blinked-primary-2b69cf37e9fe@spud> Content-Language: en-US From: Alex Elder In-Reply-To: <20251020-blinked-primary-2b69cf37e9fe@spud> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/20/25 12:39 PM, Conor Dooley wrote: > On Mon, Oct 20, 2025 at 11:51:45AM -0500, Alex Elder wrote: >> Add the SpacemiT K1 SoC QSPI IP to the list of supported hardware. >> >> Signed-off-by: Alex Elder >> --- >> Documentation/devicetree/bindings/spi/fsl,spi-fsl-qspi.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/spi/fsl,spi-fsl-qspi.yaml b/Documentation/devicetree/bindings/spi/fsl,spi-fsl-qspi.yaml >> index 0315a13fe319a..5bbda4bc33350 100644 >> --- a/Documentation/devicetree/bindings/spi/fsl,spi-fsl-qspi.yaml >> +++ b/Documentation/devicetree/bindings/spi/fsl,spi-fsl-qspi.yaml >> @@ -22,6 +22,7 @@ properties: >> - fsl,imx6ul-qspi >> - fsl,ls1021a-qspi >> - fsl,ls2080a-qspi >> + - spacemit,k1-qspi > > Are the newly added resets mandatory for the spacemit platform? This is interesting. I never even tried it without specifying them. I just tried it, and at least on my system QSPI functioned without defining these resets. I will ask SpacemiT about this. If they are not needed I will omit the first patch (which added optional resets), and won't use them. Thanks for pointing this out. -Alex > >> - items: >> - enum: >> - fsl,ls1043a-qspi >> -- >> 2.48.1 >>